From: Ira Weiny <ira.weiny@intel.com>
To: alison.schofield@intel.com
Cc: Ben Widawsky <ben.widawsky@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
linux-cxl@vger.kernel.org, kernel test robot <lkp@intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] cxl/mbox: Replace NULL check with IS_ERR() after vmemdup_user()
Date: Tue, 12 Apr 2022 09:39:57 -0700 [thread overview]
Message-ID: <YlWrXV93VqBdHPxp@iweiny-desk3> (raw)
In-Reply-To: <20220407010915.1211258-1-alison.schofield@intel.com>
On Wed, Apr 06, 2022 at 06:09:15PM -0700, Alison Schofield wrote:
> From: Alison Schofield <alison.schofield@intel.com>
>
> vmemdup_user() returns an ERR_PTR() on failure. Use IS_ERR()
> to check the return value.
>
> Fixes: be0d0ce77aa3 ("cxl/mbox: Move build of user mailbox cmd to a helper funct
> ions")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> ---
> drivers/cxl/core/mbox.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index 8a8388599a85..2449878d4b4b 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -263,7 +263,7 @@ static int cxl_mbox_cmd_ctor(struct cxl_mbox_cmd *mbox,
> if (in_size) {
> mbox->payload_in = vmemdup_user(u64_to_user_ptr(in_payload),
> in_size);
> - if (!mbox->payload_in)
> + if (IS_ERR(mbox->payload_in))
> return PTR_ERR(mbox->payload_in);
>
> if (!cxl_payload_from_user_allowed(opcode, mbox->payload_in)) {
>
> base-commit: 7dc1d11d7abae52aada5340fb98885f0ddbb7c37
> --
> 2.31.1
>
prev parent reply other threads:[~2022-04-12 16:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 1:09 [PATCH] cxl/mbox: Replace NULL check with IS_ERR() after vmemdup_user() alison.schofield
2022-04-12 16:39 ` Ira Weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlWrXV93VqBdHPxp@iweiny-desk3 \
--to=ira.weiny@intel.com \
--cc=alison.schofield@intel.com \
--cc=ben.widawsky@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=lkp@intel.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox