From: Ira Weiny <ira.weiny@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dan Williams <dan.j.williams@intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ben Widawsky <bwidawsk@kernel.org>, <linux-cxl@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>
Subject: Re: [PATCH V2 1/2] PCI: Allow drivers to request exclusive config regions
Date: Thu, 25 Aug 2022 13:03:38 -0700 [thread overview]
Message-ID: <YwfVmlissGgXo+Y8@iweiny-desk3> (raw)
In-Reply-To: <Ywcl6HPZ4HYCc641@kroah.com>
On Thu, Aug 25, 2022 at 09:34:00AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Aug 24, 2022 at 04:24:49PM -0700, ira.weiny@intel.com wrote:
> > --- a/include/linux/pci.h
> > +++ b/include/linux/pci.h
> > @@ -409,6 +409,7 @@ struct pci_dev {
> > */
> > unsigned int irq;
> > struct resource resource[DEVICE_COUNT_RESOURCE]; /* I/O and memory regions + expansion ROMs */
> > + struct resource config_resource; /* driver exclusive config ranges */
>
> Naming is hard, but let's make this obvious what this resource is for as
> your comment states. How about:
> struct resource driver_exclusive_resource;
Done.
>
> Other than that, looks better to me, thanks for the update.
Thanks!
Ira
>
> greg k-h
next prev parent reply other threads:[~2022-08-25 20:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 23:24 [PATCH V2 0/2] CXL: Taint user access to DOE mailbox config space ira.weiny
2022-08-24 23:24 ` [PATCH V2 1/2] PCI: Allow drivers to request exclusive config regions ira.weiny
2022-08-25 7:34 ` Greg Kroah-Hartman
2022-08-25 20:03 ` Ira Weiny [this message]
2022-08-25 15:06 ` Jonathan Cameron
2022-08-25 15:47 ` Ira Weiny
2022-08-30 12:53 ` Jonathan Cameron
2022-08-24 23:24 ` [PATCH V2 2/2] cxl/doe: Request exclusive DOE access ira.weiny
2022-08-25 14:59 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwfVmlissGgXo+Y8@iweiny-desk3 \
--to=ira.weiny@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=bhelgaas@google.com \
--cc=bwidawsk@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox