Linux CXL
 help / color / mirror / Atom feed
From: Gregory Price <gourry@gourry.net>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Hongjian Fan <hongjian.fan@seagate.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
	"fan.ni@samsung.com" <fan.ni@samsung.com>
Subject: Re: [PATCH] hw/mem: support zero memory size CXL device
Date: Thu, 23 Jan 2025 10:23:30 -0500	[thread overview]
Message-ID: <Z5Je8gZb_7pTQ1RW@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <20241224151315.0000068e@huawei.com>

On Tue, Dec 24, 2024 at 03:13:15PM +0000, Jonathan Cameron wrote:
> On Tue, 10 Dec 2024 14:13:29 -0500
> Gregory Price <gourry@gourry.net> wrote:
> 
> > On Tue, Dec 03, 2024 at 09:15:51PM +0000, Hongjian Fan wrote:
> > > Hi Jonathan,
> > > 
> > > I'm trying to emulate our memory appliance which is similar to a MH-SLD. The memory device is connected to the host server while the size of the memory could be changed by the out-of-band fabric manager. If there is no memory assigned to the host, the CXL device will be booted as zero memory size.  
> > 
> > This should not be how this is done.
> Agreed, but...
> 
> It sounds like a pre DCD boot time only pooling solution?
> 
> What is the path to adding memory?
>
> > 
> > The ACPI tables should report the maximum possible size, and the DCD
> > infrastructure should enable physical regions that have been added to the host.
> > 
> This isn't the ACPI bit, it's just the device reporting.  Can have a huge
> CFMWS and tiny devices.
> 

If the device is booted as a 0-memory device, how is the CFMWS populated
with the capacity needed to back it? It's all coming from the same
tables.

You poked the right spot in their post - we need more information about
how the memory is added.

If the intent is to just increase/decrease the capacity of the device
on the surface, then the only method I can see here is "tear the device
device down and re-initialize it". At least then - I think? - the driver
will go off and create the appropriate resources.  I've played with this
in QEMU previously in the past, so I *think* that works?

If it doesn't do that, then they'll need to go off and basically
re-invent DCD for their device in the driver (or via fwctl? yikes).



Side note, after thinking about it: a 0-memory device at least lets you
poke all the control bits without having to care about the actual memory
piece, so maybe that's useful regardless.

~Gregory

  reply	other threads:[~2025-01-23 15:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-02 23:03 [PATCH] hw/mem: support zero memory size CXL device Hongjian Fan
2024-12-03 17:23 ` Jonathan Cameron
2024-12-03 21:15   ` Hongjian Fan
2024-12-10 19:13     ` Gregory Price
2024-12-24 15:13       ` Jonathan Cameron
2025-01-23 15:23         ` Gregory Price [this message]
2024-12-04  2:26   ` [PATCH v2] " Hongjian Fan
2025-01-21 16:24     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z5Je8gZb_7pTQ1RW@gourry-fedora-PF4VCD3F \
    --to=gourry@gourry.net \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=fan.ni@samsung.com \
    --cc=hongjian.fan@seagate.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox