From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08D9D1F4611 for ; Mon, 10 Feb 2025 20:13:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739218399; cv=none; b=k2Hmwis5gtJWWRGuLU0C/cYgV5c6eiUE8NvIFu200hi4KEo1vc0Jl3PCHWXFh9HvJxz2QxHXcO8cdvjhS7E5YqPiNLofXmPTnRyRhJ7gpDcggj90F+ixfcehOBeSHM6mbffX7pp3d9vSV9i4iR1QaDyiA1aQp/ToE1eSmi/Z21s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739218399; c=relaxed/simple; bh=1c4M5xL5N+ZqW32clpzVCbTlEl8XeyMzw4K37//6rlY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nvGx8Lv2grAA8IqVMhkN/ti5kWxIG53n8kTom4oy49i31eLhqAdkX+vMbOLGwqKRJBaoHMT1gB///z7I6cjZHv0mzAYLUov+6tY3NyNI74oUHuBxqgxWR0Io+ilVmTOW0UZOHkc5Absz873qIKSfOUjxY5U7Pu9X8ohCt61un18= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=U61+4GpY; arc=none smtp.client-ip=209.85.219.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="U61+4GpY" Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-6dd049b5428so39139256d6.2 for ; Mon, 10 Feb 2025 12:13:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1739218396; x=1739823196; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IsA2D7RWwZNKkZanu5txIKeWQkXNdP5BKkyfvi0dKOg=; b=U61+4GpYCHcufU8AZAbuPtapiX4t0ewrhRzeN8y9+0sFeWUvy+slSXPW6umtFe0Y/J 543HLMudwMqDgNHSVWqtn1IVM/4YqSbaGjXbG4QcMCS+5lho7+gU6M+Ai+/mGLFpC4Uw /P0hxuHX7g1zw8o/lRq2m0VatouvDewW9vD17EHG/8yKPOyDyfCxXL8muiP1Y9gVx8pc W7D8URb9RAwKHc9j8kO30sJBJFZ65Rs++/tzgc0KliD0rmzn3o+uNPVBGxA4/7Jk927j uYAW2EJAHNJHTM2A9/xo+WqUV/rEH6QTdpWqziZkowU8b3QKQ6lHtBrVZA4EVRm2xBfV Za1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739218396; x=1739823196; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IsA2D7RWwZNKkZanu5txIKeWQkXNdP5BKkyfvi0dKOg=; b=CPglFB1jO5EGsUxV0MegQWyPK+rAQ99BcBEAUfB2x/MXHIGTtdcWt3+0LfQBpIgN1Q lEVawldQ/HL51oIolIQrUQL/6156ZRrfprCONYwqBoPAxrba6PSgpDy7qqAPcyimQgzV /vN8JtRQLfG1saud3varXSB6UVCqfz6+PDl7/2nR/CYYR/iBJtbK11asrk1ATPfUUGQu TfQzsVJM1uG+rEbuwxwt4uIH8rEFX8+mHdcIzrz/T/gqAPx9HUgXHj10zVWbOdwmOEzC Lo8D6oRZLyIL4Q0lBgFw40cGjD4qka/+7/54RkPA1hV6HjwFTZdcsfld88wt3VHAQxP3 3N1Q== X-Gm-Message-State: AOJu0YwEwvUnmVjuF1jQ748ZY5W4IggvrcpB/1L5s8CRTyXlhgD53uu2 lW2xjgXo4JrIc5LPAtRsaAPXp6hWTxF6z46zqB426aRKE05/lT/TzSSfcY8YKow= X-Gm-Gg: ASbGnct3cAbur6eSGq73AhXyjzN4mKACPEFAve0ERmUE7pzug9nKiq/rCEPwnNF9gQ2 TddM0GuRxyVmDtbuVK9majDeVTELG4kYC7gRd7Y9hBXO4LfjVenHdwNDtwkNFPn9u1x3Gt3J5e2 spJCeRXukXM74KsbP20TGxPEzei4JP3Ba/cr58JUhmQXKSYDvwAefEJYYoNISqw5gfBCnr5Hn4l WJWnvrR76uwyvCMZASyaGZ/5lr/ttcxS4mbDOxf3hCkaO7SqzcEcfgvASMOMSfCYAcBUoZqghof X9rxFgFHbRZr4INy/6N7LMYkE2YtDqJGJOKGnPEM82LioNJtVW+gT/s79Pd88H8N0LUCKjzVcg= = X-Google-Smtp-Source: AGHT+IHUip5YMADfXv9mqUnuwstRyUZVEWa8wwzCcohodaY75zHwttm/vgjHcKoIUdbSid7/1TXa5A== X-Received: by 2002:ad4:5dea:0:b0:6d8:a946:eee5 with SMTP id 6a1803df08f44-6e445692b85mr232828896d6.23.1739218395869; Mon, 10 Feb 2025 12:13:15 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6e456893843sm25923626d6.59.2025.02.10.12.13.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 12:13:15 -0800 (PST) Date: Mon, 10 Feb 2025 15:13:13 -0500 From: Gregory Price To: Terry Bowman Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, nifan.cxl@gmail.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, dan.j.williams@intel.com, bhelgaas@google.com, mahesh@linux.ibm.com, ira.weiny@intel.com, oohall@gmail.com, Benjamin.Cheatham@amd.com, rrichter@amd.com, nathan.fontenot@amd.com, Smita.KoralahalliChannabasappa@amd.com, lukas@wunner.de, ming.li@zohomail.com, PradeepVineshReddy.Kodamati@amd.com Subject: Re: [PATCH v6 06/17] PCI/AER: Add CXL PCIe Port uncorrectable error recovery in AER service driver Message-ID: References: <20250208002941.4135321-1-terry.bowman@amd.com> <20250208002941.4135321-7-terry.bowman@amd.com> Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250208002941.4135321-7-terry.bowman@amd.com> On Fri, Feb 07, 2025 at 06:29:30PM -0600, Terry Bowman wrote: > diff --git a/drivers/cxl/core/pci.c b/drivers/cxl/core/pci.c > index a5c65f79db18..eda532f7440c 100644 > --- a/drivers/cxl/core/pci.c > +++ b/drivers/cxl/core/pci.c > @@ -661,10 +661,16 @@ static void __cxl_handle_cor_ras(struct cxl_dev_state *cxlds, > > addr = ras_base + CXL_RAS_CORRECTABLE_STATUS_OFFSET; > status = readl(addr); > - if (status & CXL_RAS_CORRECTABLE_STATUS_MASK) { > - writel(status & CXL_RAS_CORRECTABLE_STATUS_MASK, addr); > - trace_cxl_aer_correctable_error(cxlds->cxlmd, status); > + if (!(status & CXL_RAS_CORRECTABLE_STATUS_MASK)) { > + dev_err(cxl_dev, "%s():%d: CE Status is empty\n", __func__, __LINE__); > + return; > } > + writel(status & CXL_RAS_CORRECTABLE_STATUS_MASK, addr); > + > + if (is_cxl_memdev(cxl_dev)) > + trace_cxl_aer_correctable_error(to_cxl_memdev(cxl_dev), status); > + else if (is_cxl_port(cxl_dev)) > + trace_cxl_port_aer_correctable_error(cxl_dev, pcie_dev, status); > } Build errors here - after looking into it a little more, seems like these changes are actually meant for a later commit. I dropped this and let the later commits pick it up and it seems to build more cleanly. ~Gregory