From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1A34212D97 for ; Thu, 20 Feb 2025 17:31:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740072673; cv=none; b=R7rI9/IsrRI/4C6Rfz9nrr3Ef49UG3IFK4a8yLOjOSotk1BvXKZxyeABWT2yff8kE/rjya4rf806nzvKMnMygslyUGNFgGAg57M8Sn7BBBHzFxDRiYj2zjj7Z6DfsrTcVPDZLeUVtDuxcS32P5zm6Adpt7745FEADFWl6NmhsFc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740072673; c=relaxed/simple; bh=Ey8+OU07K9kFMi/slxHk+wmK5uae70juS2ijj/OEFX4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DjoTDz8jlN5KOXyAuK3NhvOuYaqHF8olC+CTp++wes1ncN8smro/qpX+BGRcx9PB6dP3mcrH1j5hX6pXaSzpJ2BQLSd3Gsuz3UaknVO1//mkcSb4xUhQ2RUwyx/qXtPoEy/bLdm5SLWGgI1avZbNrliIDrSTOQSv71RmBjyP+fo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=GhNU/lWi; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="GhNU/lWi" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-7c0c5682c41so58083485a.2 for ; Thu, 20 Feb 2025 09:31:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1740072671; x=1740677471; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1kKlkXCNBsbg1hSiU8FUD61eyE6dPTAUZNvwxeSK768=; b=GhNU/lWi+39Rb7ZZnkDTqXL1uvMBc5oHUwMQVJCpZJjmDsjAgsm7zCaoEYPkqdLbr/ TdHFCXdPerupEqBh+JSg2wnpzuMx5GJ9bNgjzpBF5hjNMuCOQKntF2igNsSssNcAoY9y whv82Q3jqQPQzlBkvlWS06pp263bd7a2IYuXZp6DqOZpKrWUOfgHEIhUci5wpDkTSL/l KAhou6Q4WQps91HwWtjlHrP1vq1aGl2RGH81ibXbKES+uIPB1tb6RuQOXXA4tfYoxNvw H+EL7NQ0PsMR43zjSOLGJ1D3qMRCx+BM30HJAcYrmL6zmuUxUDjVkFQLedQd6P49UR5v AmHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740072671; x=1740677471; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1kKlkXCNBsbg1hSiU8FUD61eyE6dPTAUZNvwxeSK768=; b=ns2ujQ/4AF5hBx04ikyOhQbXQ2OW5VNFzhDW9hgwrhdlW5VKTNmpqlDeVWgDFu+Wox 7fxuJlgys/ZK9BdYD84+Tzf89t/aJaylFPJw1pJGgniR4M4116G7emnQrfLun1w31+Ju yuIkeBg8zaG3+t98KzMwEYylZdLjOOXHH85BNHdMvqGR8ONnN+rQIFCOAaN54t+9vjBV SRaaOhhALDmXVMBt+kB4/rXq0V/9Bt20g1B9cPm/VggWMUQfhjU8dOzP7//iF0XhnNxg ioqIotnhrc7RmhqI4MdzmDkbti1PldzzuEolMFuXBelfI3A8bZJi35kbil718vK0M29C bgyA== X-Forwarded-Encrypted: i=1; AJvYcCVQiyc1Xn+TSjZ5CB7IadHipIrNTIhySeEybKT/mwclxV3cdD53D/UUD4MvyjSc8eGTBOBzXWz14yA=@vger.kernel.org X-Gm-Message-State: AOJu0YwweV0bs0qEfdIB7EtcAS4a/4s4ITjjQe7SuRslXmYJZGES/02J +1kdxNXTbZ+K+qQAr+mVjBWJ2g1NEybGM4EYyIn35ftXZX5tWBdYFZVyqaNENSI= X-Gm-Gg: ASbGncuVUlO/uWsoc5mNgmDJXLReIO23GKX3g06GUTRebgHohs453ZW9nJGhHysgage zz8XnLBvQnAd0RtOg9hxmnGU95Oj8+9Uf9iMQJHfVaqbUksT4RPmVmOAjXHiA/UUiJa7WDrayhv rkO9Uiu/I4KGQaf4rYD5I/XOoqPWaZVsW2uNAWDC30wbogpf/aRqGf6b6H4KjIphAY3Z4y87Nx/ dLkbbCWAg+HV299ap4dtNjCPSDI7zVdEYgZQGi5ScYDLz4hYV+a1FL8N7hPvQT3Fcul+Zywf0MR cz2M/xeuPXrWgTPf/+umLePbywtsqwwykfmyJW7uQdFjfDJZNqrgEwgrts57SVgyMqQCzZB0mg= = X-Google-Smtp-Source: AGHT+IHtz9ziu9H73OBuxBOPa7vDiNeRXwOaafTxvcP8JXQxND+yNZZLPxNMqyP89aPMmHCcTCqoMg== X-Received: by 2002:a05:620a:4002:b0:7c0:b3cd:9bcb with SMTP id af79cd13be357-7c0ceef9b9amr11334485a.23.1740072670683; Thu, 20 Feb 2025 09:31:10 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c0ab3e3383sm376379185a.81.2025.02.20.09.31.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2025 09:31:10 -0800 (PST) Date: Thu, 20 Feb 2025 12:31:08 -0500 From: Gregory Price To: Robert Richter Cc: Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Jonathan Cameron , Dave Jiang , Davidlohr Bueso , linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, "Fabio M. De Francesco" , Terry Bowman Subject: Re: [PATCH v2 04/15] cxl/region: Calculate endpoint's region position during init Message-ID: References: <20250218132356.1809075-1-rrichter@amd.com> <20250218132356.1809075-5-rrichter@amd.com> Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250218132356.1809075-5-rrichter@amd.com> On Tue, Feb 18, 2025 at 02:23:45PM +0100, Robert Richter wrote: > diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c > index ad4a6ce37216..6f106bfa115f 100644 > --- a/drivers/cxl/core/region.c > +++ b/drivers/cxl/core/region.c > @@ -1903,7 +1903,6 @@ static int cxl_region_sort_targets(struct cxl_region *cxlr) > for (i = 0; i < p->nr_targets; i++) { > struct cxl_endpoint_decoder *cxled = p->targets[i]; > > - cxled->pos = cxl_calc_interleave_pos(cxled); > /* > * Record that sorting failed, but still continue to calc > * cxled->pos so that follow-on code paths can reliably > @@ -3264,10 +3263,22 @@ static int cxl_endpoint_decoder_initialize(struct cxl_endpoint_decoder *cxled) > struct cxl_memdev *cxlmd = cxled_to_memdev(cxled); > struct cxl_port *iter = cxled_to_port(cxled); > struct cxl_decoder *root, *cxld = &cxled->cxld; > - struct range *hpa = &cxld->hpa_range; > + struct range hpa = cxld->hpa_range; > + struct cxl_interleave_context ctx; > + int rc; > > - while (iter && !is_cxl_root(iter)) > - iter = to_cxl_port(iter->dev.parent); > + ctx = (struct cxl_interleave_context) { > + .hpa_range = &hpa, > + }; > + > + while (iter && !is_cxl_root(iter)) { > + /* Convert interleave settings to next port upstream. */ > + rc = cxl_port_calc_interleave(iter, &ctx); Thinking about it a bit more, you still have cxl_port_calc_interleave returning the position, but you have the position captured in ctx. I think you just want to return 0/ERR now since ctx will have the pos. This makes me think patch 3 and 4 should just be 1 patch. > + if (rc < 0) > + return rc; > + > + iter = parent_port_of(iter); > + } > > if (!iter) > return -ENXIO; > @@ -3281,7 +3292,13 @@ static int cxl_endpoint_decoder_initialize(struct cxl_endpoint_decoder *cxled) > return -ENXIO; > } > > + dev_dbg(cxld->dev.parent, > + "%s:%s: range:%#llx-%#llx pos:%d\n", > + dev_name(&cxled->cxld.dev), dev_name(&cxld->dev), > + hpa.start, hpa.end, ctx.pos); > + > cxled->cxlrd = to_cxl_root_decoder(&root->dev); > + cxled->pos = ctx.pos; > > return 0; > } > -- > 2.39.5 >