Linux CXL
 help / color / mirror / Atom feed
From: Alison Schofield <alison.schofield@intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: linux-cxl@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH vv2] cxl: Fix warning from emitting resource_size_t as long long int on 32bit systems
Date: Fri, 28 Feb 2025 12:58:04 -0800	[thread overview]
Message-ID: <Z8IjXCwYSpNhVM27@aschofie-mobl2.lan> (raw)
In-Reply-To: <20250228204739.3849309-1-dave.jiang@intel.com>

On Fri, Feb 28, 2025 at 01:47:39PM -0700, Dave Jiang wrote:
> Reported by kernel test bot from an ARM build:
> drivers/cxl/core/region.c:3263:26: warning: format '%lld' expects argument of type 'long long int', but argument 3 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
> 
> On a 32bit system, resource_size_t is defined as 32bit long vs on a 64bit
> system it is defined as 64bit long. Use %pa format to deal with resource_size_t.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202503010252.mIDhZ5kY-lkp@intel.com/
> Fixes: 0ec9849b6333 ("acpi/hmat / cxl: Add extended linear cache support for CXL")
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>

Reviewed-by: Alison Schofield <alison.schofield@intel.com>



> ---
> v2:
> - Fix commit log spelling errors. (Alison)
> - Use %pa to deal with type resource_size_t. (Alison)
> ---
>  drivers/cxl/core/region.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
> index a83301f24fa2..8537b6a9ca18 100644
> --- a/drivers/cxl/core/region.c
> +++ b/drivers/cxl/core/region.c
> @@ -3251,8 +3251,8 @@ static int cxl_extended_linear_cache_resize(struct cxl_region *cxlr,
>  
>  	if (size != cache_size) {
>  		dev_warn(&cxlr->dev,
> -			 "Extended Linear Cache size %lld != CXL size %lld. No Support!",
> -			 cache_size, size);
> +			 "Extended Linear Cache size %pa != CXL size %pa. No Support!",
> +			 &cache_size, &size);
>  		return -EOPNOTSUPP;
>  	}
>  
> -- 
> 2.48.1
> 
> 

  reply	other threads:[~2025-02-28 20:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-28 20:47 [PATCH vv2] cxl: Fix warning from emitting resource_size_t as long long int on 32bit systems Dave Jiang
2025-02-28 20:58 ` Alison Schofield [this message]
2025-02-28 21:43 ` Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z8IjXCwYSpNhVM27@aschofie-mobl2.lan \
    --to=alison.schofield@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox