From: Alison Schofield <alison.schofield@intel.com>
To: Gregory Price <gourry@gourry.net>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Dave Jiang <dave.jiang@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
linux-cxl@vger.kernel.org
Subject: Re: [PATCH] cxl: Restore opcode order in enum cxl_opcode
Date: Fri, 7 Mar 2025 12:11:55 -0800 [thread overview]
Message-ID: <Z8tTCzP2ih3Aje9C@aschofie-mobl2.lan> (raw)
In-Reply-To: <Z8tQjmjseVgEyFCd@gourry-fedora-PF4VCD3F>
On Fri, Mar 07, 2025 at 03:01:18PM -0500, Gregory Price wrote:
> On Fri, Mar 07, 2025 at 10:12:10AM -0800, alison.schofield@intel.com wrote:
> > CXL_MBOX_OP_GET_LOG_CAPS = 0x0402,
> > CXL_MBOX_OP_CLEAR_LOG = 0x0403,
> > CXL_MBOX_OP_GET_SUP_LOG_SUBLIST = 0x0405,
> > - CXL_MBOX_OP_GET_SUPPORTED_FEATURES = 0x0500,
> > - CXL_MBOX_OP_GET_FEATURE = 0x0501,
> > - CXL_MBOX_OP_SET_FEATURE = 0x0502,
> > CXL_MBOX_OP_IDENTIFY = 0x4000,
> > CXL_MBOX_OP_GET_PARTITION_INFO = 0x4100,
> > CXL_MBOX_OP_SET_PARTITION_INFO = 0x4101,
> > @@ -551,6 +548,9 @@ enum cxl_opcode {
> > CXL_MBOX_OP_UNLOCK = 0x4503,
> > CXL_MBOX_OP_FREEZE_SECURITY = 0x4504,
> > CXL_MBOX_OP_PASSPHRASE_SECURE_ERASE = 0x4505,
> > + CXL_MBOX_OP_GET_SUPPORTED_FEATURES = 0x0500,
> > + CXL_MBOX_OP_GET_FEATURE = 0x0501,
> > + CXL_MBOX_OP_SET_FEATURE = 0x0502,
> > CXL_MBOX_OP_MAX = 0x10000
> > };
> >
>
> [04, 05, 45] seems like the right ordering for an enum, is this
> based on spec ordering?
No - just ignore this. Adjusting my eyeglasses.
>
> ~Gregory
prev parent reply other threads:[~2025-03-07 20:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 18:12 [PATCH] cxl: Restore opcode order in enum cxl_opcode alison.schofield
2025-03-07 20:01 ` Gregory Price
2025-03-07 20:11 ` Alison Schofield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8tTCzP2ih3Aje9C@aschofie-mobl2.lan \
--to=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=gourry@gourry.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox