From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 955DDC761A6 for ; Fri, 31 Mar 2023 15:41:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232320AbjCaPlp (ORCPT ); Fri, 31 Mar 2023 11:41:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229967AbjCaPlp (ORCPT ); Fri, 31 Mar 2023 11:41:45 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F8931DFA6; Fri, 31 Mar 2023 08:41:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680277304; x=1711813304; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=j22piGdNpFcD0Xm52EYLiQXxR1RIRcoCbgx4eDkM9Vw=; b=GwKO1SimrsNkpUH3BSQi21gW3vvmphryRKIID5e6JxRCGNWLSiruZNj3 m7kKTq3b5RSAX+bzfpYGR2lydelLqhJr0S5K8/DzlIWzm6ZmqivbzBBBB QRMgUOclV+eMQQD8FwE/5ux2/LDPSoQEVkTCEeFBVMZXIk3aITc1UBnFd kaDc0C8pPr8o47PQ+WZ1mR5nk4PdpqS9khtPEZPuqgfpHgW5jSXriwdwK CoFjrbvWS39G+z1lJBQad7RlxxjCJIj0MgRxzy1BwWBi9YEEARhNHBt1i 05bdvnFaB5KumnGLP5GSqS1AJiIPdcfqiMO6spX4M4D0yGhjFJLRIdiZO g==; X-IronPort-AV: E=McAfee;i="6600,9927,10666"; a="343146537" X-IronPort-AV: E=Sophos;i="5.98,307,1673942400"; d="scan'208";a="343146537" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2023 08:41:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10666"; a="809089696" X-IronPort-AV: E=Sophos;i="5.98,307,1673942400"; d="scan'208";a="809089696" Received: from aschofie-mobl2.amr.corp.intel.com (HELO aschofie-mobl2) ([10.209.63.54]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2023 08:41:43 -0700 Date: Fri, 31 Mar 2023 08:41:42 -0700 From: Alison Schofield To: Dave Jiang Cc: Dan Williams , Ira Weiny , Vishal Verma , Ben Widawsky , Steven Rostedt , linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron Subject: Re: [PATCH v10 1/6] cxl/mbox: Add GET_POISON_LIST mailbox command Message-ID: References: <7789c4ab210ca309b449ae948d3e56c44aaff38d.1679448904.git.alison.schofield@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org On Thu, Mar 30, 2023 at 03:43:18PM -0700, Dave Jiang wrote: > > > On 3/21/23 7:12 PM, alison.schofield@intel.com wrote: > > From: Alison Schofield > > > > CXL devices maintain a list of locations that are poisoned or result > > in poison if the addresses are accessed by the host. > > > > Per the spec (CXL 3.0 8.2.9.8.4.1), the device returns this Poison > > Maybe you need a comma here? > > > list as a set of Media Error Records that include the source of the > > extra space between "of" and "Media" > > > error, the starting device physical address and length. The length is > > Should add a comma before "and length". > > > the number of adjacent DPAs in the record and is in units of 64 bytes. > > > > Retrieve the poison list. FYI - this is v10, but things you are pointing out do apply to v11. I'll update the commit msg as you suggest. > > snip > > + > > +struct cxl_mbox_poison_payload_out { > > + u8 flags; > > + u8 rsvd1; > > + __le64 overflow_t; > > + __le16 count; > > + u8 rsvd2[20]; > > + struct cxl_poison_record { > > + __le64 address; > > + __le32 length; > > + __le32 rsvd; > > + } __packed record[]; > > +} __packed; > > Pretty long struct name. poison_mbox_in and poison_mbox_out? Yeah...I'll drop the _payload from each. Thanks! > snip to end.