From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4AF2C0015E for ; Sun, 30 Jul 2023 02:18:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229448AbjG3CS4 (ORCPT ); Sat, 29 Jul 2023 22:18:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229605AbjG3CSy (ORCPT ); Sat, 29 Jul 2023 22:18:54 -0400 Received: from mgamail.intel.com (unknown [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B2572D47; Sat, 29 Jul 2023 19:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690683534; x=1722219534; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=EQW1AUMVIHfkGxuTUZ5EIEjw4SLFZTzHQ6Y4u2cWtno=; b=f5X6nfEMXWBYMfRLK3zOH6CZ9RI8HUJhcHizmtXCOm2I/G2R7NrC1sex M4UZJ6do/7EmxE319kYMF4n7VK5R3Izt+RTAr1C8US+EibhOecWRVWycF wrZ6AB2s58hnCxwg8XX2a04HmASOThy2GAa6SSeWYRVqGNl2kNKIbZuWp XXfBjtNwDsPYkhw3Rp7rYPfVj2zUlmJqib65+z1Tip7wifHhWCKQgxXiz fJC/6E3pUYyeF8ASwLpXyZqmIBZCLncCljG9wRpKOr+9eei7gWDGbYwj1 Pv4PYZQZVd2YSIahpDiGNR0UcAq+CLG/atZXu+267CoecK9OIcwOj89lQ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10786"; a="399752508" X-IronPort-AV: E=Sophos;i="6.01,240,1684825200"; d="scan'208";a="399752508" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2023 19:18:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10786"; a="974492429" X-IronPort-AV: E=Sophos;i="6.01,240,1684825200"; d="scan'208";a="974492429" Received: from aschofie-mobl2.amr.corp.intel.com (HELO aschofie-mobl2) ([10.212.203.2]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2023 19:18:53 -0700 Date: Sat, 29 Jul 2023 19:18:51 -0700 From: Alison Schofield To: Raghu Halharvi Cc: linux-cxl@vger.kernel.org, ira.weiny@intel.com, bwidawsk@kernel.org, dan.j.williams@intel.com, vishal.l.verma@intel.com, linux-kernel@vger.kernel.org, Dave Jiang Subject: Re: [PATCH v7 2/2] cxl/region: Remove else after return statement Message-ID: References: <20230726073421.2452-1-raghuhack78@gmail.com> <20230726073421.2452-3-raghuhack78@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230726073421.2452-3-raghuhack78@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org On Wed, Jul 26, 2023 at 07:34:21AM +0000, Raghu Halharvi wrote: > Issue found with checkpatch > > The else section here is redundant after return statement, removing it. > Sanity and correctness is not affected due to this fix. > > Signed-off-by: Raghu Halharvi > Reviewed-by: Dave Jiang > Reviewed-by: Vishal Verma > Reviewed-by: Ira Weiny Reviewed-by: Alison Schofield > --- > drivers/cxl/core/region.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c > index e115ba382e04..bfd3b13dd2c1 100644 > --- a/drivers/cxl/core/region.c > +++ b/drivers/cxl/core/region.c > @@ -133,11 +133,11 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr) > &cxlr->dev, > "Bypassing cpu_cache_invalidate_memregion() for testing!\n"); > return 0; > - } else { > - dev_err(&cxlr->dev, > - "Failed to synchronize CPU cache state\n"); > - return -ENXIO; > } > + > + dev_err(&cxlr->dev, > + "Failed to synchronize CPU cache state\n"); > + return -ENXIO; > } > > cpu_cache_invalidate_memregion(IORES_DESC_CXL); > -- > 2.39.2 >