Re: [PATCH] cxl/mbox: Remove useless cast in cxl_mem_create_range_info()

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Mon, Aug 07, 2023 at 02:33:34PM +0100, Jonathan Cameron wrote:
> On Fri,  4 Aug 2023 12:03:09 -0700
> alison.schofield@intel.com wrote:
> 
> > From: Alison Schofield <alison.schofield@intel.com>
> > 
> > DEFINE_RES_MEM() returns a struct resource so the cast is not needed.
> > Remove it.

> Good to call out this is a result of Andy's cleanup
> 
> 42c4211f1 ("resource: Convert DEFINE_RES_NAMED() to be a compound literal")
> 
> I thought we'd long caught all of these (IIRC there were a few at the time).
> Ah well.

We caught only compile-time errors. The "casting" of the compound literal is
only a warning which doesn't affect code generation.

Btw, Alison, the commit message should really be more clear about those macros.
They are compound literals, which are associated with the corresponding data
type. It's not a cast there, but only on the side of the user. I'm not a native
speaker to suggest on how to amend, maybe Jonathan can help?

-- 
With Best Regards,
Andy Shevchenko