From: Fan Ni <fan.ni@gmx.us>
To: Xiao Yang <yangx.jy@fujitsu.com>
Cc: vishal.l.verma@intel.com, nvdimm@lists.linux.dev,
linux-cxl@vger.kernel.org
Subject: Re: [NDCTL PATCH] daxctl: Remove unused mem_zone variable
Date: Thu, 10 Aug 2023 10:02:13 -0700 [thread overview]
Message-ID: <ZNUYFSTHC6kEirhm@debian> (raw)
In-Reply-To: <20230809154636.11887-1-yangx.jy@fujitsu.com>
On Wed, Aug 09, 2023 at 11:46:36PM +0800, Xiao Yang wrote:
> mem_zone variable has never been used so remove it.
>
> Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
> ---
> daxctl/device.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/daxctl/device.c b/daxctl/device.c
> index d2d206b..360ae8b 100644
> --- a/daxctl/device.c
> +++ b/daxctl/device.c
> @@ -59,7 +59,6 @@ enum memory_zone {
> MEM_ZONE_MOVABLE,
> MEM_ZONE_NORMAL,
> };
The enum definition is not used also.
Fan
> -static enum memory_zone mem_zone = MEM_ZONE_MOVABLE;
>
> enum device_action {
> ACTION_RECONFIG,
> @@ -469,8 +468,6 @@ static const char *parse_device_options(int argc, const char **argv,
> align = __parse_size64(param.align, &units);
> } else if (strcmp(param.mode, "system-ram") == 0) {
> reconfig_mode = DAXCTL_DEV_MODE_RAM;
> - if (param.no_movable)
> - mem_zone = MEM_ZONE_NORMAL;
> } else if (strcmp(param.mode, "devdax") == 0) {
> reconfig_mode = DAXCTL_DEV_MODE_DEVDAX;
> if (param.no_online) {
> @@ -494,9 +491,6 @@ static const char *parse_device_options(int argc, const char **argv,
> align = __parse_size64(param.align, &units);
> /* fall through */
> case ACTION_ONLINE:
> - if (param.no_movable)
> - mem_zone = MEM_ZONE_NORMAL;
> - /* fall through */
> case ACTION_DESTROY:
> case ACTION_OFFLINE:
> case ACTION_DISABLE:
> --
> 2.40.1
>
next prev parent reply other threads:[~2023-08-10 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 15:46 [NDCTL PATCH] daxctl: Remove unused mem_zone variable Xiao Yang
2023-08-10 17:02 ` Fan Ni [this message]
2023-08-11 1:15 ` Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNUYFSTHC6kEirhm@debian \
--to=fan.ni@gmx.us \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
--cc=yangx.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox