Re: [PATCH v2] cxl/region: Add dev_dbg() detail on failure to allocate HPA space

[Alison Schofield <alison.schofield@intel.com>]

On Mon, Dec 04, 2023 at 05:46:26PM -0800, Dan Williams wrote:
> alison.schofield@ wrote:
> > From: Alison Schofield <alison.schofield@intel.com>

snip

> > 
> > 
> > Changes in v2:
> > - Improve the message text (Vishal)
> > - Add reviewed by tags (DaveJ, Vishal)
> > - Link to v1:
> > https://lore.kernel.org/linux-cxl/20231114040147.1124696-1-alison.schofield@intel.com/
> > 
> > 
> >  drivers/cxl/core/region.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
> > index 56e575c79bb4..ec792af873c4 100644
> > --- a/drivers/cxl/core/region.c
> > +++ b/drivers/cxl/core/region.c
> > @@ -552,8 +552,9 @@ static int alloc_hpa(struct cxl_region *cxlr, resource_size_t size)
> >  	res = alloc_free_mem_region(cxlrd->res, size, SZ_256M,
> >  				    dev_name(&cxlr->dev));
> >  	if (IS_ERR(res)) {
> > -		dev_dbg(&cxlr->dev, "failed to allocate HPA: %ld\n",
> > -			PTR_ERR(res));
> > +		dev_dbg(&cxlr->dev,
> > +			"HPA allocation error:%ld for size:%#llx in %s %pr\n",
> > +			PTR_ERR(res), size, cxlrd->res->name, cxlrd->res);
> 
> I notice that this did not pick up Vishal's suggested "error (%d) ..."
> style for conveying the error code.
> 
>    "HPA allocation error (%d) for size: %llx in %s ..."
> 
> I prefer that style as well.

I should have said something in the changelog. I rejected the
parentheses based on this: 

"Printing numbers in parentheses (%d) adds no value and should be
avoided."  in Documentation/process/coding-style.rst

Since it's a dev_dbg() msg I'll go ahead and add those parens.
(But this is not a precedent for parens all over ;))

Alison