Linux CXL
 help / color / mirror / Atom feed
From: Robert Richter <rrichter@amd.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Ira Weiny <ira.weiny@intel.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Jonathan Cameron <jonathan.cameron@huawei.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Alison Schofield <alison.schofield@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
	Fan Ni <nifan.cxl@gmail.com>, Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH] cxl/pci: Get rid of pointer arithmetic reading CDAT table
Date: Thu, 4 Jan 2024 14:43:23 +0100	[thread overview]
Message-ID: <ZZa1-11632f6CckT@rric.localdomain> (raw)
In-Reply-To: <657bd741d2961_269bd294d@dwillia2-mobl3.amr.corp.intel.com.notmuch>

On 14.12.23 20:34:09, Dan Williams wrote:

> struct cdat_response {
>        __le32 doe_header;
>        union {
>                struct cdat_header header;
>                struct cdat_entry_header entry;
>                u8 table[];
>        };
> } __packed;
> 
> As far as I can see nothing outside of drivers/cxl/core/pci.c needs
> 'struct cdat_response', so it can stay local to this C file.

I moved that close to cdat_header and cdat_entry_header which is also
defined in cxlpci.h but only used in core/pci.c. I would like to keep
them together but we could move that completely into pci.c in a
separate patch?

Thanks,

-Robert

      parent reply	other threads:[~2024-01-04 13:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-17  0:03 [PATCH] cxl/cdat: Free correct buffer on checksum error Ira Weiny
2023-11-17 15:50 ` Dave Jiang
2023-11-17 17:14 ` fan
2023-11-17 20:09 ` Robert Richter
2023-11-17 20:15   ` [PATCH] cxl/pci: Get rid of pointer arithmetic reading CDAT table Robert Richter
2023-11-17 20:25     ` Dave Jiang
2023-11-28 20:06     ` Ira Weiny
2023-12-07 21:18       ` Dan Williams
2023-12-08 22:52         ` Ira Weiny
2024-01-05 14:49       ` Robert Richter
2023-12-15  4:34     ` Dan Williams
2024-01-04  8:41       ` Robert Richter
2024-01-04 13:43       ` Robert Richter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZZa1-11632f6CckT@rric.localdomain \
    --to=rrichter@amd.com \
    --cc=alison.schofield@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=ira.weiny@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=nifan.cxl@gmail.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox