Re: [PATCH RFC] Add "uunit" unit testing framework for CXL code

[Jim Harris <jim.harris@samsung.com>]

On Thu, Jan 04, 2024 at 09:36:01AM -0800, Alison Schofield wrote:
> On Thu, Jan 04, 2024 at 04:44:57PM +0000, Jim Harris wrote:
> 
> Hi Jim,
> 
> Looks really useful, cutting to the part about the individual unit tests....
> 
> 
> > > > 4) Improve cxl_region tests to cover error conditions and add extensive
> > > >    comments explaining how the topology is being built. This overlaps with #3.
> > > 
> > > Some comments on the simple tests would help too just to get folks
> > > ramped about what's going on.
> > 
> > Ack. The comments are absolutely critical and I should have added them in the
> > v1. They'll be in the v2.
> 
> As you might imagine, the first thing I'd like to do with this is try
> to spin up a simple unit test that matches something I do with cxl_test,
> then grow from there.
> 
> Coming to this with cxl_test experience, it would be helpful if you
> can draw, comment on some parallels - even to the point of showing,
> here' what cxl/test: cxl-topology.sh (or similar) looks like in CUunit.
> 
> It would be helpful to separate into multiple patches showing what needed
> to be done to add a specific unit test. I'm assuming to add core_region_ut.c
> support was added elsewhere in cxl/uunit/*.  Separate patches would make
> that dependeny clear and help in mimicing the process of adding a new
> test.
> 
> I'll try it out on next posting!
> Thanks,
> Alison
 
Good idea Alison. I'll take a look at this before I send out the next rev.

-Jim