From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADDFB22A4FA for ; Tue, 8 Apr 2025 15:50:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744127435; cv=none; b=gCHMb163Rqm2R9WE8eQdWU4dN2I3cIUj6Gjn1m2nvVN2xYTZ30+8JRsAL3Xgof5WOqszoNANlhGJ6m2/hkUOQsE7emro4EFWzT0sz76QF+OTy6Om3QqMG3wlEojdE6ldSXXU7I7UWHN7wFsas1K7tIJYCMT3dQzm2Wg3xVaeb6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744127435; c=relaxed/simple; bh=2Km7NO1z0i+UzfqrusksoUfmO41Y6EOMznVE4fLGK4Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pgEXttclN9x87XEPqLA1DU5zgvNfaBd9Iv4Q/f/k6qkgmhH4ArBCXRwghRG0SKwuNwS/bF34Af9cEDSIcVW0+0nUSgHq+p5ngBSv1HaAWEPi1EnMl49WSfAU/ZQF6TBP528mhif5Ibi27vtvjo8dF219HDKkZt8RKnLyp5YDCNI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=oZZbk6qN; arc=none smtp.client-ip=209.85.219.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="oZZbk6qN" Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-6e8f43c1fa0so69230276d6.3 for ; Tue, 08 Apr 2025 08:50:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1744127432; x=1744732232; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qU1SHlplVkElW3I3mNfWTE7OMoO1FbxBpAaPPp1gBwM=; b=oZZbk6qNPfUP7Pg2ZrrdUqawcKn+uysEiIGLKO6gl+AdNZ7OhQjwrklWYkzts/niL8 OJaG+ngHnLcM1oCwqipAFjT9XKBNoj7H8idyiH5U8M2lSUMtQttWb+OIfyKuuC9DhUJZ 8AJ8OEarx5kDhax5TsuLpt7VKlo8po0piwLZq9KIOHruVd40R5//JSuoyQmkTb4BpMKB Grne9g1OjoTNozQv1CWB7af43qKIDZNIfSz5Qb99ghC1gb6NUETLSAn5IG8f94m5mqFD wI+eukyynaT3HDyUOetMGo6KNPA2oNtiHkr8EebmOzVaQs1dzB733Na86IFnGuCj3wB6 VUJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744127432; x=1744732232; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qU1SHlplVkElW3I3mNfWTE7OMoO1FbxBpAaPPp1gBwM=; b=ROKXHM8Sku8ZjX3ut1n5ZGdJnvwyosHUi7pHaBcGqE8/y+c+yeAutJ9FLDWq4B+r9F aC4Y6XuqWWHmsZUvK3eTFVbng1jBvi1q1m/7CNw/H+6Oh41RuPmVPsBkgiX3/G1Kdn80 TxFCOFKuymP1mXoO9ooBHS8l+JJxdzHPg4nvflwICLHBrCqfkZu0gSUJND4wuoGMb3a2 sD3rCVtTuDs785qPaUADXyYmMTycHUP4Hf/yUVC0Ve/0P7+lg/rRRFPSmUjvsk86kISJ T0xwEG5ff9kRMTmp6mAFRLz7Sw558Riw4rFI7X73GMgTyUZ1mFkyOMMmvrLEIQ57WpQ5 Qk9Q== X-Forwarded-Encrypted: i=1; AJvYcCXfn7o3ymWofBdlSCC5Y+IrrfgC0V3YRPVI7+Ot+7NpiGpUO4hVPoa5A3o620isnC2BmX+FZj5suv8=@vger.kernel.org X-Gm-Message-State: AOJu0YwMnVtxFSRESV2xQ03f5dlX3tXTyAFnQ1U4JiofDGGyWldxB75X A8y3kx9FXc2FYfgvaN9HYVjvnMx0lteUfeOXwQ+32WcxZ5qR5rKaSqiBQAQ76GE= X-Gm-Gg: ASbGncum/FKm0v6ynVvSVmSV1fjp+depY4qlgrTrvaZAkiQ9QDzVbGfOu+W78rTk7ku sUmgZ1BNa1PR3ODQj4OQTO1JYy941npHv/17OSlwoesw+9FXvf/Qtk97ECvXMD1s/rUN58FZeve x5wxRcL9dA9GNHX0ERApT1LgMSpfowu0imaMCc+kg1w88DbncMH12JRxa0pznjGkyYU1t7n8ZrO je2Ki9UIP9SH/dhXwj7PqVMNxGxT6Sd5sQW1A52Z7X3oDYfjQlrIAr8z8xeh6GAzYnKxV9hmtiQ 1kob6EyENz42W0S9GnlwKsjBs2S2E5TZoutYvWXKsmfTVUX7PGmerlSKiLPj0IUn1Pdma5Sp0aM xSoE/pYFHEGgivGxnEagpDhM5jIhnnteNyQhyPQ== X-Google-Smtp-Source: AGHT+IGskZXHYCovfrGHJeIACu7+JHRYe3pFg0wj44SOWFQkPILgKan7VkELyjK4NpSv9AnZi6Ydhg== X-Received: by 2002:a05:6214:5189:b0:6e8:fb92:dffa with SMTP id 6a1803df08f44-6f012e1adf0mr288494966d6.25.1744127432472; Tue, 08 Apr 2025 08:50:32 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6ef0f010c7esm75759036d6.44.2025.04.08.08.50.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 08:50:32 -0700 (PDT) Date: Tue, 8 Apr 2025 11:50:30 -0400 From: Gregory Price To: Robert Richter Cc: Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Jonathan Cameron , Dave Jiang , Davidlohr Bueso , linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, "Fabio M. De Francesco" , Terry Bowman Subject: Re: [PATCH v2 09/15] cxl/region: Use the endpoint's SPA range to create a region Message-ID: References: <20250218132356.1809075-1-rrichter@amd.com> <20250218132356.1809075-10-rrichter@amd.com> Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250218132356.1809075-10-rrichter@amd.com> On Tue, Feb 18, 2025 at 02:23:50PM +0100, Robert Richter wrote: > To create a region, SPA ranges must be used. With address translation > the endpoint's HPA range is not the same as the SPA range. Use the > previously calculated SPA range instead. > Same with patch 8, I think this probably should just be rolled in with patch 5. You can simplify the notes in patch 5 by saying: """ since cxled->spa_range is set to cxled->cxld.hpa_range at endpoint initialization, this patch is effectively a no-op for all systems that do not provide a translation callback. Change all refs to cxled->cxld.hpa_range to cxled->spa_range. """ This should also help simplify the patch series overall. I haven't gone through to check if there are any other missed hpa_range references yet (e.g. [1]) [1] https://lore.kernel.org/linux-cxl/20250218132356.1809075-1-rrichter@amd.com/T/#m26a8e4d8b1783dfb837553f184f7f174b61b7825 ~Gregory