From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACBBC63CB9 for ; Thu, 1 Feb 2024 17:30:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.100 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706808644; cv=fail; b=ge6AfzZWap0Tk1xmkHD955NADUJCvwfjIpt4asO5T9U1KcyeaDHRv+D3zYnbCAecKek1aoG6rjkRSJN63uj6Lkiod5t5pLEspVDfyAbQlmv2jXOUHWsrHEMAI1uBrTLaoJ1Yk5gCERojujzpzlaysjnlMgQoIMaqxiB7usY+jis= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706808644; c=relaxed/simple; bh=6Wdx0IJ0BNUkM6T1QU9nVDqwpwFdlJ3ScKVrGINw+X8=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=ZAxEL+pdedGPA+hDzk4Ivn0Z7cZcqveqk3PARCtUJbmWfCSNN67AuqRp+Kx6mlh8wLPqw3P0JKy6xzlCEuwOT0QYIMp7l/wbksULUKJWNu8F84LkRtwDTog+2mAqTZGC1coSJMFvdUKbntdoRQ90TpcvKcJuTPp0veQygLRJ4/c= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=memverge.com; spf=pass smtp.mailfrom=memverge.com; dkim=fail (1024-bit key) header.d=memverge.com header.i=@memverge.com header.b=YOGLtWPS reason="signature verification failed"; arc=fail smtp.client-ip=40.107.236.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=memverge.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=memverge.com Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=memverge.com header.i=@memverge.com header.b="YOGLtWPS" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mJa+B/B1iPsIpUhRvEJQQQoIswpZBu/tNNwmVjWCMGQn0/tomXCp7O9jYmmK20beb+HEamcjCem4hleHxNRCBGvYr39hAkBz4iHu2i8DSIC4KJSype1ryLs/uYdCrYjwLy9x3y81yLuMTRcRLW8y6t8AjTsrWK2C/t+P/upJRQxF1IDMCcBF29cErynQEneabp4Ps9chEttDjNUf1cF1NF2zcBk6XNZ7P4WqE2SQaDPPWtbpWSUWopPtBk0RA4nZm7Kp+8AMyjJ6Dr+nPujYs3xALykX9V/btHC+YC4W3OKEntkkewFgl/dEJ716+JiHek08pPCJMnGuHWzAwWRnSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6brdlZmgUd6r4kA/Bgzd5ZhGelTsoxnrOOI4EOn6um0=; b=lFQu/E+ErBKQoGfJRkdSCC8NzwPFUcsjww39bVtEBVH10s8xzGPrmlHf9ttp2N/4KivthjEqG9ZjK9TcyhOaWgRJwcAA5GiP/dCAyoSYuMSjljqFy4W3CFCdkkqzkBEhP64q8HxP4wTq7D1BajikIgSiBRxSCEY1fQx9HGDZ92xIv0oINhhBytA/UDUfSJZmSsqUEk+FigsFHIEf7gZOs2iDQ4MqMKLHM1qMoeHgFHwQWBMPmIZf1mEukbb6bKDr6MhpsnPPwUCDxLSEpQbKMmyDqwTdurUERpTXNq+0kT/Ers8FYU0RtxmRzorswd9i/BmpsLsEPcYIz0m86NXpYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=memverge.com; dmarc=pass action=none header.from=memverge.com; dkim=pass header.d=memverge.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=memverge.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6brdlZmgUd6r4kA/Bgzd5ZhGelTsoxnrOOI4EOn6um0=; b=YOGLtWPSAYGEUFapphe+50ZvaH40MpHFP194vPjIwxckkzDSiPq++wLwYtmKxClmjM01nPvxZBxsVvAwz8WAVsvcPnYbGELLkB7TEniBl5hChdx/4KBhToL15Z/Plc+613YterGloF6CTsJo5OGnBV0E0YdlCfXCnPW3wEwazu0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=memverge.com; Received: from SJ0PR17MB5512.namprd17.prod.outlook.com (2603:10b6:a03:394::19) by SJ0PR17MB4792.namprd17.prod.outlook.com (2603:10b6:a03:37d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.29; Thu, 1 Feb 2024 17:30:38 +0000 Received: from SJ0PR17MB5512.namprd17.prod.outlook.com ([fe80::7a04:dc86:2799:2f15]) by SJ0PR17MB5512.namprd17.prod.outlook.com ([fe80::7a04:dc86:2799:2f15%5]) with mapi id 15.20.7249.025; Thu, 1 Feb 2024 17:30:37 +0000 Date: Thu, 1 Feb 2024 12:29:43 -0500 From: Gregory Price To: Peter Maydell Cc: Alex =?iso-8859-1?Q?Benn=E9e?= , Jonathan Cameron , Sajjan Rao , Dimitrios Palyvos , linux-cxl@vger.kernel.org, qemu-devel@nongnu.org, richard.henderson@linaro.org Subject: Re: Crash with CXL + TCG on 8.2: Was Re: qemu cxl memory expander shows numa_node -1 Message-ID: References: <20240201130438.00001384@Huawei.com> <20240201140100.000016ce@huawei.com> <87msskkyce.fsf@draig.linaro.org> <20240201162150.000022cf@huawei.com> <87h6iskuad.fsf@draig.linaro.org> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: SJ0PR03CA0256.namprd03.prod.outlook.com (2603:10b6:a03:3a0::21) To SJ0PR17MB5512.namprd17.prod.outlook.com (2603:10b6:a03:394::19) Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR17MB5512:EE_|SJ0PR17MB4792:EE_ X-MS-Office365-Filtering-Correlation-Id: 2ec08e55-784c-496a-f80e-08dc234b8124 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GfsI9yQDmzmK+Q/nRyYWBqDuDo3VYTnkKbh0Fypk64j52rOeGuNrIupod6PRdk56CTBp9TJlpfyCqvj1ukvPTYOB6+uHlN/IRWUOuj0/WQ5261Y7fCi7IABPBjKQFdcZ9y3cvLA+tjBDOz0aoEYtxf9nuh38shxoKiznfQtkGMgI5h2OILCEHItFnVcL2eSWIf+G/4oVSANCUINyonJzeUgIDFNI7QodD7iF4wHuy9TKJDKHIhYccLvhrWMHCqTptQ89l4a5MQue3rQfMALNg0pcYNHunqbFQITQ+ajNC/Of+OWuiHHqSc5O4b4aA1xyaJNNrwt6wIC2rrXHVOlGI0OTRZ1pNKZGQ1hTtb3qoHkMeJG0S8+OKkL+hHS6i82yx3cd3zHuRaus0R4ex94BpYE8ANV+LZoCnA9TWrK1VDKHJcG5lPXnrcUzfEGp4dG5YVN2Wi0rtg/E+9MQJiPKsKTi2wSu9gzHqIpCq+TghJ64eMT2nuPoG+vdmb4UKAMroMU2sFXPaSPYAcKNi93eoD3/fw3/cknjZAAq08xxUmcPQwUU//u52LeLKBO0d1FCq8Dd63W5yCwUwT598wuAekf1CrNO1/Areg/GnToBssY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR17MB5512.namprd17.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(366004)(136003)(39850400004)(396003)(346002)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(66476007)(66556008)(66946007)(54906003)(316002)(6916009)(4326008)(8676002)(8936002)(6486002)(478600001)(86362001)(4744005)(2906002)(36756003)(41300700001)(5660300002)(44832011)(83380400001)(26005)(2616005)(38100700002)(6506007)(6512007)(6666004)(67856001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?y1jpJS85OxPUZdxvRpeNOgBxPxEmjs7gnCQM1ee6+SQFKSZyPBWTT/YL7J?= =?iso-8859-1?Q?GHmcEtcpgcBHaHSvpWCepnDrNnn3K/sOstvPrWy4lqyGGV+oP/LptBDu+Y?= =?iso-8859-1?Q?e65IAbvk1KwOH2fHwHQXMaSOiJeqVOhwbiu0w2QOlvHcYBkZz3uWH06ujr?= =?iso-8859-1?Q?YZJiqSIkaJkwX3lTgP7nM5R9gFkqbxYCbzG7ttG5YRGIyH0mBikh7dyCK2?= =?iso-8859-1?Q?/mJyP+jXl8jBos4QeZU83dCmJJ6oRGkEsM3bvroh+h54fUtvwoeAq3jE/s?= =?iso-8859-1?Q?lEgRzbLAaznXdywKTgnVCqAv2687VOsGMkQE1U/Bxm6XkdBj4Ex2kL4c85?= =?iso-8859-1?Q?n9Nkl2ObU6wjmeHYRpeEHHWpDkCDDjDNiNOVs8MMjq6YiTG86gOApp0wPs?= =?iso-8859-1?Q?H7xRkFHUTHb5u7R5Qko3dGVxJv7LgBRrwCbmNgtsjynDz6NUrtRXKtosEt?= =?iso-8859-1?Q?Owr3k5E5M5vXrsECK1pkhYOSeyy6EKQP1C6k7GxaLNxLOPVBrIuS8oST/a?= =?iso-8859-1?Q?c+VeGVSbTi/v3v1aTTmX8jpEgx4po9GpxQvnKEr6L9SRoX4U2I3CqHu3kj?= =?iso-8859-1?Q?e+hYRrMUmjvo959vHjY21Uwjq58e5FcilD8YhLy2w31jV/0eDLFsGMJ476?= =?iso-8859-1?Q?xZ5P/XS9btzmwot7kJbUiA5laGdHOTlHiQVcbVHxFX+tT2PDK5X0r8ATtl?= =?iso-8859-1?Q?dD10xAkhIjWW3MjF94PuWoeN4V0iAKAGAzBQUqSBQWqBqQpEyoE0ohwDR5?= =?iso-8859-1?Q?EphlbwBCU1XAjx1G19bBVh7T73rW6Fqb97KHOTSkQVle9fsbx8Hew5sHtX?= =?iso-8859-1?Q?bq6Vii67pfqvcvGAuGHY9mI+4XbXqjl3z5oUkHJp9jdfnD7fEzR2JhiTg6?= =?iso-8859-1?Q?kSkOXYcngGUS8cxYBMZATCWXfb3QsiFHV1wL5m7Wb7/ErketyjdS/V7CGH?= =?iso-8859-1?Q?N/JvO+jcJz98N8Nn6kj6v0w5tLqya51PJMZwRjbaSPtighpKs18b/jEE7Z?= =?iso-8859-1?Q?gMZY39U0E1z45g5J4GyuFxzg9kdJiwkiHB0+QPwvWsZAerCvylp0T8K7a8?= =?iso-8859-1?Q?egFH6DlKSwwxinyJ+MNoe5RqyGSuFLF6ctcKuPv2HPHukAtsNgDi6RNrip?= =?iso-8859-1?Q?J8MaOx0Xwp3yLeem7ggQTxecmFs6SVf1EWesQfgX20XMGHs86qp7cCjkMz?= =?iso-8859-1?Q?tbSCU//G7BBGVA3EQ6MtYPKFI91wGSa+ZWEbSDl7IQKEcIO+e4TVC0RWkI?= =?iso-8859-1?Q?EgY+KOkuPe1QqtxYwB3HQRX5YcJyqy9tTp00OJgwEmB1J9Mlo87+nLuRMs?= =?iso-8859-1?Q?YQbRcSrQZShBj3IVQZnkg8Pm4vQPmuU5d7EaWonuHcX/AxY1E9UZ8/lSWp?= =?iso-8859-1?Q?MHJY4YYPFkPQKyJ33FUSlk5Rkx3oT3wBFpDpkz9nKVx6550JxXgeQxyfPP?= =?iso-8859-1?Q?kkrhjnivD04x8GKXdqJ6wQp8/xnx8xHLt+8UgtrsdEfAdHFj/VmxPvCEvC?= =?iso-8859-1?Q?B9BTxtBW5FWF9OKi/vJMR9vBlHvt6/CS8bZQNIniwdYgNOEWukYbfGHPlc?= =?iso-8859-1?Q?dxrWnj9a14A3NeE+Kp+rnjPdezpjFuZF//3K/DnvlUOJ819sdU5B3iO0dj?= =?iso-8859-1?Q?q6KMbCVYHiaM4USHcEz36VuZOkfJObNWinyIQ1DSLKqGrPcb1MDvX1Zw?= =?iso-8859-1?Q?=3D=3D?= X-OriginatorOrg: memverge.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ec08e55-784c-496a-f80e-08dc234b8124 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR17MB5512.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 17:30:37.6908 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vx1bQ7nP5gJOZS5s6iA2pOcp6pUmEp9u6PCnpPXTdJLslr2Fy/Jl6PdG/PMqYRYNaKfGjc1cqSi+QziGo6SL67LPlj7pb4v0uZMAOzc55gA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR17MB4792 On Thu, Feb 01, 2024 at 05:07:31PM +0000, Peter Maydell wrote: > On Thu, 1 Feb 2024 at 17:04, Gregory Price wrote: > > > > On Thu, Feb 01, 2024 at 04:45:30PM +0000, Alex Bennée wrote: > > > > No thats different - we are actually writing to the MMIO region here. > > > But the fact we hit cpu_abort because we can't find the TB we are > > > executing is a little problematic. > > > > > > Does ra properly point to the code buffer here? > > > > > > > What if the code block is ALSO in CXL (MMIO)? :D > > In that case the TB is supposed to be a single insn, > so the insn will by definition be the last one in its > TB, and IO should be OK for it -- so can_do_io ought > to be true and we shouldn't get into the io_recompile. > > -- PMM We saw a bug early on in CXL emulation with instructions hosted on CXL that split a page boundary (e.g. 0xEB|0xFE).. I'm wondering about a code block that splits a page boundary and whether there's a similar corner case. ~Gregory