Re: [PATCH v2] cxl/acpi: Cleanup __cxl_parse_cfmws()

[Alison Schofield <alison.schofield@intel.com>]

On Wed, Feb 28, 2024 at 12:30:56PM -0800, Dan Williams wrote:
> As a follow on to the recent rework of __cxl_parse_cfmws() to always
> return errors [1], use cleanup.h helpers to remove goto and other cleanups
> now that logging is moved to the cxl_parse_cfmws() wrapper.

one question about helper below...


>
snip

> +static struct resource *alloc_cxl_resource(resource_size_t base,
> +					   resource_size_t n, const char *fmt,
> +					   ...)
> +{
> +	va_list ap;
> +
> +	struct resource *res __free(kfree) = kzalloc(sizeof(*res), GFP_KERNEL);
> +	if (!res)
> +		return NULL;
> +
> +	res->start = base;
> +	res->end = base + n - 1;
> +	res->flags = IORESOURCE_MEM;
> +
> +	va_start(ap, fmt);
> +	res->name = kvasprintf(GFP_KERNEL, fmt, ap);
> +	va_end(ap);

Why is alloc_cxl_resource() defined w variable params and using
kvasprintf(), rather than tailored to the one caller and used
kasprintf()?

Perhaps you have bigger plans for this helper?

Other than that,

Reviewed-by: Alison Schofield <alison.schofield@gmail.com>

> +

snip