Re: [PATCH 2/2] cxl/test: Replace ENXIO with EBUSY for inject poison limit reached

[Alison Schofield <alison.schofield@intel.com>]

On Fri, Jul 05, 2024 at 06:15:24AM +0000, Xingtao Yao (Fujitsu) wrote:
> > -----Original Message-----
> > From: alison.schofield@intel.com <alison.schofield@intel.com>

snip

> > 
> > -static bool mock_poison_add(struct cxl_dev_state *cxlds, u64 dpa)
> > +static int mock_poison_add(struct cxl_dev_state *cxlds, u64 dpa)
> >  {
> > +	/* Return EBUSY to match the CXL driver handling */
> >  	if (mock_poison_dev_max_injected(cxlds)) {
> >  		dev_dbg(cxlds->dev,
> >  			"Device poison injection limit has been reached: %d\n",
> >  			MOCK_INJECT_DEV_MAX);
> There is a tiny issue here, we'd better replace MOCK_INJECT_DEV_MAX with 
> poison_inject_dev_max, as this value can be configured through 
> /sys/bus/platform/drivers/cxl_mock_mem/poison_inject_max
> 
> like:
> # echo 128 > /sys/bus/platform/drivers/cxl_mock_mem/poison_inject_max
> 
> after injecting 129 poisons, the “Device or resource busy” occurred, but the debug message
> still output:
> [ 7664.280587] cxl_mock_mem cxl_mem.0: Device poison injection limit has been reached: 8
> [ 7664.280591] cxl_mock_mem cxl_mem.0: opcode: 0x4301 sz_in: 8 sz_out: 0 rc: -16
> 
> 
> Tested-by: Xingtao Yao <yaoxt.fnst@fujitsu.com>
> 

Thanks for testing and thanks for finding this issue.

I've folded this fixup into v2 of this patch. Since it's cxl-test, and
it's a dev_dbg() message, and it's directly adjacent to what this patch
touches, I expect that will be OK. (as opposed to a seperate fixup)

--Alison