From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D76D1494C8 for ; Mon, 8 Jul 2024 20:54:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720472078; cv=none; b=MjsT9y2+jXGhqtUHVSkNq+vzcivmc0BU8UNpRIRD2a076pPwB20th5EgXHIvmVCSbNORW/vCbywQhDYGKtlz2WvXNCkE9WqmLbQrdj8auzEs/615ou6oMNeEa/0kA0OmVkhR2HpOFpcQPSM6G3HVqohMwXkOBhA8tLbtX9AslUo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720472078; c=relaxed/simple; bh=pzEQCKW06tzwbc4tbAwQvkRlr1ZNwcWvPABCq9MAs/I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iIsVyL65PXxo6+Hkz5+EjcNHLfTHbUV3zhEscPkhly0qqTzNMsZRoF1X14ikRuqzs01RTQGpD69Z0LelW1xQB3gMf0oWiNdrd2wITRRkyDPnmIGCoHwtFkC47e7uOmER+RY7/wzl104spfcJlYE1tY+cm8+90Vc0BJ9y5tjEBDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=j9opYNSo; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="j9opYNSo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720472076; x=1752008076; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=pzEQCKW06tzwbc4tbAwQvkRlr1ZNwcWvPABCq9MAs/I=; b=j9opYNSove3K+wWp37r50qadCILbw/GU1cDq0W6lXPMrNC4HV5f4Q/aG 9eKMYrdd60yMgawc6w0MANJ4FJiHGfmYIk3sSqUzZzdMPO/Kd+A4xGXQp 0Ad9O1bsPmpMglNYUFthSwrFPKFZaqFl3B1wMTxQv00kYlhBTW9H8Qi5h THbb76EqtwBhDkXZUooudZglnTOQcDriH/TNTtKdmK4JC07B5NqPbV/2W h/HR5DCQI2nTbmLZlRitBAqa8pt8ymmMQbgs8mdk2G19BouIvQ+H5JZdp p5kPT4EV1YAtvjXhPQF2a2yYWMwVRtqIxm61yvF82IpY0aYKWdA0YOsdS Q==; X-CSE-ConnectionGUID: ZVnAGgFWTwKgEPls1bPJ+g== X-CSE-MsgGUID: O4JjPetTRC2+JxZZcK6slA== X-IronPort-AV: E=McAfee;i="6700,10204,11127"; a="21462788" X-IronPort-AV: E=Sophos;i="6.09,193,1716274800"; d="scan'208";a="21462788" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2024 13:54:36 -0700 X-CSE-ConnectionGUID: dYI7AkokRlmg5R3ynL5u3g== X-CSE-MsgGUID: vJkMa5g9SqKxmX8ulWeWLw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,193,1716274800"; d="scan'208";a="48349454" Received: from aschofie-mobl2.amr.corp.intel.com (HELO aschofie-mobl2) ([10.209.105.241]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2024 13:54:26 -0700 Date: Mon, 8 Jul 2024 13:54:24 -0700 From: Alison Schofield To: "Xingtao Yao (Fujitsu)" Cc: "nvdimm@lists.linux.dev" , "linux-cxl@vger.kernel.org" , Dave Jiang Subject: Re: [ndctl PATCH v13 6/8] cxl/list: collect and parse media_error records Message-ID: References: Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jul 08, 2024 at 02:07:41AM +0000, Xingtao Yao (Fujitsu) wrote: > > +/* CXL Spec 3.1 Table 8-140 Media Error Record */ > > +#define CXL_POISON_SOURCE_MAX 7 > > +static const char * const poison_source[] = { "Unknown", "External", "Internal", > > + "Injected", "Reserved", "Reserved", > > + "Reserved", "Vendor" }; > it might be better to use "Vendor Specific" instead of "Vendor". I see that "Vendor Specific" would be an exact match with the spec, so yes, I'll change that. Thanks for pointing out. --Alison > > Reviewed-by: Xingtao Yao