From: Alison Schofield <alison.schofield@intel.com>
To: Yuesong Li <liyuesong@vivo.com>
Cc: dave@stgolabs.net, jonathan.cameron@huawei.com,
dave.jiang@intel.com, vishal.l.verma@intel.com,
ira.weiny@intel.com, dan.j.williams@intel.com, rrichter@amd.com,
terry.bowman@amd.com, Benjamin.Cheatham@amd.com,
linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
opensource.kernel@vivo.com
Subject: Re: [PATCH v1] cxl/port: Convert to use ERR_CAST()
Date: Thu, 29 Aug 2024 14:45:29 -0700 [thread overview]
Message-ID: <ZtDr-by3dPFdMuoP@aschofie-mobl2.lan> (raw)
In-Reply-To: <20240829125235.3266865-1-liyuesong@vivo.com>
On Thu, Aug 29, 2024 at 08:52:35PM +0800, Yuesong Li wrote:
> Use ERR_CAST() as it is designed for casting an error pointer to
> another type.
>
> This macro utilizes the __force and __must_check modifiers, which instruct
> the compiler to verify for errors at the locations where it is employed.
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
>
> Signed-off-by: Yuesong Li <liyuesong@vivo.com>
> ---
> drivers/cxl/core/port.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
snip
>
prev parent reply other threads:[~2024-08-29 21:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 12:52 [PATCH v1] cxl/port: Convert to use ERR_CAST() Yuesong Li
2024-08-29 14:43 ` Jonathan Cameron
2024-08-29 21:45 ` Alison Schofield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtDr-by3dPFdMuoP@aschofie-mobl2.lan \
--to=alison.schofield@intel.com \
--cc=Benjamin.Cheatham@amd.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liyuesong@vivo.com \
--cc=opensource.kernel@vivo.com \
--cc=rrichter@amd.com \
--cc=terry.bowman@amd.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox