From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12C361BFE02 for ; Tue, 1 Oct 2024 13:44:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727790243; cv=none; b=Sjh1WgbqomTGY7DcHEXsaK3UnKDJ3wwBfdX1IgskTGgxSnrIFzemzezxa+YJZD0jTxZhe41fg5Rxj0Fu7gUx8rLHtlQ3knDowJ+REfhqfB/fmaAI0Cdx7Tl/Lcq5nyun3CaGllitvPEalXkIJ8jFhdzH+/38++cQnOD8EALZH7k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727790243; c=relaxed/simple; bh=xGx6noygeMgO8AaQLqGM7+q8fh5vc5kUtmlJwZCD2eo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZxnyMJi/hYprFK0XgzpwY4FJoih+l0GWNUubPi+R9Ov+niRHe3AtvQDVzWL3SYJcQnDMtbB1L68mER722AaTjECRz1SP1z58VIk5lSjHgAtl2felTAe/CfNjToWPa+w2W78o1mUmYqKGBiw0B2A4fratKY3E8p15tsCAcV7f0Sc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=I4E2get9; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="I4E2get9" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-7a99e4417c3so471453985a.1 for ; Tue, 01 Oct 2024 06:44:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1727790240; x=1728395040; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JYTJ0CUqrH1SHJfivVlEjJG53DkWzerfR4yWluFNYZE=; b=I4E2get90BZHel+50j7iOBLPgnrEt9wwdFzOeHPAtlCjZJuZJQqOvcOpdYwIPRXfh4 wnzZmyzy550VYrVv71I/V1OKm26KFIdZAcIibNJY/zf357OHPTLa9LGd1joN+bHYxwT4 wxCqfD/8pI4oeJU4tnSJ2IT3UcanVMArfHOLCzXo8E22K5/GjMWu230n8OT7Umr17V+S ZS+PQqD5aoJ5Umx51BIqzS/5pbEsfrNebNqXHgsfm8p1iwQGmFevzyE1oVjP6kcAMLuB vNebyOM2X4vQp97N4CHd9uv4AoQc82XxZ27nMFr00sCcpDU/Hf7QFLIpbX7mbsn0ZcFL Hwbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727790240; x=1728395040; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JYTJ0CUqrH1SHJfivVlEjJG53DkWzerfR4yWluFNYZE=; b=MLaWQst5vlXVUlpe+vcLuDYQBjzUvSRtRn5ek0cjd6h+kNdiaIvks30r/oO5rXPAls 7xo7fit1SQ5fDJ0HDUf5aLkf4/blWBSP6L+ToAHgsr55XSBs40LFg55aRJMhn4OcPr7b wrNfb7yOxjBo/PN77TvdZztV/XFLr6p9MdxMzi6hxu6dVtiWuH/xDW+/dPrWkkrCRtaN fpRtTMuiF2UX/YZvo8GjBbWH1erC3JA2rY1SmtizeBVk3r0FCOCLAJqiKTgEkgQEYr+P q+W1HBf0/5K9yBHQ8qUetei7jDvB6yHF2b5SSlPJTHtcNQ0Ht3nOubGYukb39PHj8F5L ODGA== X-Forwarded-Encrypted: i=1; AJvYcCXH3v4SY07vrn14UEpvbJ8DWhVbLZu165F72JF13cb9278K2XZm3nVcvhPZYyode7iBYNsWsGXj14A=@vger.kernel.org X-Gm-Message-State: AOJu0YzCKjDk8xv9wxb/GD+sMgHNNJQQwjpAi/h13yBkHNG+akevP5e4 F6h+gwgL9OQPsh/xMD9ru2WQKJ+XOTPyai0lsbfPpajVoyTLGlwlj1520dANWVY= X-Google-Smtp-Source: AGHT+IF5VUNcvnmPtnD8VPaddLA8g45OQ216uprpipGG1nA4txFOuXegaZTFCcl2msleBSBHLXCt6Q== X-Received: by 2002:a05:6214:5342:b0:6cb:3340:ac36 with SMTP id 6a1803df08f44-6cb3b65feacmr169019196d6.52.1727790239921; Tue, 01 Oct 2024 06:43:59 -0700 (PDT) Received: from PC2K9PVX.TheFacebook.com (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cb3b6800a9sm49778366d6.116.2024.10.01.06.43.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2024 06:43:59 -0700 (PDT) Date: Tue, 1 Oct 2024 09:43:30 -0400 From: Gregory Price To: Huang Ying Cc: Dan Williams , Dave Jiang , linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron , Davidlohr Bueso , Alison Schofield , Vishal Verma , Ira Weiny , Alejandro Lucero Subject: Re: [RFC 1/5] cxl: Rename ACPI_CEDT_CFMWS_RESTRICT_TYPE2/TYPE3 Message-ID: References: <20240925024647.46735-1-ying.huang@intel.com> <20240925024647.46735-2-ying.huang@intel.com> Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240925024647.46735-2-ying.huang@intel.com> On Wed, Sep 25, 2024 at 10:46:43AM +0800, Huang Ying wrote: > According to the description of the "Window Restrictions" field of > "CFMWS Structure" in the CXL spec v3.1 section 9.18.1.3: CXL Fixed > Memory Window Structure (CFMWS), the bit 0 of "Window Restrictions" is > formerly known as "CXL Type 2 Memory" and renamed to "Device > Coherent", while the bit 1 is formerly known as "CXL Type 3 Memory" > and renamed to "Host-only Coherent". Because type 3 memory can only > be host-only coherent before, while it can be host-only coherent or > device coherent with "Back-Invalidate" now. > > To avoid confusing about type 3 memory and host-only coherent in Linux > kernel, we rename corresponding bit definition from > ACPI_CEDT_CFMWS_RESTRICT_TYPE2/TYPE3 to > ACPI_CEDT_CFMWS_RESTRICT_DEVCOH/HOSTONLYCOH. This makes the kernel > code consistent with the spec too. > > Also rename the corresponding cxl_decoder flags > CXL_DECODER_F_TYPE2/TYPE3 to CXL_DECODER_F_DEVCOH/HOSTONLYCOH. > > No functionality change is expected, because we just rename the flags > constant definition. > > Signed-off-by: "Huang, Ying" > Suggested-by: Jonathan Cameron > Cc: Dan Williams > Cc: Davidlohr Bueso > Cc: Jonathan Cameron > Cc: Dave Jiang > Cc: Alison Schofield > Cc: Vishal Verma > Cc: Ira Weiny > Cc: Alejandro Lucero > --- > drivers/cxl/acpi.c | 8 ++++---- > drivers/cxl/core/port.c | 8 ++++---- > drivers/cxl/cxl.h | 14 +++++++------- > include/acpi/actbl1.h | 10 +++++----- > tools/testing/cxl/test/cxl.c | 18 +++++++++--------- > 5 files changed, 29 insertions(+), 29 deletions(-) > Reviewed-by: Gregory Price