From: Alison Schofield <alison.schofield@intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: <linux-cxl@vger.kernel.org>, <dave@stgolabs.net>,
<jonathan.cameron@huawei.com>, <vishal.l.verma@intel.com>,
<ira.weiny@intel.com>, <dan.j.williams@intel.com>
Subject: Re: [PATCH] cxl/region: Add decoder check to check_commit_order()
Date: Wed, 30 Apr 2025 17:46:46 -0700 [thread overview]
Message-ID: <aBLEdh-X_x-3dSko@aschofie-mobl2.lan> (raw)
In-Reply-To: <20250430213653.1904302-1-dave.jiang@intel.com>
On Wed, Apr 30, 2025 at 02:36:53PM -0700, Dave Jiang wrote:
> check_commit_order() attempts to convert a device to a decoder without
> making sure the device is a decoder. So far this has been working due
> to pure luck. Issue discovered while doing deferred dport probing when
> child ports are now in the midst of decoders due to ordering change
> of child port additions. Add a check before attempting to do decoder
> conversion.
>
> Fixes: 105b6235ad0f ("cxl/port: Prevent out-of-order decoder allocation")
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Update the commit message to mention and paste in the ensuing NULL ptr
dereference so other unlucky folks can find this.
with that -
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
next prev parent reply other threads:[~2025-05-01 0:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 21:36 [PATCH] cxl/region: Add decoder check to check_commit_order() Dave Jiang
2025-05-01 0:46 ` Alison Schofield [this message]
2025-05-01 2:51 ` Li Ming
2025-05-01 5:29 ` dan.j.williams
2025-05-01 15:09 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBLEdh-X_x-3dSko@aschofie-mobl2.lan \
--to=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox