From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E6652609EE for ; Thu, 15 May 2025 18:25:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.12 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747333516; cv=fail; b=OuIATjbUC8NLrkBS1hWjcXAZ8rWdXInPuLhoAF3S8FGdE7Wf48H5e1UIu/Jmcuk2Zaojr3ZnUfGpf5VBYMPTyanadL+KrkMQqm70f/eTh015yvmg0i1ANKM9au3HIsX1QshS43GHxbUPxLEtjj9/PSKHZugl9cKWVEev0B+xMoI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747333516; c=relaxed/simple; bh=sLsdZ9/usonkRSc9sfw4OzGJTBvnGmPg0AhD94ihfJo=; h=Date:From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=ba9l9dWbcyvsEVAOrc91YWx/XFcR9lBEwOIG7hZMo/XI6OR3vSPCYL4ykE/wp8HjWEWEPqpirKy9UC10/wP62xCvq2By+qdjGzz0S4VnGnZzYLNmun9B/4U1vTxqONLatxU4VNsbOvPTHBQ2e6Htwj9e57tfPnYxs/TmYt0h8A8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DtVs73/u; arc=fail smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DtVs73/u" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747333514; x=1778869514; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=sLsdZ9/usonkRSc9sfw4OzGJTBvnGmPg0AhD94ihfJo=; b=DtVs73/uk4HGAMshzzGPkElrf8oacusDn2dDVBmtYWTyyCel/YO75dS4 5inee3jA1wlz3diX54cHwIYgRqFi+IUxpoPFGVx31Bpcvar1l1khujGVl LpUtT49Y5OIhG4RuskPfxdY7rXXjh5Ff2Q5smkkR1bcqZoAaz6vM/6Bkm LlGy+OsGpJ5W0kqoO3JRaEUsuMZ3FqtW+rTvevMDOGsEISAfEwXQaF/lr OePFtNlqXaMTCCIqd81Ogu6YHoHjYc9pYcmeLuNVRu91vbJiittxKmDai SGwLczoVEC+hzUssmd7OSGLkzZICeCcI4ZXltMwWytjwX4o0RcEnFlrQ6 w==; X-CSE-ConnectionGUID: 3Ie595kSQySdqOnYr5wvFA== X-CSE-MsgGUID: IPVDEbSpRauVLnQN9f5eqA== X-IronPort-AV: E=McAfee;i="6700,10204,11434"; a="60685661" X-IronPort-AV: E=Sophos;i="6.15,291,1739865600"; d="scan'208";a="60685661" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2025 11:24:56 -0700 X-CSE-ConnectionGUID: 2HwWps1kQhWtdDMUigg3lA== X-CSE-MsgGUID: kGRvtpTnSFOqJ7QXXTm+Cw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,291,1739865600"; d="scan'208";a="139452152" Received: from orsmsx903.amr.corp.intel.com ([10.22.229.25]) by fmviesa009.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2025 11:24:55 -0700 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 15 May 2025 11:24:55 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Thu, 15 May 2025 11:24:55 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Thu, 15 May 2025 11:24:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jFqnm1N4uFP5qhLLVIgnXG7+rhw2ffDrNVzVOb0o/nEJ7uMCSZr8QtHKHrjDeF/OQVH7m6wwZM/4zJ3hqaUdPAjZbKvR4IYj6dFOosMx7cocErDAshFmbUrrmgNKZ9qTSqinzQufX1JDZ2GkR7jkm5nJIOG03zGlZGV1nqF1C4+3MdeQSlOeEBwR0zn7LsSV+0yuY0VvbtjEgqWY6OAdF6/2cZ3HOYc/Ov4YlrssmsH2tZW7qit9LGDjhk1zt5KjYSOaAYn7HsrDyJPPeYO30g5IQ5YDQD79n3eGwEd4Gen/AlnDE9JJdp6brpT1i+zQDSSz7hYuKUwWQlXgqZ5/nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZsXrHvMKrhsUvglNJ5FzBu+sue88zU1OgUJ/raB7+l8=; b=SEDx61f2p9gX9+SWC2aQbG2uVNGB8rMq4zmDF3eqySCs7VyL+f3NlCCFCVcJGVIHDkZjxrrYCv9UAkLLTLAbOKvP5bDSOI0aCJvhK1g6J2Nvne6FOW/qMawfyTpRo1RHFabZrSQkpRrPpGxFmG1XZJnv8Y1AmYQkEtYV/o1XydMet7JVvqtrDuR32F1iY9WIIVb8trF9JUkFl3/D8Zed2e1Djwwin8HgVLbTZd4WUXhdMWqsoI3JBc36/UQQstQOF64SmF9WbaLC6+1cl9dLwWRS0fQWyyhDsT1oHb6rJQezDAF3n2fnZ3brkV6RXoHXvGTnkos7QM+RtXKYL4/c9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SA1PR11MB8794.namprd11.prod.outlook.com (2603:10b6:806:46a::5) by DS4PPFEDAA4523C.namprd11.prod.outlook.com (2603:10b6:f:fc02::5f) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.31; Thu, 15 May 2025 18:24:39 +0000 Received: from SA1PR11MB8794.namprd11.prod.outlook.com ([fe80::a3d4:9d67:2f5d:6720]) by SA1PR11MB8794.namprd11.prod.outlook.com ([fe80::a3d4:9d67:2f5d:6720%5]) with mapi id 15.20.8722.027; Thu, 15 May 2025 18:24:39 +0000 Date: Thu, 15 May 2025 11:24:35 -0700 From: Alison Schofield To: Dave Jiang CC: , , Dan Williams Subject: Re: [NDCTL PATCH v6 4/4] cxl/test: Add test for cxl features device Message-ID: References: <20250509164006.687873-1-dave.jiang@intel.com> <20250509164006.687873-5-dave.jiang@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250509164006.687873-5-dave.jiang@intel.com> X-ClientProxiedBy: SJ0PR03CA0334.namprd03.prod.outlook.com (2603:10b6:a03:39c::9) To SA1PR11MB8794.namprd11.prod.outlook.com (2603:10b6:806:46a::5) Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA1PR11MB8794:EE_|DS4PPFEDAA4523C:EE_ X-MS-Office365-Filtering-Correlation-Id: bfc2e2fb-5960-4645-315c-08dd93ddc0be X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?+biJbEzbnGPdXmzeZL+pHqofG//Q3mGIP/lVvfaXiWve2uQEnGc8wIARMraO?= =?us-ascii?Q?1KF2aFeGUKVWPMfO7+CeKAO/ex8LwoU7vMEvhceuYwT7H2e9IOG6YDc3gNia?= =?us-ascii?Q?0D9zhAOxlAlHSlyc1UwaDu3a2XHefa2JXBuJVfPv+8yJnAIiqCFWVJD3k+5f?= =?us-ascii?Q?eoGDB+xReR+b69pn7ofY6fNNN9fvztg4ATE3c/iPu2EmbpIxiHyjDPMR7h89?= =?us-ascii?Q?+qqbyBsoqdwMD5zdtiR8Xqn0ys9Ijj/J34FR4cmZmxJbBEtoiTRvvXLkNO3U?= =?us-ascii?Q?nSW0e8bWJg8v8EmPe0hhpk2NnoOhS/cMUYHx/n+zmmbA4O+uLiKSQA06kZiF?= =?us-ascii?Q?OkVgoFi9eHX5rI/XVlIlMajYwxs2kF28wGJ24/5KkYKi5XQukm6Ymhx9E6Ic?= =?us-ascii?Q?nbVwVc2FRmSchZX2bGKBPRT9iz6z0DEuyJzlP943bvNxidSY30XpJBj2dIVW?= =?us-ascii?Q?FPNIYgF8XwjTrSj8jsO1j6X46R20Vh9lZSqUp2GPKrV90BVikCYFLFq475rS?= =?us-ascii?Q?ae52VRywloujWR4xfxS/Nqfd4SfL+wrN5bv5tYzkUijCrka92K11SClTQa7G?= =?us-ascii?Q?IO6XAk6pvKInePq4tcpb9fyqBQB5KvURqNjMm8vZldlvbN2jI2oFC3sdnuPn?= =?us-ascii?Q?Gx4lQBnanj2hYk64akmdnryxVZz6gAdUc+xfOJKc0KzXe6YBjzfxP9tucnJJ?= =?us-ascii?Q?X/D7SrvFDYmPpzHravapc808l1ERCWhie9/+TEav73EwwYI0qJInW6OVrlsD?= =?us-ascii?Q?cRCBA7Swe0cS2+7Vk3aXt7ComRGkaaszS+JxCLNI9B5478AkNlGS8q0wJJzt?= =?us-ascii?Q?f/W15IxZIsQWrOrunqUF1Y4iS87cIfYBqVbmxy3y5bWHtquxrlW1Rnu2xbC+?= =?us-ascii?Q?Q0HGJY3LnnaPok+iD5AsXK81XOez4dfg32lcKNV9W8T5J1IZc2YEcA05yzT/?= =?us-ascii?Q?9rRBG4f61TcRGjQ7N5qkbH6qzV6FX4DyDsHQf56hiesLMTkQzG69R6085De8?= =?us-ascii?Q?dcR8rs2+KtcHe+Ddf7sAI6Vxc+OXjNniArco8zqthK1Ysyot+2NumfflCWju?= =?us-ascii?Q?e7M7hozFbTaLffuB3yTjiFsrplR0NFTLb1dMSt+dn50JAfqJB7e17Yh0MTxp?= =?us-ascii?Q?9CWLIxBgRe2wLiuRhTurV70sefCk4erHA2oNWQr6/2N10qcvelcUtu4chv4b?= =?us-ascii?Q?FBgsgP3wW5OL3dxYJ/b029Q1c2BkG4taeEf/t7NWYCkE07m4kkh7sjKK6cdb?= =?us-ascii?Q?JJ3g2ktvHnufCJmrviCG4E1aqm4kkZV/KHWpG6LTtPpPctIJ1wmRJI26u3Sb?= =?us-ascii?Q?pQREIpnH0K8W5Ptc8W+qav1610qKQeRI+ja7wIhU1qAURypT/6Ax1YHQRa2D?= =?us-ascii?Q?AtU3tgmWU0256tBJJyPuXBPbf1FiABK24IYaTmCizcHyJ4F7Edwt0U45QabK?= =?us-ascii?Q?mef2JQraHrs=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB8794.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AkpfhR/anvLSjrHIc5pcJCqL+Jd4mQKYKPtcphGr/YU5b2TPRoNc2iIFI4lN?= =?us-ascii?Q?W3pNP42NLIU4FpkKPiHw2gMuarvSSfQAeszLc6dZ1S4/y+kRyIdWOCj6aI8r?= =?us-ascii?Q?nCBMyafJEiEOq3C+JA+2738GNKBh9LTCQbxIiGEw1n7yGwRG4PbxgmRuzCq6?= =?us-ascii?Q?VWFfN2zjwjOyZBlwW4jtCyazVv3eoUll6nP55jzXAgxdaQBbLqw9lqbnjH8h?= =?us-ascii?Q?2e/5SCzwYVgbP2fXQkFXwN+CVMkK/6clWtwf5znWRp9VYScQSMS6JN/9IygK?= =?us-ascii?Q?660sNayVtxgN4WQj9TLFAE8Edk72j1jjEuf5TFtZg8aLHdGV5hvwlo4ZvxqU?= =?us-ascii?Q?7nwEQGnTF51P57tJXPG1Ge/QeQIXtFy4Ayb0bRMi88/ITM6vy/zt7kb2CPFP?= =?us-ascii?Q?Nrh4Bo/c9O3o0eHF6BP+qfo9ee4YR0BQwM8dWzYqs9vt5vMV26fh1Ihz+O/m?= =?us-ascii?Q?eHJ3bqFPOOijVUSEAwE4Cj8hrHclyjc8sOATHGG+zJteiI8nN3cvEI0io3IS?= =?us-ascii?Q?cSBIzrVupjK49k90Ir5YenCcWKR62Bk2azk+mMSlD0cmTrwEn+WJYlFMdKef?= =?us-ascii?Q?ElRZDy6E39vGq8t/2uZLMErotzzKIWGYBp5NJv4B6M5Fq2NuwQywc/XVaL7v?= =?us-ascii?Q?bg9wo+SyKJq8I4jGgpYpMgRe63JTiuKZSB+iyitGA/6KpzT9KncU1Tv0tnvx?= =?us-ascii?Q?xdomLiI2Vz2XLUPwYdXHl4ZqMM7l6rFvf0zsWb1XUCzr2Lv+pZjrr0JTWc24?= =?us-ascii?Q?3viOSW97jQ5bOPE9gVF4kepTtzaOlO8TCIZ0ML8luQeapqLQKYv2uzsXE/mk?= =?us-ascii?Q?gBHg2w8Ffu23LhNNTkMYHs58PiCrKeDqRbiSfqYip1A823iR+OPhWB95qG3S?= =?us-ascii?Q?KFIYqFpDJUOHA1dUPkkgvhW8pMAep3+s4QqkA+gRITBhLOYSyVXbNd/vfyNo?= =?us-ascii?Q?yDWsX5JXy/O1V9v6l1QUZDM0Vr7ioaRHs2g8OsntnwIqdYxrT7/YDQsfkCc2?= =?us-ascii?Q?mwv6ZmK+SA9ydmFC2EOn3QGRWFeCVEvA1j67AxfkFa3KhLLifui/O/ntKwOX?= =?us-ascii?Q?8cbCzCXSBOjYCBOttbiOy/AwDfUMXnbLyh9eLavjh6Y1At//N1lhiHSn5a7K?= =?us-ascii?Q?xaOA5mc4zA7qUWcr+uDiZLk6tP+Vk6AINW+VW4N4VMKWlbQxsMPLwkzz/6Io?= =?us-ascii?Q?pTCKYWqGdzF+i7aGvj/W6xmCT2lpr0UYTSrtMgMGRcgycCwjVlg1tdLTtz+x?= =?us-ascii?Q?OPOiz4pFP719dGYrp5RPksqeggmOk8kkc8N3Uzx0xofjWi5cb/ox2BnH3Zcg?= =?us-ascii?Q?TbRLQUlcY6GfWqlSTSameckfuIHL3z6RUKNOyLA4cl/U3B7hBX9CPMxdthBw?= =?us-ascii?Q?NodHI6PdVu7BWn1KlPTlbba0LGEm3A9K1IY3ja1JbnVQ9Wc9Y+5mdW9Ih1ZB?= =?us-ascii?Q?d6/2HAx0Ka0obR/QljP8YvlvK2CjpfXS0D1hqJXQr6CHfXMGvb7rx+5aghsP?= =?us-ascii?Q?ykgbjJCZaA0QyiUacwUpiJXbKMCGK8mS0sxqkej16dRhPXiB5Xz/1R2fUd7k?= =?us-ascii?Q?UkndZJ3/b2pdJh1JD5s1k6LbXCk7iYUxAOtolm0igJEDyXjytBx5g8ZWUvRO?= =?us-ascii?Q?wg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: bfc2e2fb-5960-4645-315c-08dd93ddc0be X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB8794.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2025 18:24:39.0409 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DEc0Ya/3BdRc13lvwB4o3sOBy+t1MKFadk79OoqjZk/GbBP+YXoMHHHR3YymljHu4JrEXmYa7aNSFvCRHXOerqv9Rc33mJWyAZKMfWz9U1E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PPFEDAA4523C X-OriginatorOrg: intel.com On Fri, May 09, 2025 at 09:39:15AM -0700, Dave Jiang wrote: > Add a unit test to verify the features ioctl commands. Test support added > for locating a features device, retrieve and verify the supported features > commands, retrieve specific feature command data, retrieve test feature > data, and write and verify test feature data. > > Acked-by: Dan Williams > Signed-off-by: Dave Jiang > --- > v6: > - Provide a fwctl option and move everything behind it. (Dan) > - Rename test app back to fwctl.c. (Dan) > - Fix spelling error. (Dan) > - Expand scope of fwctl device in documentation. (Dan) > --- > cxl/fwctl/cxl.h | 2 +- > meson_options.txt | 2 + > test/cxl-features.sh | 31 +++ > test/fwctl.c | 439 +++++++++++++++++++++++++++++++++++++++++++ > test/meson.build | 19 ++ > 5 files changed, 492 insertions(+), 1 deletion(-) > create mode 100755 test/cxl-features.sh > create mode 100644 test/fwctl.c > skip - > diff --git a/test/meson.build b/test/meson.build > index d871e28e17ce..918db7e6049b 100644 > --- a/test/meson.build > +++ b/test/meson.build > @@ -17,6 +17,13 @@ ndctl_deps = libndctl_deps + [ > versiondep, > ] > > +libcxl_deps = [ > + cxl_dep, > + ndctl_dep, > + uuid, > + kmod, > +] > + > libndctl = executable('libndctl', testcore + [ 'libndctl.c'], > dependencies : libndctl_deps, > include_directories : root_inc, > @@ -235,6 +242,18 @@ if get_option('keyutils').enabled() > ] > endif > > +uuid_dep = dependency('uuid', required: false) > +if get_option('fwctl').enabled() and uuid_dep.found() > + fwctl = executable('fwctl', 'fwctl.c', > + dependencies : libcxl_deps, > + include_directories : root_inc, > + ) > + cxl_features = find_program('cxl-features.sh') > + tests += [ > + [ 'cxl-features.sh', cxl_features, 'cxl' ], > + ] > +endif Is the fwctl feature enabled fuss still needed now that the UAPI headers are vendored locally? Seems the test will quickly SKIP if fwctl dev not found. I kind of like the idea of seeing a 'SKIP' and knowing the test didn't run than seeing nothing at all in the test output. > + > foreach t : tests > test(t[0], t[1], > is_parallel : false, > -- > 2.49.0 >