From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A8C826139C for ; Tue, 20 May 2025 15:59:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747756797; cv=none; b=nszy651P8iLP4bzHqmNRG3zVxfJYF8MZZYigQSX8Ono9ANyzhmoS5nYRgfKPqnzCmFb9tebbB3OgryHzf9JhcXOCWrVEgti44YHT/8Jk2ZVtUPrqwaaXQBsR58JTO6e0ioOqhrChXYJfa59bDobk81SZBAtUTRQ+gUGMB1Eds2U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747756797; c=relaxed/simple; bh=uMKare1JMoMpVyLIhb7RK/+0Lqx1ozH5McAETGhxcBo=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Hpg+2fqMpcaiDEQE0Gt79PMtAxlGwmnOMojGAOINLhMUKTOdbQ6gI+MgmT3BqoevCceh2TU1pGqYTsU0Fnso9//AyAiFzt2gy3IU7OyEqMGO11gWCbkWxz4e/0Cf/DI4uMXNtvepXv3DADMby4hszUjOivM5DLTntOvweMdCD9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UnWrkjli; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UnWrkjli" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-7399838db7fso5492985b3a.0 for ; Tue, 20 May 2025 08:59:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747756795; x=1748361595; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=dxkUkSoTkriwhtrET04LcZhmJfr7nP1NVw2CFVXLcZU=; b=UnWrkjli5qblAz7IZjtzdsD3NrQE0v5JVK1DvCIqpEndvg2Ab6yLzTIO/YS3WZ5ETp EE3ytk4YP0lwZd8Rq7CiABC4cIrhVC7owkw9QiQ9k0Md7je2DXPlPweZgzx5fEGhWFYa PKpEz3hbEBD5zriRjE0u8ojqoEI+k/HZnlZuwdATyv0v+1TZfx455Y0SXAtCS/F9qO0i xY29fgvAyO5yT7VvhPN3Y5oMLGonaDuBrIKgkuaw+rX8Yj5twZZMkqWoybZDEk+KMIgr 5LyM8P7ZBHELVY4p/VOzmDLQABPZ1Q633R7nDd1gbyGkR0QiAkgeOq04AcM0VrLe6DXC Px9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747756795; x=1748361595; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dxkUkSoTkriwhtrET04LcZhmJfr7nP1NVw2CFVXLcZU=; b=fO+Lhfwu3w3tynGbKGoAMEhE1QXgOi3rgdvBXIHLmlarc+up4xDC1QJzLZ4Nza4JzV E7iUOLVfX78lsHSEd90ollfw6Xc7eZxdzGCF+iyZKmCRo3ZuTP4DpMoHuLAIHVsf7/nK ofkaoOJurv0j7U6cL3wLEb0XZeDOrCi3gwrOD2ni/mCiqUgOzNg6w65YVVTCdO8GfEzw x8hEI+hSxpLhuajqk1r9dfmCeZkiFc9FTDhVlDLmCXw+vWgB5gNdmrt8Q2Ynpzclp3kS nsVCGYC6j4w2oRcn5gIUFt0JovtrLxpuLXkQzJkz6/JQ9tbiShUW7S0+BP+T8xGFi2w9 GXzQ== X-Forwarded-Encrypted: i=1; AJvYcCVZ4/LZPxOuGFlDs2EOQBtDkEjyzHq2/Jg6XAfpSKMecfFl8LDZAlu172f6Z3rl2hVbx+TjCzMjaJY=@vger.kernel.org X-Gm-Message-State: AOJu0YzFboFOmO7+67ftp+PD3gj9YuSCoAVCib1FxldAFLL7a0Qrxwm4 W3EoLOGV+ofzLn4sj5hrOgmS+JZKaYzjKK/CqxNjKtNHRRNQsuNdmWpV X-Gm-Gg: ASbGncvr29ZT8u5YLsxFJa/2gUL1KgaUttGPSRcVZbm2pufZVYdwB17tRdpO+J0TVlL Mse3L66ErOV0qMfGIOrW52h0yIIwxtnwRsXoBApTmZh/kqpnY7D7uPxw+7Xvg8k/v/EH1pRRrHS KwNKcgmNvexQcNdECoPpHQfVKDVM7jLuQH6PQbArgtA77bw99OM/QtsLORjZlVZvr7UM0N6U4Dt cYIm6LlBXlH5/6rMxVZazDkdJcKZOtH8aJ36Rp0yu8ZACxci1EPxkuXVQNRF7SBDNmkJmUOqp6h viv/wYWCa7uR3c/fH/PIRGvRJMzdtHalYNTilBmObw== X-Google-Smtp-Source: AGHT+IFhSKd7iF3ejVcnHITQ1SCG2P/RVTDXloMljVgV3hS2wwhTU8w7O1Ffa5vCZGp97tnR+U7Bmg== X-Received: by 2002:a05:6a00:3d01:b0:740:58d3:71a8 with SMTP id d2e1a72fcca58-742a99fabb8mr21403693b3a.1.1747756795302; Tue, 20 May 2025 08:59:55 -0700 (PDT) Received: from lg ([2601:646:8f03:9fee:2c89:c0cf:1cbd:96d3]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-742a982b7ffsm8373038b3a.104.2025.05.20.08.59.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 May 2025 08:59:54 -0700 (PDT) From: Fan Ni X-Google-Original-From: Fan Ni Date: Tue, 20 May 2025 08:59:49 -0700 To: anisa.su887@gmail.com Cc: qemu-devel@nongnu.org, Jonathan.Cameron@huawei.com, nifan.cxl@gmail.com, dave@stgolabs.net, linux-cxl@vger.kernel.org, Anisa Su Subject: Re: [PATCH v2 02/10] cxl-mailbox-utils: 0x5600 - FMAPI Get DCD Info Message-ID: References: <20250508001754.122180-1-anisa.su887@gmail.com> <20250508001754.122180-3-anisa.su887@gmail.com> Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250508001754.122180-3-anisa.su887@gmail.com> On Thu, May 08, 2025 at 12:00:58AM +0000, anisa.su887@gmail.com wrote: > From: Anisa Su > > FM DCD Management command 0x5600 implemented per CXL 3.2 Spec Section 7.6.7.6.1. > > Signed-off-by: Anisa Su LGTM. minor comments inline. Reviewed-by: Fan Ni > --- > hw/cxl/cxl-mailbox-utils.c | 56 ++++++++++++++++++++++++++++++++++++ > hw/cxl/i2c_mctp_cxl.c | 6 ++-- > hw/mem/cxl_type3.c | 4 +++ > include/hw/cxl/cxl_device.h | 1 + > include/hw/cxl/cxl_opcodes.h | 3 ++ > 5 files changed, 68 insertions(+), 2 deletions(-) > > diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c > index ed3294530f..d3c69233b8 100644 > --- a/hw/cxl/cxl-mailbox-utils.c > +++ b/hw/cxl/cxl-mailbox-utils.c > @@ -3280,6 +3280,52 @@ static CXLRetCode cmd_dcd_release_dyn_cap(const struct cxl_cmd *cmd, > return CXL_MBOX_SUCCESS; > } > > +/* CXL r3.2 section 7.6.7.6.1: Get DCD Info (Opcode 5600h) */ > +static CXLRetCode cmd_fm_get_dcd_info(const struct cxl_cmd *cmd, > + uint8_t *payload_in, > + size_t len_in, > + uint8_t *payload_out, > + size_t *len_out, > + CXLCCI *cci) > +{ > + struct { > + uint8_t num_hosts; > + uint8_t num_regions_supported; > + uint8_t rsvd1[2]; > + uint16_t add_select_policy_bitmask; uint16_t supported_add_sel_policy_bitmask; > + uint8_t rsvd2[2]; > + uint16_t release_select_policy_bitmask; uint16_t supported_removal_policy_bitmask; Fan > + uint8_t sanitize_on_release_bitmask; > + uint8_t rsvd3; > + uint64_t total_dynamic_capacity; > + uint64_t region_blk_size_bitmasks[8]; > + } QEMU_PACKED *out = (void *)payload_out; > + CXLType3Dev *ct3d = CXL_TYPE3(cci->d); > + CXLDCRegion *region; > + int i; > + > + out->num_hosts = 1; > + out->num_regions_supported = ct3d->dc.num_regions; > + stw_le_p(&out->add_select_policy_bitmask, > + BIT(CXL_EXTENT_SELECTION_POLICY_PRESCRIPTIVE)); > + stw_le_p(&out->release_select_policy_bitmask, > + BIT(CXL_EXTENT_REMOVAL_POLICY_PRESCRIPTIVE)); > + out->sanitize_on_release_bitmask = 0; > + > + stq_le_p(&out->total_dynamic_capacity, > + ct3d->dc.total_capacity / CXL_CAPACITY_MULTIPLIER); > + > + for (i = 0; i < ct3d->dc.num_regions; i++) { > + region = &ct3d->dc.regions[i]; > + memcpy(&out->region_blk_size_bitmasks[i], > + ®ion->supported_blk_size_bitmask, > + sizeof(out->region_blk_size_bitmasks[i])); > + } > + > + *len_out = sizeof(*out); > + return CXL_MBOX_SUCCESS; > +} > + > static const struct cxl_cmd cxl_cmd_set[256][256] = { > [INFOSTAT][BACKGROUND_OPERATION_ABORT] = { "BACKGROUND_OPERATION_ABORT", > cmd_infostat_bg_op_abort, 0, 0 }, > @@ -3401,6 +3447,11 @@ static const struct cxl_cmd cxl_cmd_set_sw[256][256] = { > cmd_tunnel_management_cmd, ~0, 0 }, > }; > > +static const struct cxl_cmd cxl_cmd_set_fm_dcd[256][256] = { > + [FMAPI_DCD_MGMT][GET_DCD_INFO] = { "GET_DCD_INFO", > + cmd_fm_get_dcd_info, 0, 0 }, > +}; > + > /* > * While the command is executing in the background, the device should > * update the percentage complete in the Background Command Status Register > @@ -3703,7 +3754,12 @@ void cxl_initialize_t3_fm_owned_ld_mctpcci(CXLCCI *cci, DeviceState *d, > DeviceState *intf, > size_t payload_max) > { > + CXLType3Dev *ct3d = CXL_TYPE3(d); > + > cxl_copy_cci_commands(cci, cxl_cmd_set_t3_fm_owned_ld_mctp); > + if (ct3d->dc.num_regions) { > + cxl_copy_cci_commands(cci, cxl_cmd_set_fm_dcd); > + } > cci->d = d; > cci->intf = intf; > cxl_init_cci(cci, payload_max); > diff --git a/hw/cxl/i2c_mctp_cxl.c b/hw/cxl/i2c_mctp_cxl.c > index 7d2cbc3b75..dd5fc4f393 100644 > --- a/hw/cxl/i2c_mctp_cxl.c > +++ b/hw/cxl/i2c_mctp_cxl.c > @@ -29,6 +29,7 @@ > #include "hw/pci/pcie_port.h" > #include "hw/qdev-properties.h" > #include "hw/registerfields.h" > +#include "hw/cxl/cxl_opcodes.h" > > #define TYPE_I2C_MCTP_CXL "i2c_mctp_cxl" > > @@ -198,9 +199,10 @@ static void i2c_mctp_cxl_handle_message(MCTPI2CEndpoint *mctp) > */ > > if (!(msg->message_type == MCTP_MT_CXL_TYPE3 && > - msg->command_set < 0x51) && > + msg->command_set < PHYSICAL_SWITCH) && > !(msg->message_type == MCTP_MT_CXL_FMAPI && > - msg->command_set >= 0x51 && msg->command_set < 0x56)) { > + msg->command_set >= PHYSICAL_SWITCH && > + msg->command_set < GLOBAL_MEMORY_ACCESS_EP_MGMT)) { > buf->rc = CXL_MBOX_UNSUPPORTED; > st24_le_p(buf->pl_length, len_out); > s->len = s->pos; > diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c > index 11c38a9292..7129da0940 100644 > --- a/hw/mem/cxl_type3.c > +++ b/hw/mem/cxl_type3.c > @@ -8,6 +8,7 @@ > * > * SPDX-License-Identifier: GPL-v2-only > */ > +#include > > #include "qemu/osdep.h" > #include "qemu/units.h" > @@ -766,6 +767,8 @@ static bool cxl_create_dc_regions(CXLType3Dev *ct3d, Error **errp) > uint64_t region_len; > uint64_t decode_len; > uint64_t blk_size = 2 * MiB; > + /* Only 1 block size is supported for now. */ > + uint64_t supported_blk_size_bitmask = BIT((int) log2(blk_size)); > CXLDCRegion *region; > MemoryRegion *mr; > uint64_t dc_size; > @@ -811,6 +814,7 @@ static bool cxl_create_dc_regions(CXLType3Dev *ct3d, Error **errp) > .block_size = blk_size, > /* dsmad_handle set when creating CDAT table entries */ > .flags = 0, > + .supported_blk_size_bitmask = supported_blk_size_bitmask, > }; > ct3d->dc.total_capacity += region->len; > region->blk_bitmap = bitmap_new(region->len / region->block_size); > diff --git a/include/hw/cxl/cxl_device.h b/include/hw/cxl/cxl_device.h > index ca515cab13..bebed04085 100644 > --- a/include/hw/cxl/cxl_device.h > +++ b/include/hw/cxl/cxl_device.h > @@ -608,6 +608,7 @@ typedef struct CXLDCRegion { > uint32_t dsmadhandle; > uint8_t flags; > unsigned long *blk_bitmap; > + uint64_t supported_blk_size_bitmask; > } CXLDCRegion; > > typedef struct CXLSetFeatureInfo { > diff --git a/include/hw/cxl/cxl_opcodes.h b/include/hw/cxl/cxl_opcodes.h > index 26d3a99e8a..c4c233665e 100644 > --- a/include/hw/cxl/cxl_opcodes.h > +++ b/include/hw/cxl/cxl_opcodes.h > @@ -61,4 +61,7 @@ enum { > #define MANAGEMENT_COMMAND 0x0 > MHD = 0x55, > #define GET_MHD_INFO 0x0 > + FMAPI_DCD_MGMT = 0x56, > + #define GET_DCD_INFO 0x0 > + GLOBAL_MEMORY_ACCESS_EP_MGMT = 0X59 > }; > -- > 2.47.2 > -- Fan Ni