From: Alison Schofield <alison.schofield@intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: <linux-cxl@vger.kernel.org>, <dave@stgolabs.net>,
<jonathan.cameron@huawei.com>, <vishal.l.verma@intel.com>,
<ira.weiny@intel.com>, <dan.j.williams@intel.com>
Subject: Re: [PATCH v2] cxl: Adjust extended linear cache failure emission in cxl_acpi
Date: Tue, 28 Oct 2025 18:46:08 -0700 [thread overview]
Message-ID: <aQFx4DODaAFG4qJN@aschofie-mobl2.lan> (raw)
In-Reply-To: <20251003185509.3215900-1-dave.jiang@intel.com>
On Fri, Oct 03, 2025 at 11:55:09AM -0700, Dave Jiang wrote:
> The cxl_acpi module spams "Extended linear cache calculation failed"
> when the hmat memory target is not found for a node. This is normal
> when the memory target does not contain extended linear cache
> attributes. Adjust cxl_acpi_set_cache_size() to just return 0 if error
> is returned from hmat_get_extended_linear_cache_size(). That is the
> only error returned from hmat_get_extended_linear_cache_size() as
> -ENOENT.
>
> Also remove the check for -EOPNOTSUPP in cxl_setup_extended_linear_cache()
> since that errno is never returned by cxl_acpi_set_cache_size().
WFM in cxl-test module. Messages like these are gone:
cxl root0: Extended linear cache calculation failed rc:-2
I'll second Jonathan's logic flip suggestion, and with that,
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
>
> Suggeted-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
>
next prev parent reply other threads:[~2025-10-29 1:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 18:55 [PATCH v2] cxl: Adjust extended linear cache failure emission in cxl_acpi Dave Jiang
2025-10-28 16:05 ` Jonathan Cameron
2025-10-29 1:46 ` Alison Schofield [this message]
2025-11-03 23:48 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQFx4DODaAFG4qJN@aschofie-mobl2.lan \
--to=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox