From: Alison Schofield <alison.schofield@intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: <linux-cxl@vger.kernel.org>, <nvdimm@lists.linux.dev>,
<dave@stgolabs.net>, <jonathan.cameron@huawei.com>,
<vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
<dan.j.williams@intel.com>
Subject: Re: [NDCTL PATCH 2/5] cxl/test: Fix cxl-poison.sh to detect the correct elc sysfs attrib
Date: Fri, 14 Nov 2025 16:54:23 -0800 [thread overview]
Message-ID: <aRfPPyhC5aauX09g@aschofie-mobl2.lan> (raw)
In-Reply-To: <20251031174003.3547740-3-dave.jiang@intel.com>
On Fri, Oct 31, 2025 at 10:40:00AM -0700, Dave Jiang wrote:
> The cxl-poison.sh script attempts to read the extended linear cache
> size sysfs attribute but is using the incorrect attribute name.
>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Reviewed, tested and updated to the no-op comment
[ alisons: update the no-op attribute comment ]
Applied: https://github.com/pmem/ndctl/commits/pending
Thanks!
> ---
> test/cxl-poison.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/test/cxl-poison.sh b/test/cxl-poison.sh
> index 231a0733f096..8e81baceeb24 100644
> --- a/test/cxl-poison.sh
> +++ b/test/cxl-poison.sh
> @@ -197,8 +197,8 @@ test_poison_by_region_offset_negative()
>
> # This case is a no-op until cxl-test ELC mocking arrives
> # Try to get cache_size if the attribute exists
> - if [ -f "/sys/bus/cxl/devices/$region/cache_size" ]; then
> - cache_size=$(cat /sys/bus/cxl/devices/"$region"/cache_size)
> + if [ -f "/sys/bus/cxl/devices/$region/extended_linear_cache_size" ]; then
> + cache_size=$(cat /sys/bus/cxl/devices/"$region"/extended_linear_cache_size)
> fi
>
> # Offset within extended linear cache (if cache_size > 0)
> --
> 2.51.0
>
next prev parent reply other threads:[~2025-11-15 0:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 17:39 [NDCTL PATCH 0/5] cxl: Add tests for extended linear cache support Dave Jiang
2025-10-31 17:39 ` [NDCTL PATCH 1/5] cxl/test: Add test " Dave Jiang
2025-11-15 1:00 ` Alison Schofield
2025-11-15 2:54 ` Alison Schofield
2025-11-16 1:49 ` Alison Schofield
2025-10-31 17:40 ` [NDCTL PATCH 2/5] cxl/test: Fix cxl-poison.sh to detect the correct elc sysfs attrib Dave Jiang
2025-11-15 0:54 ` Alison Schofield [this message]
2025-10-31 17:40 ` [NDCTL PATCH 3/5] cxl/test: Move cxl-poison.sh to use cxl_test auto region Dave Jiang
2025-11-15 1:07 ` Alison Schofield
2025-10-31 17:40 ` [NDCTL PATCH 4/5] cxl/test: Move common part of poison unit test to common file Dave Jiang
2025-10-31 17:40 ` [NDCTL PATCH 5/5] cxl/test: Add support for poison test for ELC Dave Jiang
2025-11-15 1:20 ` [NDCTL PATCH 0/5] cxl: Add tests for extended linear cache support Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRfPPyhC5aauX09g@aschofie-mobl2.lan \
--to=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox