public inbox for linux-cxl@vger.kernel.org
 help / color / mirror / Atom feed
From: Alison Schofield <alison.schofield@intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
	Jonathan Cameron <jonathan.cameron@huawei.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	"Ira Weiny" <ira.weiny@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	<linux-cxl@vger.kernel.org>
Subject: Re: [PATCH] cxl: Test decoder flags as bitmasks
Date: Mon, 9 Feb 2026 08:28:59 -0800	[thread overview]
Message-ID: <aYoLS2u-EJCdOv6K@aschofie-mobl2.lan> (raw)
In-Reply-To: <af94b779-4feb-46d3-9ea4-e14a1308d0da@intel.com>

On Fri, Feb 06, 2026 at 12:33:34PM -0700, Dave Jiang wrote:
> 
> 
> On 2/6/26 11:14 AM, Alison Schofield wrote:
> > The CXL decoder flags are defined as bitmasks, not bit indices.
> > Using test_bit() to check them interprets the mask value as a bit
> > index, which is the wrong test.
> > 
> > For CXL_DECODER_F_NORMALIZED_ADDRESSING the test reads beyond the
> > flags word, making the flag sometimes appear set and blocking creation
> > of CXL region debugfs attributes that support poison operations.
> > 
> > For CXL_DECODER_F_LOCK the test reads beyond the defined bits, causing
> > the test to always return false and allowing resets that should have
> > been blocked.
> > 
> > Replace test_bit() with a bitmask check.
> > 
> > Found with cxl-test.
> > 
> > Fixes: 208f432406b7 ("cxl: Disable HPA/SPA translation handlers for Normalized Addressing")
> > Fixes: 2230c4bdc412 ("cxl: Add handling of locked CXL decoder")
> 
> Given it needs to back port and fix 2 different commits, maybe this needs to split?

OK - will do, ignore this patch.

It'll be a 2 patch series because of the dependency, but I believe that
is still preferred by backport folks.


  reply	other threads:[~2026-02-09 16:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-06 18:14 [PATCH] cxl: Test decoder flags as bitmasks Alison Schofield
2026-02-06 19:33 ` Dave Jiang
2026-02-09 16:28   ` Alison Schofield [this message]
2026-02-17 22:25 ` Davidlohr Bueso
2026-02-23 20:09 ` Gregory Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYoLS2u-EJCdOv6K@aschofie-mobl2.lan \
    --to=alison.schofield@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=ira.weiny@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox