Re: [PATCH v1 2/3] cxl: export internal structs for external Type2 drivers

[Alison Schofield <alison.schofield@intel.com>]

On Tue, Feb 24, 2026 at 04:38:03PM +0000, Alejandro Lucero Palau wrote:
> 
> On 2/24/26 02:50, Alison Schofield wrote:
> > On Mon, Feb 23, 2026 at 02:26:32PM +0000, alejandro.lucero-palau@amd.com wrote:
> > > From: Alejandro Lucero <alucerop@amd.com>
> > > 
> > > In preparation for type2 support, move structs and functions needed by
> > > external type2 drivers. Differentiate between public and private data to
> > > be preserved by type2 drivers.
> > I would have enjoyed a mention in the commit log of what was needed.
> > When I saw struct cxl_dpa_perf, struct cxl_dpa_partition,
> > CXL_NR_PARTITIONS_MAX, enum cxl_partition_mode, it wasn't so clear
> > why those were needed (as opposed to the cxl_dev_state defines)
> 
> 
> Well, this is what Type2 drivers support will end up needing once all the
> functionality is added. So we know it because the type2 full patchset and
> the idea here is to put all that in the new file visible to external
> drivers. I know the standard is to see how the changes are used by a client,
> but if I do so I will be adding all the type2 patchset ... So in this case,
> the cxl core code will use another header which will be visible to non cxl
> core, and the commit says it ... although maybe some rephrasing could help
> like:
> 
> 
> "In preparation for type2 support, move structs and functions needed by
> 
> external type2 drivers. Differentiate between public and private data to
> 
> be preserved by type2 drivers. Refer the new file by those cxl core files
> 
> needing the moved definitions."
> 
> Would this be better or too much twisted?

Well, still doesn't describe what Type2 needs access to.

How about "Type2 external drivers will need to access to "___________",
so move those to a shared header file.

Where the blank may be as broad as "all cxl_dev_state related structures
and definition", or maybe it's something more specific.

Thanks,
Alison
> 
> > 
> > I was a bit concerned that new cxl/cxl.h had dependencies, so tested
> > that it compiled all be itself in a completely separate module.
> > 
> > Tested-by: Alison Schofield <alison.schofield@intel.com>
> 
> 
> Thank you!
>