From: Dave Jiang <dave.jiang@intel.com>
To: Dan Williams <dan.j.williams@intel.com>, vishal.l.verma@intel.com
Cc: linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev
Subject: Re: [PATCH 3/4] test: Support test modules located in 'updates' instead of 'extra'
Date: Fri, 28 Apr 2023 09:05:17 -0700 [thread overview]
Message-ID: <aa9e8e29-3682-a226-8e1b-ccfb0071c327@intel.com> (raw)
In-Reply-To: <168236638863.1027628.11883188611397194858.stgit@dwillia2-xfh.jf.intel.com>
On 4/24/23 12:59 PM, Dan Williams wrote:
> Since kernel commit:
>
> b74d7bb7ca24 ("kbuild: Modify default INSTALL_MOD_DIR from extra to updates")
>
> ...the kernel build process deposits the nfit_test can cxl_test modules in
s/can/and/ ?
> /lib/modules/$KVER/updates. This is more widely supported across multiple
> distributions as a default override for modules that ship in their native
> directory.
>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> test/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/core.c b/test/core.c
> index 5d1aa23723f1..a354f41dcba0 100644
> --- a/test/core.c
> +++ b/test/core.c
> @@ -209,7 +209,7 @@ retry:
> break;
> }
>
> - if (!strstr(path, "/extra/")) {
> + if (!strstr(path, "/extra/") && !strstr(path, "/updates/")) {
> log_err(&log_ctx, "%s.ko: appears to be production version: %s\n",
> name, path);
> break;
>
>
next prev parent reply other threads:[~2023-04-28 16:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 19:59 [ndctl PATCH 0/4] cxl list and test fixes Dan Williams
2023-04-24 19:59 ` [PATCH 1/4] cxl/list: Fix filtering RCDs Dan Williams
2023-04-28 15:54 ` Dave Jiang
2023-04-24 19:59 ` [PATCH 2/4] cxl/list: Filter root decoders by region Dan Williams
2023-04-28 16:03 ` Dave Jiang
2023-04-24 19:59 ` [PATCH 3/4] test: Support test modules located in 'updates' instead of 'extra' Dan Williams
2023-04-28 16:05 ` Dave Jiang [this message]
2023-04-24 19:59 ` [PATCH 4/4] test: Fix dangling pointer warning Dan Williams
2023-04-28 16:06 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa9e8e29-3682-a226-8e1b-ccfb0071c327@intel.com \
--to=dave.jiang@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox