From: Gregory Price <gourry@gourry.net>
To: Alison Schofield <alison.schofield@intel.com>
Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com, dave@stgolabs.net,
jonathan.cameron@huawei.com, dave.jiang@intel.com,
vishal.l.verma@intel.com, ira.weiny@intel.com,
dan.j.williams@intel.com
Subject: Re: [PATCH v4 1/3] cxl/core/region: move pmem region driver logic into region_pmem.c
Date: Tue, 24 Mar 2026 10:11:48 -0500 [thread overview]
Message-ID: <acKptBsAaDOk0VaW@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <acIJrkkPD7dM3pBr@aschofie-mobl2.lan>
On Mon, Mar 23, 2026 at 08:49:02PM -0700, Alison Schofield wrote:
> On Mon, Mar 23, 2026 at 01:37:49AM -0400, Gregory Price wrote:
> >
> > The recent pmem/nvdimm Kconfig change does kind of show that we might
> > have some bloat for some deployments which might not care about pmem -
> > for example.
>
> I guess my original thought was, what is your long term intent with
> the move? And I was thinking you are probably heading to conditionally
> compiling. HOWEVER, now the scaredy-cat-me is thinking, shoot, that
> would add test config complexity and test misses. ie. Folks make a
> change in region_dax.c, don't test with CONFIG_CXL_PMEM enabled, and
> boom.
>
> So, I lean towards keeping them all (working) together, like you have.
>
fwiw i think this is the right take. It doesn't really cost us anything
to keep in, and probably prevents adding more Kconfig footguns.
~Gregory
next prev parent reply other threads:[~2026-03-24 15:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-22 13:16 [PATCH v4 0/3] pull region-specific logic into new files Gregory Price
2026-03-22 13:16 ` [PATCH v4 1/3] cxl/core/region: move pmem region driver logic into region_pmem.c Gregory Price
2026-03-23 2:37 ` Alison Schofield
2026-03-23 5:37 ` Gregory Price
2026-03-24 3:49 ` Alison Schofield
2026-03-24 15:11 ` Gregory Price [this message]
2026-03-23 15:08 ` Jonathan Cameron
2026-03-23 15:47 ` Gregory Price
2026-03-23 17:58 ` Jonathan Cameron
2026-04-11 20:34 ` Dan Williams
2026-03-25 1:31 ` Alison Schofield
2026-03-22 13:16 ` [PATCH v4 2/3] cxl/core/region: move dax region device logic into region_dax.c Gregory Price
2026-03-23 15:11 ` Jonathan Cameron
2026-03-25 1:31 ` Alison Schofield
2026-03-22 13:16 ` [PATCH v4 3/3] cxl/core: use cleanup.h for devm_cxl_add_dax_region Gregory Price
2026-03-23 12:17 ` Jonathan Cameron
2026-03-25 1:33 ` Alison Schofield
2026-03-26 16:28 ` [PATCH v4 0/3] pull region-specific logic into new files Ira Weiny
2026-03-26 16:34 ` Gregory Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acKptBsAaDOk0VaW@gourry-fedora-PF4VCD3F \
--to=gourry@gourry.net \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=kernel-team@meta.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox