From: alison.schofield@intel.com
To: Vishal Verma <vishal.l.verma@intel.com>
Cc: Alison Schofield <alison.schofield@intel.com>,
nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org
Subject: [PATCH v6 6/7] cxl/list: add --media-errors option to cxl list
Date: Wed, 17 Jan 2024 16:28:05 -0800 [thread overview]
Message-ID: <acff17b0f76ecf9a0fefdc1d6c02afcc9ef8a530.1705534719.git.alison.schofield@intel.com> (raw)
In-Reply-To: <cover.1705534719.git.alison.schofield@intel.com>
From: Alison Schofield <alison.schofield@intel.com>
The --media-errors option to 'cxl list' retrieves poison lists from
memory devices supporting the capability and displays the returned
media_error records in the cxl list json. This option can apply to
memdevs or regions.
Example usage in the Documentation/cxl/cxl-list.txt update.
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
---
Documentation/cxl/cxl-list.txt | 71 ++++++++++++++++++++++++++++++++++
cxl/filter.h | 3 ++
cxl/list.c | 2 +
3 files changed, 76 insertions(+)
diff --git a/Documentation/cxl/cxl-list.txt b/Documentation/cxl/cxl-list.txt
index 838de4086678..6105c896938c 100644
--- a/Documentation/cxl/cxl-list.txt
+++ b/Documentation/cxl/cxl-list.txt
@@ -415,6 +415,77 @@ OPTIONS
--region::
Specify CXL region device name(s), or device id(s), to filter the listing.
+-L::
+--media-errors::
+ Include media-error information. The poison list is retrieved from the
+ device(s) and media_error records are added to the listing. Apply this
+ option to memdevs and regions where devices support the poison list
+ capability.
+
+----
+# cxl list -m mem1 --media-errors
+[
+ {
+ "memdev":"mem1",
+ "pmem_size":1073741824,
+ "ram_size":1073741824,
+ "serial":1,
+ "numa_node":1,
+ "host":"cxl_mem.1",
+ "media_errors":[
+ {
+ "dpa":0,
+ "dpa_length":64,
+ "source":"Injected"
+ },
+ {
+ "region":"region5",
+ "dpa":1073741824,
+ "dpa_length":64,
+ "hpa":1035355557888,
+ "source":"Injected"
+ },
+ {
+ "region":"region5",
+ "dpa":1073745920,
+ "dpa_length":64,
+ "hpa":1035355566080,
+ "source":"Injected"
+ }
+ ]
+ }
+]
+
+# cxl list -r region5 --media-errors
+[
+ {
+ "region":"region5",
+ "resource":1035355553792,
+ "size":2147483648,
+ "type":"pmem",
+ "interleave_ways":2,
+ "interleave_granularity":4096,
+ "decode_state":"commit",
+ "media_errors":[
+ {
+ "memdev":"mem1",
+ "dpa":1073741824,
+ "dpa_length":64,
+ "hpa":1035355557888,
+ "source":"Injected"
+ },
+ {
+ "memdev":"mem1",
+ "dpa":1073745920,
+ "dpa_length":64,
+ "hpa":1035355566080,
+ "source":"Injected"
+ }
+ ]
+ }
+]
+----
+
-v::
--verbose::
Increase verbosity of the output. This can be specified
diff --git a/cxl/filter.h b/cxl/filter.h
index 3f65990f835a..956a46e0c7a9 100644
--- a/cxl/filter.h
+++ b/cxl/filter.h
@@ -30,6 +30,7 @@ struct cxl_filter_params {
bool fw;
bool alert_config;
bool dax;
+ bool media_errors;
int verbose;
struct log_ctx ctx;
};
@@ -88,6 +89,8 @@ static inline unsigned long cxl_filter_to_flags(struct cxl_filter_params *param)
flags |= UTIL_JSON_ALERT_CONFIG;
if (param->dax)
flags |= UTIL_JSON_DAX | UTIL_JSON_DAX_DEVS;
+ if (param->media_errors)
+ flags |= UTIL_JSON_MEDIA_ERRORS;
return flags;
}
diff --git a/cxl/list.c b/cxl/list.c
index 93ba51ef895c..bcdee0afd405 100644
--- a/cxl/list.c
+++ b/cxl/list.c
@@ -57,6 +57,8 @@ static const struct option options[] = {
"include memory device firmware information"),
OPT_BOOLEAN('A', "alert-config", ¶m.alert_config,
"include alert configuration information"),
+ OPT_BOOLEAN('L', "media-errors", ¶m.media_errors,
+ "include media-error information "),
OPT_INCR('v', "verbose", ¶m.verbose, "increase output detail"),
#ifdef ENABLE_DEBUG
OPT_BOOLEAN(0, "debug", &debug, "debug list walk"),
--
2.37.3
next prev parent reply other threads:[~2024-01-18 0:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 0:27 [ndctl PATCH v6 0/7] Support poison list retrieval alison.schofield
2024-01-18 0:28 ` [PATCH v6 1/7] libcxl: add interfaces for GET_POISON_LIST mailbox commands alison.schofield
2024-01-19 18:32 ` Dave Jiang
2024-01-18 0:28 ` [PATCH v6 2/7] cxl: add an optional pid check to event parsing alison.schofield
2024-01-19 18:35 ` Dave Jiang
2024-01-18 0:28 ` [PATCH v6 3/7] cxl/event_trace: add a private context for private parsers alison.schofield
2024-01-19 21:08 ` Dave Jiang
2024-01-18 0:28 ` [PATCH v6 4/7] cxl/event_trace: add helpers get_field_[string|data]() alison.schofield
2024-01-19 21:18 ` Dave Jiang
2024-01-18 0:28 ` [PATCH v6 5/7] cxl/list: collect and parse media_error records alison.schofield
2024-01-18 0:28 ` alison.schofield [this message]
2024-01-18 0:28 ` [PATCH v6 7/7] cxl/test: add cxl-poison.sh unit test alison.schofield
2024-01-18 21:56 ` [ndctl PATCH v6 0/7] Support poison list retrieval Dan Williams
2024-01-18 23:34 ` Alison Schofield
2024-01-18 23:55 ` Dan Williams
2024-02-07 22:54 ` Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acff17b0f76ecf9a0fefdc1d6c02afcc9ef8a530.1705534719.git.alison.schofield@intel.com \
--to=alison.schofield@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox