From: Alison Schofield <alison.schofield@intel.com>
To: "Cheatham, Benjamin" <benjamin.cheatham@amd.com>
Cc: Terry Bowman <terry.bowman@amd.com>, <dave@stgolabs.net>,
<jonathan.cameron@huawei.com>, <dave.jiang@intel.com>,
<dan.j.williams@intel.com>, <shiju.jose@huawei.com>,
<ming.li@zohomail.com>, <Smita.KoralahalliChannabasappa@amd.com>,
<rrichter@amd.com>, <dan.carpenter@linaro.org>,
<PradeepVineshReddy.Kodamati@amd.com>, <lukas@wunner.de>,
<sathyanarayanan.kuppuswamy@linux.intel.com>,
<nvdimm@lists.linux.dev>, <alucerop@amd.com>,
<ira.weiny@intel.com>, <linux-cxl@vger.kernel.org>
Subject: Re: [ndctl PATCH 0/3] Enable CXL protocol testing
Date: Mon, 20 Apr 2026 21:05:37 -0700 [thread overview]
Message-ID: <aeb3kXkeAkWBm-DW@aschofie-mobl2.lan> (raw)
In-Reply-To: <7fe63454-9df7-47c9-ae7f-4db1fd1a3576@amd.com>
On Wed, Apr 08, 2026 at 04:39:41PM -0500, Cheatham, Benjamin wrote:
> On 4/8/2026 3:32 PM, Terry Bowman wrote:
> > Current CXL error injection (EINJ) only supports Root Port protocol error
> > injection but a method to test all CXL devices is needed. This series
> > outlines methods to update both the kernel and the 'aer-inject' tool-without
> > relying on EINJ-to enable CXL RAS protocol error handling across all CXL
> > devices.
> >
>
> This functionality should probably be added to the inject-protocol-error subcommand
> instead of spread out across the directory as a bunch of scripts + patches. The command
> is only set up for protocol error injection, but I don't think it would be *too* hard
> to extend.
>
> I think the first thing you have to do is expand the accepted device types to include ports and
> memdevs instead of just dports. That should be simple enough, there are already helpers to find
> both based on sbdf, name, etc. Then, you'd need to change the interface used to inject the error
> based on device type (is it a root port? then use EINJ, otherwise use aer-inject). All that's
> left at that point is to actually call the aer-inject command with the correct options (and
> update the documentation/help messages).
>
> I would be happy to help with any of the above if you agree with the direction, just let me
> know!
Terry & Ben,
Terry thanks for sharing all this!
Reading patches and Bens comments and trying to understand the pieces
needed to make this reusable. Help me out here:
1) expand our (Bens recently added) cxl-cli inject-protocol-error cmds
- to handle new types
- to route to aer-inject tool
2) make aer-inject tool handle corr/uncor internal errors
https://github.com/intel/aer-inject
3) make cxl/test capable of do special RAS status
- maybe a wrapper
4) then we write scripts that run under cxl/test, require aer-inject
tool AND what else do they require? Does this require CXL QEMU devices?
Are they doing something special in this recipe? Is this something our
CXL Test mock devices can fake?
Above is my quick attempt to understand. Please advise me.
--Alison
>
> Thanks,
> Ben
next prev parent reply other threads:[~2026-04-21 4:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 20:32 [ndctl PATCH 0/3] Enable CXL protocol testing Terry Bowman
2026-04-08 20:32 ` [ndctl PATCH 1/3] test/cxl: Enable CXL protocol error testing using aer-inject Terry Bowman
2026-04-08 21:39 ` Cheatham, Benjamin
2026-04-08 20:32 ` [ndctl PATCH 2/3] test/aer-inject: Add aer-inject correctable and uncorrectable interanl error support Terry Bowman
2026-04-08 20:32 ` [ndctl PATCH 3/3] test/cxl: Force RAS status in cxl_handle_cor_ras() and cxl_handle_ras() Terry Bowman
2026-04-08 21:39 ` Cheatham, Benjamin
2026-04-08 21:39 ` [ndctl PATCH 0/3] Enable CXL protocol testing Cheatham, Benjamin
2026-04-09 17:05 ` Dave Jiang
2026-04-21 4:05 ` Alison Schofield [this message]
2026-04-21 15:04 ` Bowman, Terry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeb3kXkeAkWBm-DW@aschofie-mobl2.lan \
--to=alison.schofield@intel.com \
--cc=PradeepVineshReddy.Kodamati@amd.com \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=alucerop@amd.com \
--cc=benjamin.cheatham@amd.com \
--cc=dan.carpenter@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=ming.li@zohomail.com \
--cc=nvdimm@lists.linux.dev \
--cc=rrichter@amd.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=shiju.jose@huawei.com \
--cc=terry.bowman@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox