Linux CXL
 help / color / mirror / Atom feed
From: Alison Schofield <alison.schofield@intel.com>
To: Anisa Su <anisa.su887@gmail.com>
Cc: <linux-cxl@vger.kernel.org>, <john@groves.net>,
	<dave.jiang@intel.com>, <gourry@gourry.net>, <dave@stgolabs.net>,
	<jonathan.cameron@huawei.com>, <ira.weiny@intel.com>,
	<dan.j.williams@intel.com>, Anisa Su <anisa.su@samsung.com>
Subject: Re: [RFC PATCH 00/20] DCD: Remove support for sparse regions & add tags
Date: Tue, 21 Apr 2026 14:02:23 -0700	[thread overview]
Message-ID: <aefl3_heFBu6iGe_@aschofie-mobl2.lan> (raw)
In-Reply-To: <20260411013958.47422-1-anisa.su@samsung.com>

On Fri, Apr 10, 2026 at 06:22:55PM -0700, Anisa Su wrote:
> This RFC modifies Ira's DCD patchset to enforce tags and remove sparse DAX region
> support, which are the requirements that I've understood from the community
> meetings, with the end goal of FAMFS as the end user for DCD. Feedback would be
> greatly appreciated to let me know if this is on the right track? Or totally off
> the mark...
> 
> Everything is the same as before except:
> - extents must have tags (uuids)
> - 1 tag per region
> - regions must be contiguous (no more sparse regions)
> 
> To achieve this, the main thing is to change the relationship between
> cxl_dax_region : region_extent from 1 : many to 1 : 1. Each region_extent is
> comprised of 1+ contiguous device extents with the same tag. Contiguity
> is enforced by sorting device extents by DPA order. They're re-sorted by the
> original order in which they were sent for the response, which is required by
> the spec.
> 
> Once valid extents have been collected, it's passed as 1 contiguous capacity
> to the DAX layer via cxl_dax_region notify(). Once notified, the same region
> cannot be added to again, unless all extents are released.
> 
> For release: upon receiving a release event record, if the extent is within the
> bounds of any cxl_region, and it has the correct tag, then all extents in the
> region are released, so the "More" flag is still ignored. Not sure if this is the
> right way to do it but it was the simplest.
> 
> The changes to the DAX layer remain untouched, as all of this extra validation is done
> in the CXL layer. And since FAMFS already takes care of the devdax -> fsdev conversion,
> there was no need to add anything there.
> 
> Most of the series remains unchanged as I've tried not to make too many big changes
> right off the bat. Only the following commits were modified:
> - cxl/extent: Process dynamic partition events and realize region extents
> - dax/region: Create resources on DAX regions
> - cxl/region: Read existing extents on region creation
> 
> I've tacked on 1 commit at the end to change the driver type of DC regions from
> DAXDRV_KMEM_TYPE to DAXDRV_DEVICE_TYPE so it can be bound to the new fsdev driver.
> 
> Also, I've documented with more detail in the commit messages of the commits
> that were modified on what exactly was changed, so I hope that's clear.
> 
> ================================================================================
> Git History
> 
> This series is based on cxl-next, with base commit:
> 3939dba00f98 Merge branch 'for-7.1/cxl-misc' into cxl-for-next
> + bug fix: https://lore.kernel.org/linux-cxl/20260411011137.43545-1-anisa.su@samsung.com/T/#u
> 
> GH Branch: https://github.com/anisa-su993/anisa-linux-kernel/tree/dcd-rfc-04-10-26
> 
> It doesn't apply cleanly onto famfs-v9, although I have the version that's applied
> onto famfs-v9 here: https://github.com/anisa-su993/anisa-linux-kernel/tree/famfs-v9-dcd
> - famfs-v9 for reference: https://github.com/jagalactic/linux/tree/famfs-v9
> 
> I've tested the current series without famfs as well as the series applied on
> famfs-v9 with famfs.
> ================================================================================
> Testing:

Where's the CXl unit testing...

big skip


>   tools/testing/cxl: Make event logs dynamic
>   tools/testing/cxl: Add DC Regions to mock mem data

Hi Anisa,

I'm inserting here and referencing the last 2 patches above
that add cxl/test support for DCD testing.

Let's use it! We'd really like to see the ndctl patches sync'd up
with this kernel set. That would give us a CXL Unit test 'cxl-dcd.sh'
to run on each revision. 

This is one link, perhaps the last to the ndctl set, but I think you
may have posted something long ago too:
https://lore.kernel.org/nvdimm/20250413-dcd-region2-v5-0-fbd753a2e0e8@intel.com/

-- Alison


  parent reply	other threads:[~2026-04-21 21:02 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-11  1:22 [RFC PATCH 00/20] DCD: Remove support for sparse regions & add tags Anisa Su
2026-04-11  1:22 ` [PATCH 01/20] cxl/mbox: Flag support for Dynamic Capacity Devices (DCD) Anisa Su
2026-04-11  1:22 ` [PATCH 02/20] cxl/mem: Read dynamic capacity configuration from the device Anisa Su
2026-04-11  1:22 ` [PATCH 03/20] cxl/cdat: Gather DSMAS data for DCD partitions Anisa Su
2026-04-11  1:22 ` [PATCH 04/20] cxl/core: Enforce partition order/simplify partition calls Anisa Su
2026-04-11  1:23 ` [PATCH 05/20] cxl/mem: Expose dynamic ram A partition in sysfs Anisa Su
2026-04-11  1:23 ` [PATCH 06/20] cxl/port: Add 'dynamic_ram_a' to endpoint decoder mode Anisa Su
2026-04-11  1:23 ` [PATCH 07/20] cxl/region: Add sparse DAX region support Anisa Su
2026-04-11  1:23 ` [PATCH 08/20] cxl/events: Split event msgnum configuration from irq setup Anisa Su
2026-04-11  1:23 ` [PATCH 09/20] cxl/pci: Factor out interrupt policy check Anisa Su
2026-04-11  1:23 ` [PATCH 10/20] cxl/mem: Configure dynamic capacity interrupts Anisa Su
2026-04-11  1:23 ` [PATCH 11/20] cxl/core: Return endpoint decoder information from region search Anisa Su
2026-04-11  1:23 ` [PATCH 12/20] cxl/extent: Process dynamic partition events and realize region extents Anisa Su
2026-04-11  1:23 ` [PATCH 13/20] cxl/region/extent: Expose region extent information in sysfs Anisa Su
2026-04-11  1:23 ` [PATCH 14/20] dax/bus: Factor out dev dax resize logic Anisa Su
2026-04-11  1:23 ` [PATCH 15/20] dax/region: Create resources on DAX regions Anisa Su
2026-04-11  1:23 ` [PATCH 16/20] cxl/region: Read existing extents on region creation Anisa Su
2026-04-11  1:23 ` [PATCH 17/20] cxl/mem: Trace Dynamic capacity Event Record Anisa Su
2026-04-11  1:23 ` [PATCH 18/20] tools/testing/cxl: Make event logs dynamic Anisa Su
2026-04-11  1:23 ` [PATCH 19/20] tools/testing/cxl: Add DC Regions to mock mem data Anisa Su
2026-04-11  1:23 ` [PATCH 20/20] dax/bus.c: make DC regions driver type DAXDRV_DEVICE_TYPE Anisa Su
2026-04-11  5:05 ` [RFC PATCH 00/20] DCD: Remove support for sparse regions & add tags Gregory Price
2026-04-21 18:48   ` Anisa Su
2026-04-23 20:43     ` Ira Weiny
2026-04-21 15:30 ` John Groves
2026-04-21 17:42   ` Anisa Su
2026-04-22  3:14   ` John Groves
2026-04-23  1:24     ` Anisa Su
2026-04-21 21:02 ` Alison Schofield [this message]
2026-04-23  1:20   ` Anisa Su

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aefl3_heFBu6iGe_@aschofie-mobl2.lan \
    --to=alison.schofield@intel.com \
    --cc=anisa.su887@gmail.com \
    --cc=anisa.su@samsung.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=gourry@gourry.net \
    --cc=ira.weiny@intel.com \
    --cc=john@groves.net \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox