From: Anisa Su <anisa.su887@gmail.com>
To: John Groves <john@jagalactic.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Dave Jiang <dave.jiang@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
John Groves <John@groves.net>, Fan Ni <fan.ni@samsung.com>,
Shiju Jose <shiju.jose@huawei.com>,
Robert Richter <rrichter@amd.com>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dev.srinivasulu@gmail.com" <dev.srinivasulu@gmail.com>,
"arramesh@micron.com" <arramesh@micron.com>,
"ajayjoshi@micron.com" <ajayjoshi@micron.com>
Subject: Re: [RFC PATCH 0/4] cxl/extent: Enable and validate multi-extent DCDs
Date: Thu, 23 Apr 2026 23:34:42 -0700 [thread overview]
Message-ID: <aesPAvUION9Zsadu@4470NRD-ASU.ssi.samsung.com> (raw)
In-Reply-To: <0100019dbcc13648-596853f3-0083-46e0-b654-396eedd657cb-000000@email.amazonses.com>
On Thu, Apr 23, 2026 at 11:51:12PM +0000, John Groves wrote:
> From: John Groves <john@groves.net>
>
> This series fixes correctness issues in the DCD (Dynamic Capacity
> Device) add-capacity pipeline so that multi-tag allocations, sharable
> CDAT regions, and cross-partition checks work end-to-end.
>
Thanks for the fixes, this makes way more sense. Let me see if I can squash
these nicely before LSFMM :)
One question based off the initial read:
When we do the actual dax device creation via daxctl create-device, would we
want to add an optional arg specifying uuid? I think right now, each
region_extent becomes a dax_resource of the sparse dax region and create-device
grabs any unused dax_resource if -s isn't specified. So if we want to limit to
1 tagged allocation/DAX device, we would want some way to specify that.
But let me double check tomorrow
Thanks,
Anisa
> Base
> ----
>
> The series applies on top of Anisa Su's DCD stack — specifically the
> tip of famfs-v9-dcd on the 'anisa' remote
> (git@github.com:anisa-su993/anisa-linux-kernel.git). That stack is
> the one posted to linux-cxl here:
>
> https://lore.kernel.org/linux-cxl/adnWg-60uKmduTsh@gourry-fedora-PF4VCD3F/T/#t
>
> I started out commenting on prior series, then started modifying it,
> before settling on this initial approach of generalizing the
> functionality through additional patches. I'm hoping the stake holders
> will find this easy to follow - at least as easy to follow as something
> this tedious and nuanced can be.
>
> Also, as one of the authors of the DCD spec: Now I get why this was hard
> to follow and implement. The implementation is pretty complicated.
>
> Note that this RFC builds happily, but I have not tested it yet. This
> exercise has been about fleshing out the full logic.
>
> The patches
> -----------
>
> 1) cxl/extent: Promote cxlr_dax->region_extent to an xarray
>
> Infrastructure only. Replaces the single-slot region_extent
> pointer on struct cxl_dax_region with an xarray keyed by an
> allocator-assigned u32. No behavior change; prepares storage for
> multiple tagged allocations per DAX-region shim.
>
> 2) cxl/extent: Fix DCD add-capacity: per-tag assembly, ordering, and
> integrity
>
> Rewrites the add-capacity pipeline around the tag as the unit of
> allocation (not the More-chain). Drops the DPA-contiguity reject,
> assembles each tag group separately, stable-sorts by
> shared_extn_seq, and adds cross-More-chain uniqueness,
> sequence-integrity, and alignment gates. Lifts the single-slot
> "already onlined" gate now that (1) is in place.
>
> 3) cxl/extent: Support extents in sharable CDAT regions
>
> Drops the per-extent rejection of shared_extn_seq != 0 and
> replaces it with a partition-aware check driven by the DSMAS
> SHAREABLE bit already exposed through cxl_dpa_partition.
>
> 4) cxl/extent: Reject tagged extents that span DC partitions
>
> Adds a group-level check rejecting tagged allocations whose
> extents resolve to different DC partitions. A single host-visible
> allocation cannot meaningfully straddle partitions whose CDAT
> attributes disagree.
>
> Signed-off-by: John Groves <John@Groves.net>
>
> John Groves (4):
> cxl/extent: Promote cxlr_dax->region_extent to an xarray
> cxl/extent: Fix DCD add-capacity: per-tag assembly, ordering, and
> integrity
> cxl/extent: Support extents in sharable CDAT regions
> cxl/extent: Reject tagged extents that span DC partitions
>
> drivers/cxl/core/extent.c | 93 +++---
> drivers/cxl/core/mbox.c | 628 +++++++++++++++++++++++++++++++-------
> drivers/cxl/core/region.c | 2 +
> drivers/cxl/cxl.h | 9 +-
> include/cxl/event.h | 1 -
> 5 files changed, 584 insertions(+), 149 deletions(-)
>
> --
> 2.53.0
>
>
next prev parent reply other threads:[~2026-04-24 6:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260423235108.3732424-1-john@jagalactic.com>
2026-04-23 23:51 ` [RFC PATCH 0/4] cxl/extent: Enable and validate multi-extent DCDs John Groves
2026-04-23 23:52 ` [RFC PATCH 1/4] cxl/extent: Promote cxlr_dax->region_extent to an xarray John Groves
2026-04-24 0:51 ` Dave Jiang
2026-04-24 22:01 ` Ira Weiny
2026-04-27 12:38 ` Jonathan Cameron
2026-04-27 15:12 ` Ira Weiny
2026-04-29 10:56 ` Jonathan Cameron
2026-05-01 10:56 ` Gregory Price
2026-04-27 18:32 ` Anisa Su
2026-04-23 23:52 ` [RFC PATCH 2/4] cxl/extent: Fix DCD add-capacity: per-tag assembly, ordering, and integrity John Groves
2026-04-23 23:52 ` [RFC PATCH 3/4] cxl/extent: Support extents in sharable CDAT regions John Groves
2026-04-23 23:52 ` [RFC PATCH 4/4] cxl/extent: Reject tagged extents that span DC partitions John Groves
2026-04-24 6:34 ` Anisa Su [this message]
2026-05-01 22:00 ` [RFC PATCH 0/4] cxl/extent: Enable and validate multi-extent DCDs Anisa Su
2026-05-02 10:48 ` Gregory Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aesPAvUION9Zsadu@4470NRD-ASU.ssi.samsung.com \
--to=anisa.su887@gmail.com \
--cc=John@groves.net \
--cc=ajayjoshi@micron.com \
--cc=alison.schofield@intel.com \
--cc=arramesh@micron.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=dev.srinivasulu@gmail.com \
--cc=fan.ni@samsung.com \
--cc=ira.weiny@intel.com \
--cc=john@jagalactic.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rrichter@amd.com \
--cc=shiju.jose@huawei.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox