From: Mike Rapoport <rppt@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: linux-cxl@vger.kernel.org
Subject: Re: [PATCH 1/3] mm: split out mm_init and memblock declarations from internal.h
Date: Thu, 9 Jul 2026 10:21:57 +0300 [thread overview]
Message-ID: <ak9MFSjEdOdmZ9ma@kernel.org> (raw)
In-Reply-To: <20260709065713.6C0F51F000E9@smtp.kernel.org>
On Thu, Jul 09, 2026 at 06:57:12AM +0000, sashiko-bot@kernel.org wrote:
> > +void memmap_init_range(unsigned long size, int nid, unsigned long zone,
> > + unsigned long start_pfn, unsigned long zone_end_pfn,
> > + enum meminit_context context,
> > + struct vmem_altmap *altmap, int migratetype,
> > + bool isolate_pageblock)
>
> [Severity: Low]
> Does this declaration cause a syntax error because it is missing a semicolon
> at the end?
Fixing checkpatch warning didn't go well :)
Will send v2 later.
> > +#if defined CONFIG_COMPACTION || defined CONFIG_CMA
> > +/* Free whole pageblock and set its migration type to MIGRATE_CMA. */
> > +void init_cma_reserved_pageblock(struct page *page);
> > +#endif
>
> --
> Sashiko AI review · https://sashiko.dev/#/patchset/20260709-internal-h-v1-0-956d5092782d@kernel.org?part=1
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-07-09 7:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 6:41 [PATCH 0/3] mm: split a couple of headers from internal.h Mike Rapoport (Microsoft)
2026-07-09 6:41 ` [PATCH 1/3] mm: split out mm_init and memblock declarations " Mike Rapoport (Microsoft)
2026-07-09 6:57 ` sashiko-bot
2026-07-09 7:21 ` Mike Rapoport [this message]
2026-07-09 6:41 ` [PATCH 2/3] mm: split out sparse " Mike Rapoport (Microsoft)
2026-07-09 6:41 ` [PATCH 3/3] mm: split out vmalloc " Mike Rapoport (Microsoft)
2026-07-09 7:22 ` [PATCH 0/3] mm: split a couple of headers " Mike Rapoport
2026-07-09 7:48 ` Muchun Song
2026-07-13 8:57 ` Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak9MFSjEdOdmZ9ma@kernel.org \
--to=rppt@kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox