From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2405B39B969 for ; Sun, 12 Jul 2026 13:27:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783862842; cv=none; b=mfZpuWDeDbCnwtkIQPflC4ksMRs1ko+I9WyGTSS2VtMd4/d1brb2F2dtBsS4mvk+3z03v7lnNyLeg7lx7cxF5EiAVgeLZYAqrVmt5cYHKl555MXXs9GJaeLMf9cbHWVITHqbCAqDODl8XsIUEWiY8f4xuIIVQ5JUIozf7sderiA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783862842; c=relaxed/simple; bh=C1OxfgN3DhSdqYDbXsPTR7ElZOA1GuCHr6TwBj4Hxbk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TWY4083nBvBDkPaqZ9R8TJgWzoykNC2RjYSLIC2nhKULD7TXDx/4yQ/i2uqO0A2q5QtOvyILcNrnmCgGj1AGdiLoOhdCn/cBLrwuwn+qsB0JFWC+yU82xgaOLgul8MSSHZEunPWBz8/0LtYQJCRNInk/jdxknPsJBOBrZg5CbRc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=UhNOdRPP; arc=none smtp.client-ip=209.85.160.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="UhNOdRPP" Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-51c4436d02cso10749971cf.1 for ; Sun, 12 Jul 2026 06:27:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1783862840; x=1784467640; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=uSgtWeg1aBZ0AWclvm9S4U5A86HaOMNd5qnnD7jgo3w=; b=UhNOdRPPes1AjVpnpDLyHjcwmHmeTXORQ9ykz9EtNpHRcEVM8fI/I9WwlFXVfk2EAS CqGEX1JwRUWzatPmuMajhwa73aspeM7Ie+NjdeLThhJNFSVNCJRbjQKwx2Jt8Eg7Tggx gGT3vRGnKv0g3kTxOHB496p3h0PpwCrJ2lDQrSe851qTsG5oGZxevLZmA4RbrzPFavaT F4Fb7XhpYvjvjHwPop71GutKDR2ocWAsDOnTN5Oqdagmf6o09saR/jwNFWFnXOuDC4JA IKSylRfxUNcfXysZjmkpbh81XhpUEthvPEIS7jCsxwBfTyrs/ggD/3eRdZXnaPN0Bi67 gDKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783862840; x=1784467640; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=uSgtWeg1aBZ0AWclvm9S4U5A86HaOMNd5qnnD7jgo3w=; b=raPxVQoDRktnMbAVNTkzqmEkj563sqKAFPNm5+owcdQJakMDGJQCJjdN+2mnBPFZew BLa0Y/34QFyyltRSyg/pZhMnHTaYoIr9pfatTzBFs7dO1HOJit6kpNvc+Vb4nve6x9GT Zw0Ox5uha7LtqCerndYXw18ntcJiFwKQddx9Ja3GCcV6fJwLO6yjH2OvzKAO+eyMut1B JD9dmtxGqM1mzz/uH4rHU1/rlAmPnNyrZZrfaCsmH8F+sSbsanaw3YvTm1WBjnNvhGZn fSUA3zy8/WzpmLeWxQqu/htRlEvPpfxroSxybt4zlDVZZ6aN7HDqCb4uH/aXu/LodG7b rgqA== X-Forwarded-Encrypted: i=1; AHgh+RrnrHoWZCLJNxVRRQzUEkbfsT8Mi9JP3p8JiE0L9KxuPjtSeS7018lssvg9ytYJLpse9bzdlkjcW6w=@vger.kernel.org X-Gm-Message-State: AOJu0YxzvG4epjc1bvggx+1Jj8oYIfXFbjnCJtukb+avgysgS12X8Tea EUiCjM2tGapEUpe67KvviQG0U/3+eWqf2KofLNGipL+JZugd6refiNvVg9uaLhcfN4c= X-Gm-Gg: AfdE7cnEhOe+rtQ/gJWaXf3+ATxwqc+ZHpfc03hjdtJP6ORLrvc8YcDuQtp1ka5eZVP ezNHRPlQJsrfvtVnjhrVPL+rbL4yF2ONRAsqMhzidDD+EpiTdws5K4iVHQ233EaoHFL4u16UuwF 8aiqPO02/7JFeyISiIoY0mYyhUmhoYT+f9F/AYmI3UutND7BJl8/HrYb5qPvE25NBtrvCag+IE3 53100hJDW0jwChkk/T2CYlzggweHzv3Vm8xrxt+65gv7uZzQFHBhw7Y9EXblNvlJZ2VToFrmI6A 2/bwkKwre6sot3EtKImkeG5XlkSjMuh4ze3hF7E92WdrKH4m1rqJSLGsiSlw3YzO5/NRuWU2Mnc Q4KHARBUwORXb/vsUl6TRy94J4q5A2H5kaH+AM49yvAuWcgauhYXk1SRubdJrKQ14ZxVaAeX55F Bkjl2/FeohOJoZb+do72Qbm+zIpB4FkwmBVxGprtmbKWUcuTxs8o0ZqC93pc0OkqO6enmj X-Received: by 2002:ac8:5a47:0:b0:51a:8c99:1f18 with SMTP id d75a77b69052e-51cbf281a2bmr56325921cf.71.1783862840152; Sun, 12 Jul 2026 06:27:20 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51caab6e9f4sm64833651cf.2.2026.07.12.06.27.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 06:27:19 -0700 (PDT) Date: Sun, 12 Jul 2026 09:27:14 -0400 From: Gregory Price To: "Dan Williams (nvidia)" Cc: linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, driver-core@lists.linux.dev, linux-kselftest@vger.kernel.org, kernel-team@meta.com, david@kernel.org, osalvador@suse.de, gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org, vishal.l.verma@intel.com, dave.jiang@intel.com, alison.schofield@intel.com, akpm@linux-foundation.org, ljs@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, shuah@kernel.org, iweiny@kernel.org, Smita.KoralahalliChannabasappa@amd.com, apopple@nvidia.com Subject: Re: [PATCH v6 07/10] dax: plumb hotplug online_type through dax Message-ID: References: <20260630211842.2252800-1-gourry@gourry.net> <20260630211842.2252800-8-gourry@gourry.net> <6a5016bf71df4_3b7ee5100b3@djbw-dev.notmuch> <6a51920acece6_35cf3310061@djbw-dev.notmuch> Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a51920acece6_35cf3310061@djbw-dev.notmuch> On Fri, Jul 10, 2026 at 05:44:58PM -0700, Dan Williams (nvidia) wrote: > Gregory Price wrote: > > On Thu, Jul 09, 2026 at 06:08:45PM -0400, Gregory Price wrote: > > > On Thu, Jul 09, 2026 at 02:46:39PM -0700, Dan Williams (nvidia) wrote: > > > > > > This was more a matter of having the DEFAULT set consistently across > > > the dax driver variant probe() functions to make the behavior explicit. > > > I didn't want an un-set value bug to creep in here somehow. > > > > > > Happy to drop them if you think that's unneeded. > > > > > > > Ah > > > > Not setting the value in each of those places is equivalent to setting > > MMOP_OFFLINE (0), so better to just set DEFAULT regardless. > > > > So unless you have strong feelings i will keep them as-is. > > Right, the mild feelings are only coming from the changelog mismatch > which says "Oh no, device-dax drivers can not specify their online type > besides the default" and all this series does is keep the status quo. > > That can be had by just having unconditional: > > online_type = mhp_get_default_online_type(); > > ...in dev_dax_kmem_probe() and get rid of dev_dax->online_type until the > first user arrives. If you are respinning the series and that patch > drops, yay. If not, oh well. Oh, it took me a second, I see what you're saying better. I can drop .online type and follow up with the .online_type + CXL build time patch as a separate series as you suggest. Keeps this series clean. ~Gregory