From: Gregory Price <gourry@gourry.net>
To: Miklos Szeredi <mszeredi@redhat.com>
Cc: fuse-devel@lists.linux.dev, John Groves <John@groves.net>,
Amir Goldstein <amir73il@gmail.com>,
"Darrick J . Wong" <djwong@kernel.org>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org
Subject: Re: [PATCH v5 01/10] dax: add fsdev_dax_from_file()
Date: Fri, 16 Oct 2026 11:28:29 -0400 [thread overview]
Message-ID: <atJCherUxpYkRFa7@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <20261016151638.2962413-2-mszeredi@redhat.com>
On Fri, Oct 16, 2026 at 05:16:28PM +0200, Miklos Szeredi wrote:
> From: John Groves <John@Groves.net>
>
> If the file is a fsdev_dax open, take the dax_dev from the device inode's
> i_cdev. Return with a reference grabbed on the private dax inode.
>
> Make dax_dev_get() static again (internal to super.c for alloc_dax), export
> fsdev_dax_from_file() instead.
>
> This fix is in response to a Sashiko review, and some subsequent analysis.
>
> About the 'fixes' tag: this removes the export of dax_dev_get(), which was
> flawed, and replaces it with fsdev_dax_from_file(). It feels like the fixes
> tag makes sense for correcting an ABI error.
>
> Fixes: 2ae624d5a555d ("dax: export dax_dev_get()")
> Originally-by: John Groves <john@groves.net>
> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Reviewed-by: Gregory Price (Meta) <gourry@gourry.net>
next prev parent reply other threads:[~2026-10-16 15:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 15:16 [PATCH v5 00/10] fuse: DAX device based extent maps (famfs) Miklos Szeredi
2026-10-16 15:16 ` [PATCH v5 01/10] dax: add fsdev_dax_from_file() Miklos Szeredi
2026-10-16 15:20 ` Dave Jiang
2026-10-16 15:28 ` Gregory Price [this message]
2026-10-16 15:16 ` [PATCH v5 02/10] dax: use READ_ONCE() in dax_holder() Miklos Szeredi
2026-10-16 15:20 ` Dave Jiang
2026-10-16 15:16 ` [PATCH v5 03/10] fuse: add helpers for EIO return value with kernel message Miklos Szeredi
2026-10-16 15:16 ` [PATCH v5 04/10] fuse: support 64 bit, server allocated backing ID Miklos Szeredi
2026-10-16 15:16 ` [PATCH v5 05/10] fuse: support opening 64 bit " Miklos Szeredi
2026-10-16 15:16 ` [PATCH v5 06/10] fuse: add support for opening dax device as backing Miklos Szeredi
2026-10-16 15:16 ` [PATCH v5 07/10] fuse: add extent map data structure Miklos Szeredi
2026-10-16 15:16 ` [PATCH v5 08/10] fuse: add extent map I/O support Miklos Szeredi
2026-10-16 15:16 ` [PATCH v5 09/10] fuse: add support for striped backing Miklos Szeredi
2026-10-16 15:16 ` [PATCH v5 10/10] fuse: resolve extent maps in O(1) when possible Miklos Szeredi
2026-10-20 16:50 ` [PATCH v5 00/10] fuse: DAX device based extent maps (famfs) John Groves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atJCherUxpYkRFa7@gourry-fedora-PF4VCD3F \
--to=gourry@gourry.net \
--cc=John@groves.net \
--cc=alison.schofield@intel.com \
--cc=amir73il@gmail.com \
--cc=dave.jiang@intel.com \
--cc=djwong@kernel.org \
--cc=fuse-devel@lists.linux.dev \
--cc=linux-cxl@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox