Re: [PATCH v2 3/8] cxl/region: Rename cxl_port_setup_targets() to cxl_switch_port_setup_targets()

[Alison Schofield <alison.schofield@intel.com>]

On Tue, Oct 13, 2026 at 09:45:58AM -0700, Dave Jiang wrote:
> 
> 
> On 10/10/26 5:20 PM, Alison Schofield wrote:
> > cxl_port_setup_targets() configures the switch decoder targets for a
> > region. It runs for each switch port, including host bridges, between the
> > root and an endpoint.
> > 
> > Rename the function to cxl_switch_port_setup_targets() to make its scope
> > explicit.
> > 
> > No functional change.
> > 
> > Suggested-by: Dave Jiang <dave.jiang@intel.com>
> > Assisted-by: LLM
> > Signed-off-by: Alison Schofield <alison.schofield@intel.com>
> > ---
> >  drivers/cxl/core/region.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
> > index 1a42753fda48..d564443a1d39 100644
> > --- a/drivers/cxl/core/region.c
> > +++ b/drivers/cxl/core/region.c
> > @@ -1432,9 +1432,9 @@ static int check_interleave_cap(struct cxl_decoder *cxld, int iw, int ig)
> >  	return 0;
> >  }
> >  
> > -static int cxl_port_setup_targets(struct cxl_port *port,
> > -				  struct cxl_region *cxlr,
> > -				  struct cxl_endpoint_decoder *cxled)
> > +static int cxl_switch_port_setup_targets(struct cxl_port *port,
> 
> Pass in cxlsd since it's a switch port function? That would enforce the type.
> 
> DJ

oops...overlooked in v3 but picked up for v4.

Thanks!