Linux CXL
 help / color / mirror / Atom feed
From: Alison Schofield <alison.schofield@intel.com>
To: <nvdimm@lists.linux.dev>, Ben Cheatham <Benjamin.Cheatham@amd.com>
Cc: <linux-cxl@vger.kernel.org>
Subject: Re: [ndctl PATCH] cxl/list: handle missing debugfs when reporting protocol injection
Date: Fri, 23 Oct 2026 15:12:59 -0700	[thread overview]
Message-ID: <atvb60hJotejiLNG@aschofie-mobl2.lan> (raw)
In-Reply-To: <20261023011333.522080-1-alison.schofield@intel.com>

On Thu, Oct 22, 2026 at 06:13:32PM -0700, Alison Schofield wrote:
> When debugfs is not mounted or CONFIG_DEBUG_FS is disabled, 'cxl list -v'
> crashes while generating the protocol_injectable attribute for downstream
> ports.
> 
> The crash occurs because cxl_dport_get_einj_path() passes a NULL debugfs
> path to strlen().
> 
> Return NULL from cxl_dport_get_einj_path() when debugfs is unavailable,
> and omit protocol_injectable from the JSON output, consistent with other
> debugfs-dependent attributes. Update the documentation to match.
> 
> Thanks to Christopher Kim who reported and provided the fixup.
> 
> Originally-by: Christopher Kim
> Fixes: 5d596866f8c5 ("cxl/list: add injectable errors in output")
> Closes: https://github.com/pmem/ndctl/issues/300
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>

Applied to pending for NDCTL v86
https://github.com/pmem/ndctl/commit/1b126bf930c5

      parent reply	other threads:[~2026-10-23 22:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-23  1:13 [ndctl PATCH] cxl/list: handle missing debugfs when reporting protocol injection Alison Schofield
2026-10-23 13:37 ` Cheatham, Benjamin
2026-10-23 22:12 ` Alison Schofield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atvb60hJotejiLNG@aschofie-mobl2.lan \
    --to=alison.schofield@intel.com \
    --cc=Benjamin.Cheatham@amd.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox