Linux CXL
 help / color / mirror / Atom feed
From: Alison Schofield <alison.schofield@intel.com>
To: <nvdimm@lists.linux.dev>, Richard Cheng <icheng@nvidia.com>
Cc: <linux-cxl@vger.kernel.org>
Subject: Re: [ndctl PATCH 2/2] cxl/list: list locked zero-sized decoders
Date: Fri, 23 Oct 2026 19:55:19 -0700	[thread overview]
Message-ID: <atweF7k2bPbgjQPf@aschofie-mobl2.lan> (raw)
In-Reply-To: <018112d2f7890f3a3f38cc96aee5cf98cf5f3a9d.1785462417.git.alison.schofield@intel.com>

On Thu, Jul 30, 2026 at 06:55:20PM -0700, Alison Schofield wrote:
> 'cxl list' hides zero-sized decoders unless --idle is given, assuming
> they are unconfigured idle slots. That assumption does not hold for
> locked HDM decoders, which may legitimately report size 0 while being
> committed by firmware.
> 
> Do not suppress locked zero-sized decoders from the default listing.
> Combined with the "locked" field in the decoder JSON, they are visible
> and distinguishable from idle, unlocked slots that remain hidden
> without --idle.

Applied to pending for NDCTL v86
https://github.com/pmem/ndctl/commit/e252f4cc0792

> 
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
> ---
>  cxl/filter.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/cxl/filter.c b/cxl/filter.c
> index 5d634d3b2512..e6d45ac7b9e6 100644
> --- a/cxl/filter.c
> +++ b/cxl/filter.c
> @@ -847,7 +847,8 @@ static void walk_decoders(struct cxl_port *port, struct cxl_filter_params *p,
>  		if (!util_cxl_decoder_filter_by_region(decoder,
>  						       p->region_filter))
>  			goto walk_children;
> -		if (!p->idle && cxl_decoder_get_size(decoder) == 0)
> +		if (!p->idle && cxl_decoder_get_size(decoder) == 0 &&
> +		    !cxl_decoder_is_locked(decoder))
>  			continue;
>  		jdecoder = util_cxl_decoder_to_json(decoder, flags);
>  		if (!decoder) {
> -- 
> 2.37.3
> 

  parent reply	other threads:[~2026-10-24  2:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-31  1:55 [ndctl PATCH 1/2] cxl/list: emit decoder locked status Alison Schofield
2026-07-31  1:55 ` [ndctl PATCH 2/2] cxl/list: list locked zero-sized decoders Alison Schofield
2026-07-31 15:40   ` Dave Jiang
2026-08-07  5:10     ` Richard Cheng
2026-10-24  2:29       ` Alison Schofield
2026-10-24  2:55   ` Alison Schofield [this message]
2026-07-31 15:40 ` [ndctl PATCH 1/2] cxl/list: emit decoder locked status Dave Jiang
2026-08-07  5:07   ` Richard Cheng
2026-10-24  2:56 ` Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atweF7k2bPbgjQPf@aschofie-mobl2.lan \
    --to=alison.schofield@intel.com \
    --cc=icheng@nvidia.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox