From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793178599; b=Q9xxfsA1Usl4SCYIgqOfYA2Cfzf8NcNvq3Tczj48Vcq7xK0vKxi9OPPKPI8/9eTYmi/p +kOkRWcJ9xprioMN4ULmhKn3LTMsmWGhaYdotwkpb3Y/jDQXOfT6Ti6uKonYbmejVsNkw yuyQYOnM5MOKHEJLSs7H5QHcT2IRWqRprGIG+Wr9acNt9b3xmkXjXh1Q3rjo/YgmRoBUw zSAQubc/DKr+caeaApJOtKpe0iTx4sIrq0W+7c5HaZDSoJnESeLcUmkZdFjL1iihrQ19E njCjbte+iF5j8WlvPyJUQ1BM8k/5BXbhtgbfnT2oVNCr1M155hnUmLE1WWgyYOgwAMg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793178599; h=Received:DKIM-Signature:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=bLZSl7G53VjRTMzaR+4ybREso2p4MLSxqwNzQhyf3As=; b=nuGYCQbCmQBoRwLptFc7Du8bvY1hngiyb5bOoNHOa1kWmqoi5kCxu31zJ1iYEeo+AjGQ F6aSwAdJXcFyubpKDPX4kJePeW+Wys+k8FVCHUkRYKymOGZKekxHwzsmES2mCftKC4eBr FHqcBKX0pDLgtcYPUOzjzVRhKjT5rsXzDHfq/ugtM9QyvlaF5+SdskZ/sQuRcxdA0Tomb 0be3+tuetWjeISKNbiv9AFUZF33MmmefmZS6xbf0vHZaw12XYFd025n/6i6B+8ZVqKxkt TrGMR86Z3wJ9zq91qdNb3osj71cZQdQw8FlaWtcQ0/ZP7v2E4CLCrlm0o6nSfWwIj4w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=IQLvv5Vy; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D29E2606A31D; Wed, 28 Oct 2026 09:09:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=IQLvv5Vy Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61CEF1F01825; Wed, 28 Oct 2026 09:09:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793178598; bh=bLZSl7G53VjRTMzaR+4ybREso2p4MLSxqwNzQhyf3As=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=IQLvv5VyEW9W822k4mht+xeLq3S4XizAu+yULPQZsw/IVShZGFw4v2DipYDdBsIDM ZuO9nCZm9CpX8w5ml0a91JdjeCai4IiV9QbHxDf8RJ5flGZR1CGm3IoGtSym8UApk4 Csg/F36qW6LxKG3+BIRu5428gBcRYr7WkphITq9nSu15oEzQk7PBodVhHzdvwyKAsU L0DDpJRkU7kCsCA8XIudNovrwViAworRTX8BBm8mzz3lW+kK0r+b10tnjOyJB2Z4jA ml2WMykb/ecw+qvzqKMXuJLLemM/U4ijkpfsw/rwxPj03zXiSs2jn466I+8Fyr4hbl WjWlEy8zwut6w== Date: Wed, 28 Oct 2026 09:09:42 +0000 From: "Lorenzo Stoakes (ARM)" To: "David Hildenbrand (Arm)" Cc: Dev Jain , Andrew Morton , Johannes Weiner , Michal Hocko , Qi Zheng , Shakeel Butt , Kairui Song , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Baoquan He , Baolin Wang , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Kees Cook , Peter Zijlstra , Jann Horn , Pedro Falcato , Hugh Dickins , Pasha Tatashin , Pratyush Yadav , "Matthew Wilcox (Oracle)" , Jan Kara , Zi Yan , Lance Yang , Rik van Riel , Harry Yoo , Alistair Popple , Nico Pache , Ryan Roberts , Usama Arif , Kiryl Shutsemau , Matthew Brost , John Hubbard , Peter Xu , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Oscar Salvador , Minchan Kim , Muchun Song , Xu Xin , Chengming Zhou , Chris Li , Kemeng Shi , Nhat Pham , Youngjun Park , Gregory Price , Joshua Hahn , Rakie Kim , Ying Huang , Jason Gunthorpe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-cxl@vger.kernel.org, stable@vger.kernel.org, Josef Bacik Subject: Re: [PATCH 09/46] mm/rmap: handle device-exclusive entries in folio_referenced_one() Message-ID: References: <20261027-fixes_core-v1-0-6f74bec9a5bb@kernel.org> <20261027-fixes_core-v1-9-6f74bec9a5bb@kernel.org> X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Oct 28, 2026 at 09:08:04AM +0100, David Hildenbrand (Arm) wrote: > >> - if (lru_gen_enabled() && !lru_gen_switching() && pvmw.pte) { > >> + if (lru_gen_enabled() && !lru_gen_switching() && pvmw.pte && > >> + pte_present(pteval)) { > >> if (lru_gen_look_around(&pvmw, nr)) > >> referenced++; > >> } else if (pvmw.pte) { > >> - if (clear_flush_young_ptes_notify(vma, address, pvmw.pte, nr)) > >> + bool young = false; > >> + > >> + /* > >> + * PFN swap PTEs, such as device-exclusive ones, that > > > > You mean "PFN softleaf PTEs"? Better expressed as "softleaf PTEs embedding a PFN" ... > > Lorenzo raised this off-list as well; I'm using the existing text we use > elsewhere for consistency. > > This needs a cleanup that adjusts all of them :) *like a proud dad of his softleaf name :P* Yeah, agreed, not a big deal, and easier for me to just do a bigger pass finishing off what I started :P -- Cheers, Lorenzo