From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.217.43 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793206566; b=CJ0Oz3bDWthcFK3wFEepDw+0GA+tFBcIQBWfC1x4lLT5wxpb09PDqaZ1n4fMI/M7Y8T4 8y03aJDe2V4rhHP2BTsP81QXmL+IQtPZgG4WjRV/OLPTo13L3MvH+KI9nXH0ayp2aBj7+ s8tSZe1X65qFc8eamE5twKygZhvdU68JYeL+THyv4BzcsSddNORVHqt8kLjT3lJDLZkI1 FMpY+wXOJTX7VexAGcIZJgYaVAztUw5G8IGkeTZq3FIqczEphrdomOUkqFF1KMePFk72v lkOSPrdqhf679bJdvAZfd8QzMr06u9ygyGPfKRyglhuaUmGK+EYrZkAX+ApKc7MJS1A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793206566; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=r3C0d19m+/iHxVzVsZqZF5QMTPBWCH1ibPkdNy3hhyQ=; b=H80k40+6QPVZmf6B2vcRqlwmjftVi9eURAsB2hS/Fksuac7f7gVnUKAN3hPNbw//RwyT syzsOjqiyQm6tL8a4LUzG4/xss2bydhuOjki0BmETNq4fWxxaZ/ugFnNtfs7c/bb6tuob Kfgg0p1n0MB21vTwqNzcTW0NLaJd0CgT52sie5xsVhT309A9NooPD2bHnr6vA8jOuDsfY h38ZuvREeUrTasJSEQVj0lIGdL4CkjYNWBI5zgCO3QFEWI4fNTK1tCVMoTfzi81qhulxb InVFFGSYegisDWYjoDugdW1EZQrhrn/cmOPyIcBuQr4XOnEvVR3Ht/qKntpmr3rDvvA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=soleen.com; spf=pass smtp.mailfrom=soleen.com; dkim=pass header.d=soleen.com header.i=@soleen.com header.a=rsa-sha256 header.s=google header.b=RLxEwpL1; arc=none smtp.remote-ip=209.85.217.43 Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 673F7606A31E for ; Wed, 28 Oct 2026 16:56:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 673F7606A31E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=soleen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=soleen.com header.i=@soleen.com header.a=rsa-sha256 header.s=google header.b=RLxEwpL1 Received: by mail-vs1-f43.google.com with SMTP id ada2fe7eead31-7c03a445cb8so758495137.0 for ; Wed, 28 Oct 2026 09:56:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1793206564; x=1793811364; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=r3C0d19m+/iHxVzVsZqZF5QMTPBWCH1ibPkdNy3hhyQ=; b=RLxEwpL1hIyB/8de987ZDlpeLtVUV1o6ZwdAJJ5mPDG/A2ay9kTAD4XqeALAUEZc7T E+rNOMrhz40DYs3ycXgV4yPyi2Usq+ABEvzGTdQ6EpE08oZlMGrXBuZn0oksHESP214x HOhO5Bk+S9aZF/Fy2QjBdly76Bg3QJbA3fHIMsPq+C8FaEknA6C+IUV0EwW0bTP9/zWQ OOiQwebdi3deLoTwUunNlh8mr6V4B5Us/zvAKXtM1PltIwFDSzlYp0tYCGFgZb7w9dqp BlbKIJP2xgxwiBLxFNlTcmwU0vPots5dguJS0n27G0NkKxZIVloQxL0s3OxtMGYRXIkB K+lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793206564; x=1793811364; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=r3C0d19m+/iHxVzVsZqZF5QMTPBWCH1ibPkdNy3hhyQ=; b=gElIpFefU5kv3iJoGZeZaIQyqnOfcftRVjtzRmGp+NmM0vuNugcc7+9hEyLcuUjzoQ atV0vp7+oBnKEbxiqNqGV9wG3preK9yOpxzU5wLst6G87nH7noK546GzqXGWmsmZbQ1p b1kHPucX8l54YthLAFRfGGR+sOHbc33uA9kVuY2nET4e0K2uXVdY/4vJrO0okD3Phfxr oyEI3r3++YAmRWZQUArCkBYm3EdowPFQojnJMwDpVBTTo6uYXoEC8NiRNw6mRXxIkBhE ye5hJJnW1vb/DV1kM+gxzbwFOc8sUuoqnn0j+ozJZkvqovx4zoTvWZbS9kedVNrv5cBp YXQA== X-Forwarded-Encrypted: i=1; AKwUvBy8Z0L5gb/L736pwpR+6iis47Ig8Wqqy060MbsMWj2YhMotBa42wmvVTCkudav65TvxpXz+l6KRplM=@vger.kernel.org X-Gm-Message-State: AFq9FYKK60hVgZrVtjHygdvtaI0qiQM71N0yyAwI4w8fWiJ30daprcJO FOUIm58xbMkFJ2ioID6g1rIgTBDBWZJU+Q7p21/yiAxgoetItIRrUCTc6D8itnliVAI= X-Gm-Gg: AYBFou1UT8+FBXBkKk3bSiSHIWoiRNGA9GV+yFH6NLu2Alrs84TKz70eqtHujN8ZCAe mEbYPqM6/DK8xO+iKR5GXqUNF72p5IVWREX+XxQ4CMS8u2MVyLKJ5JqMkh81hXpsVc24R+w9ZyT 0ilOGLXKU/O6svpbx9khlEkwS9E+NY9RwRXyTImfYGtWtqWoe6K+yW/cmDvKD35yg56K+Lefh5l pvD+0ewhymzQG5lTeqa1fcTocwNMTKKfQVL07jHNmJ4n9GjkOTeEAyTNPgNy5oN0A0vWD0Sy9Jo hPD8CxePg3cTZ/6rlguj7JwsVMsMXzOd30HtemAtjzAxI8xq/J6JGi+/S0MoAHgCf7YXhG/7uI7 3RjJjEC3yyG2szceNdF77I+0RBZZJAL48MUZUK7brbv+fKa/8kJkAL9UB7mRqodky3Nmco3Llcn xozHrOqnc5XobVWoxfuezWW+isrRFURjCgisCG0QyML2sAQOxjwJ2v4/QySpVM+Y1EA/G1AvFqA /3KUD+dT0+CGAQYM+rDqBWO58DubTADRhf0lP22e4MhR+OPhSkSgD1R2pzRGGT7qyxboGIpapz6 WdK/X8qak7UyY7dOh9IVplfNKQZpcHjrD9N+y3PhYn5AUpZsJYC8dY0ToI23qlVvJNo6QXk+uZv bVttnDxFAlw4/ScYSbTRVsqqXA6C2Ol6YN6sBojgiOTf56sE2lMeO X-Received: by 2002:a05:6102:370e:b0:7ce:a79e:75a9 with SMTP id ada2fe7eead31-7d03a59dbf7mr1528233137.36.1793206564343; Wed, 28 Oct 2026 09:56:04 -0700 (PDT) Received: from google.com (16.49.199.35.bc.googleusercontent.com. [35.199.49.16]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-991259fbcbfsm6525438241.10.2026.10.28.09.56.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2026 09:56:02 -0700 (PDT) Date: Wed, 28 Oct 2026 12:56:01 -0400 From: Pasha Tatashin To: "David Hildenbrand (Arm)" Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Qi Zheng , Shakeel Butt , Lorenzo Stoakes , Kairui Song , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Baoquan He , Baolin Wang , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Kees Cook , Peter Zijlstra , Jann Horn , Pedro Falcato , Hugh Dickins , Pasha Tatashin , Pratyush Yadav , "Matthew Wilcox (Oracle)" , Jan Kara , Zi Yan , Lance Yang , Rik van Riel , Harry Yoo , Alistair Popple , Nico Pache , Ryan Roberts , Dev Jain , Usama Arif , Kiryl Shutsemau , Matthew Brost , John Hubbard , Peter Xu , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Oscar Salvador , Minchan Kim , Muchun Song , Xu Xin , Chengming Zhou , Chris Li , Kemeng Shi , Nhat Pham , Youngjun Park , Gregory Price , Joshua Hahn , Rakie Kim , Ying Huang , Jason Gunthorpe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-cxl@vger.kernel.org, stable@vger.kernel.org, Josef Bacik Subject: Re: [PATCH 38/46] mm/ksm: reset the unstable trees of all nodes Message-ID: References: <20261027-fixes_core-v1-0-6f74bec9a5bb@kernel.org> <20261027-fixes_core-v1-38-6f74bec9a5bb@kernel.org> X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261027-fixes_core-v1-38-6f74bec9a5bb@kernel.org> On 10-27 00:17, David Hildenbrand (Arm) wrote: > Each full scan resets ksm_nr_node_ids unstable tree roots. Enabling > merge_across_nodes resets this count to 1, even if per-node roots were > previously allocated. > > So when toggling "merge_across_nodes" 0 -> 1 -> 0, a scan that starts > while the setting is 1 and continues after switching back to 0 can > encounter stale unstable tree roots, resulting in UAF. > > Only root is allowed to change "merge_across_nodes", and the documented > sequence is: "merge_across_nodes setting can be changed only when there > are no ksm shared pages in the system: set run 2 to unmerge pages first, > then to 1 after changing merge_across_nodes, to remerge according to the > new setting." > > Let's fix it by tracking in ksm_nr_node_ids the actual number of > allocated tree roots. > > remove_all_stable_nodes() and ksm_check_stable_tree() will now scan > more tree roots (skipping the empty ones), which is harmless. > > Fixes: ef53d16cded7 ("ksm: allocate roots when needed") > Cc: stable@vger.kernel.org > Reported-by: Josef Bacik > Signed-off-by: David Hildenbrand (Arm) > --- > mm/ksm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index dbfb8f98b1892..9c51925825cbf 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -475,6 +475,7 @@ static void advisor_stop_scan(void) > #ifdef CONFIG_NUMA > /* Zeroed when merging across nodes is not allowed */ > static unsigned int ksm_merge_across_nodes = 1; > +/* Number of allocated stable and unstable tree roots. */ > static int ksm_nr_node_ids = 1; > #else > #define ksm_merge_across_nodes 1U > @@ -3636,14 +3637,13 @@ static ssize_t merge_across_nodes_store(struct kobject *kobj, > else { > root_stable_tree = buf; > root_unstable_tree = buf + nr_node_ids; > + ksm_nr_node_ids = nr_node_ids; > /* Stable tree is empty but not the unstable */ > root_unstable_tree[0] = one_unstable_tree[0]; > } > } > - if (!err) { > + if (!err) > ksm_merge_across_nodes = knob; > - ksm_nr_node_ids = knob ? 1 : nr_node_ids; > - } Reviewed-by: Pasha Tatashin > } > mutex_unlock(&ksm_thread_mutex); > > > -- > 2.43.0 >