From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61518434E42 for ; Mon, 21 Sep 2026 17:38:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790012316; cv=none; b=o8vzVuBK5md/tqqMrixDRihHKjQ6D4X22iNi+M3MTo32he08SPzvY4IFqsQZiNtDFKFfr1yJDF10xuxuoUgm4lPdNwu3yIku0Nlr1GWoc1dQO3Jv5L73AH+ZUYcLLX1n8zwZHD4B0EsEuj/HN/6mFC2ISoxAwBBg5Tw8RWciRCQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790012316; c=relaxed/simple; bh=Xlv/AxjxOFv31D8DVUmFYg3/LbMCYuvnXERLTRUKfH8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i/TXVNujE1Kk0tuBsPmOyezbbEptxPowvoHthOI+5FKnu1gURVj1nfTUGbkX7ocMcSit6kvpM74A37W6rkKGKPKFbxVW/UVEsZog2+bLwV2cFZcAT7INhnuxhuHJRLeo+diRdbJKMeP/I9MgB0qQSN4mjOlod6dAjiUuiJnVzQ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=PmtvkTzA; arc=none smtp.client-ip=192.198.163.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="PmtvkTzA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1790012315; x=1821548315; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Xlv/AxjxOFv31D8DVUmFYg3/LbMCYuvnXERLTRUKfH8=; b=PmtvkTzAChcwqAb98GwHSHfK6FoTuFQWKq3mN8ikZ17rq0f/cixq6IhN 9qgtqm8lGp/O9Ucrgr6K1Oo4dBnMmPWfgr9xUgCfNrnUZkHwLUhnZ+UK/ /FoiA6Kcg4qqP+G88H2veanNipPsyOZt08MIwcM/8dbZb/rROr+GGxIZ7 YWAlqHzbLgjZK4xCcolsUvuhs2b7bHf7YV/n58bJM2zZGgn84g+GVVeRL pIISa4RnhvQ6ZYFwqoHb90iLinxdouv4nhMTE1B1qxGFJzmqdFNGQdwEn 09azBksY3+oOTXwxmOwBhoj3QveZRwETpWXQMunh/A0OG9kqSie2/J/VA Q==; X-CSE-ConnectionGUID: L4DAW+ncSCOpVC5p2yOrDw== X-CSE-MsgGUID: NDilJVjjSP+FTyjjsQ4qqA== X-IronPort-AV: E=McAfee;i="6800,10657,11912"; a="1060619" X-IronPort-AV: E=Sophos;i="6.27,115,1787036400"; d="scan'208";a="1060619" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa114.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2026 10:38:34 -0700 X-CSE-ConnectionGUID: wACOXqfnRyK2og0YwTa+bg== X-CSE-MsgGUID: e7ipcMgHQpanEVNpwfuiag== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,115,1787036400"; d="scan'208";a="300708529" Received: from aschende-mobl.amr.corp.intel.com (HELO [10.125.109.234]) ([10.125.109.234]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2026 10:38:34 -0700 Message-ID: Date: Mon, 21 Sep 2026 10:38:32 -0700 Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] cxl/events: Fix event type check for CME counter expiration To: Alison Schofield , Guixin Liu Cc: Davidlohr Bueso , Jonathan Cameron , Vishal Verma , Dan Williams , Ira Weiny , Li Ming , linux-cxl@vger.kernel.org References: <20260921120932.1769566-1-kanie@linux.alibaba.com> From: Dave Jiang Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/21/26 10:28 AM, Alison Schofield wrote: > On Mon, Sep 21, 2026 at 08:09:32PM +0800, Guixin Liu wrote: > > > Hi Guixin, > > Agree w DaveJ's commit log suggestion. > > Also, the Subject can be specific, like: > cxl/events: Test CME counter expiry with equality, not bitwise AND > > You may want to add something like I've appended below to your agent instructions. > It is intended to better calibrate your agent. Also try giving your agent this > patch (v1 and v2) as a concrete example in the skill. It's a good one because the > original one isn't bad, it is actually thorough and technically valid, but it is > trying to make the commit log serve as the entire bug report, reproduction recipe > and test report. That's exactly the tendency you want this agent to stop doing. > > Teach your agent (w example): > > For Linux kernel commit messages, be concise and focus on why the change is > needed, not a detailed narration of the investigation. > > Structure the commit message as: > > 1. Background only when needed to understand the problem. > 2. Problem: what the current code gets wrong. > 3. Impact: the meaningful consequence, especially user-visible impact. > 4. Resolution: what the patch changes and why that addresses the problem. > 5. Brief "Found by" / "Tested by" information when useful. > > Do not include every example, reproduction step, intermediate observation, or > possible consequence just because that information is available. Keep only > details needed to establish the problem and impact. > > For small, obvious fixes, aim for roughly 1-3 short paragraphs plus concise > testing information. Explain the semantic error. Do not narrate the code diff. > > Subjects should describe the change specifically. Avoid generic "Fix ..." > subjects when a more descriptive imperative subject is available. > > -- Alison And if you are uisng an AI agent, please include the following tag: Assisted-by: LLM