From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35F03280A58; Tue, 10 Mar 2026 20:52:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773175976; cv=none; b=J65mV2IcuwWukdNKlGWF/C7DO4ZmcRDBCEtkUhBy1bbEfDqHcgIYEshmUyMWSYeFLguayK6omZxHYj9XLT0DDmCPM1p/UTdJzjVPbWNnsAv8en+X6iWQyqMkHevJJYAKiFmg6X7caMhqkHnXJUPlr2MdX27vwwdSlHZROgZwZN8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773175976; c=relaxed/simple; bh=LNTcrL+7j4P7s27CbshnB33QtRfdrEyjVTlhAe3P40g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jDMN1d0U7hFvLPOZQPW11dAi0lmYYcbv7fYr7bdb0Z7TkfaDIQYcZFDE9cSxXeaEOPuNtknxO0ZKIXUcxD9Y7zjhfd3+VhJ+QC4HSMfz7k7wKEK17lEfZHyqQNYKwROS3/32BnTGkZZEemxN3AntBwQyQAjHUonJL1uAzMIuXjw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ZmMzqY41; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZmMzqY41" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773175974; x=1804711974; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=LNTcrL+7j4P7s27CbshnB33QtRfdrEyjVTlhAe3P40g=; b=ZmMzqY41JPlp2Ws/zpU1SGXYSZXr9G/F9/gjBBGK8maH0/voZ6iYj7Ta tqxHzcwLZ6epuarrRjhIhgPd0AO1Rfaz5nEW2fKrJr9yn9EP+1uPjPTu/ sZBpIjofPMHgKJfZA6+NL+OjopdPcF0JbyVM+F2iARGpTO1+Jmh+Ks40k AkNmqRpyzEzKvChdG7lszDJG1y8YKHmeTkFngj9dXFb+p58FVHM1qGNlF Cwl74rgZG6gRF4jXSMgubwv+uRnjQIOeeRQsR6FEFwcRHWSK/pb6Cb6dT zf/iVZ/348JZyyGlduUR7vPRjMhdhZ4TyP3b8PWUSlIJZZtvie5x/qV8B w==; X-CSE-ConnectionGUID: 7Jv/OKLiTe6pJpSGnr00Tw== X-CSE-MsgGUID: 47jDQFSTTBKENz8kBTgtXg== X-IronPort-AV: E=McAfee;i="6800,10657,11725"; a="85711823" X-IronPort-AV: E=Sophos;i="6.23,112,1770624000"; d="scan'208";a="85711823" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2026 13:52:53 -0700 X-CSE-ConnectionGUID: +2llLIE0R/ORTIviqVYhzQ== X-CSE-MsgGUID: SAzQlYRqSpiIRLrgDlrYmg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,112,1770624000"; d="scan'208";a="216975211" Received: from aduenasd-mobl5.amr.corp.intel.com (HELO [10.125.110.11]) ([10.125.110.11]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2026 13:52:52 -0700 Message-ID: Date: Tue, 10 Mar 2026 13:52:50 -0700 Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/7] cxl/pci: Hold memdev lock in cxl_event_trace_record() To: Li Ming , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Davidlohr Bueso , Jonathan Cameron , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Bjorn Helgaas , Ben Cheatham Cc: driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org References: <20260310-fix_access_endpoint_without_drv_check-v1-0-94fe919a0b87@zohomail.com> <20260310-fix_access_endpoint_without_drv_check-v1-4-94fe919a0b87@zohomail.com> Content-Language: en-US From: Dave Jiang In-Reply-To: <20260310-fix_access_endpoint_without_drv_check-v1-4-94fe919a0b87@zohomail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/10/26 8:57 AM, Li Ming wrote: > This is a preparatory patch for the following changes. > > To enable endpoint validity checks in cxl_dpa_to_region(). > cxl_dpa_to_region() has to require caller to hold CXL memdev lock to > ensure the CXL memdev probing is completed. > > So holding the given CXL memdev lock before invoking cxl_dpa_to_region() > in cxl_event_trace_record(). > > Suggested-by: Dan Williams > Signed-off-by: Li Ming With what Dan said, Reviewed-by: Dave Jiang > --- > drivers/cxl/core/mbox.c | 5 +++-- > drivers/cxl/cxlmem.h | 2 +- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index e7a6452bf544..3f34bbabf4d3 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -893,7 +893,7 @@ int cxl_enumerate_cmds(struct cxl_memdev_state *mds) > } > EXPORT_SYMBOL_NS_GPL(cxl_enumerate_cmds, "CXL"); > > -void cxl_event_trace_record(const struct cxl_memdev *cxlmd, > +void cxl_event_trace_record(struct cxl_memdev *cxlmd, > enum cxl_event_log_type type, > enum cxl_event_type event_type, > const uuid_t *uuid, union cxl_event *evt) > @@ -920,6 +920,7 @@ void cxl_event_trace_record(const struct cxl_memdev *cxlmd, > * translations. Take topology mutation locks and lookup > * { HPA, REGION } from { DPA, MEMDEV } in the event record. > */ > + guard(device)(&cxlmd->dev); > guard(rwsem_read)(&cxl_rwsem.region); > guard(rwsem_read)(&cxl_rwsem.dpa); > > @@ -968,7 +969,7 @@ void cxl_event_trace_record(const struct cxl_memdev *cxlmd, > } > EXPORT_SYMBOL_NS_GPL(cxl_event_trace_record, "CXL"); > > -static void __cxl_event_trace_record(const struct cxl_memdev *cxlmd, > +static void __cxl_event_trace_record(struct cxl_memdev *cxlmd, > enum cxl_event_log_type type, > struct cxl_event_record_raw *record) > { > diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h > index e21d744d639b..7a34a19c02c8 100644 > --- a/drivers/cxl/cxlmem.h > +++ b/drivers/cxl/cxlmem.h > @@ -864,7 +864,7 @@ void set_exclusive_cxl_commands(struct cxl_memdev_state *mds, > void clear_exclusive_cxl_commands(struct cxl_memdev_state *mds, > unsigned long *cmds); > void cxl_mem_get_event_records(struct cxl_memdev_state *mds, u32 status); > -void cxl_event_trace_record(const struct cxl_memdev *cxlmd, > +void cxl_event_trace_record(struct cxl_memdev *cxlmd, > enum cxl_event_log_type type, > enum cxl_event_type event_type, > const uuid_t *uuid, union cxl_event *evt); >