From: Dave Jiang <dave.jiang@intel.com>
To: Alok Tiwari <alok.a.tiwari@oracle.com>,
gourry@gourry.net, rdunlap@infradead.org, dave@stgolabs.net,
jonathan.cameron@huawei.com, alison.schofield@intel.com,
vishal.l.verma@intel.com, ira.weiny@intel.com,
dan.j.williams@intel.com, corbet@lwn.net,
linux-cxl@vger.kernel.org, linux-doc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, darren.kenny@oracle.com
Subject: Re: [PATCH v3] Documentation: cxl: fix typos and improve clarity in memory-devices.rst
Date: Mon, 9 Jun 2025 13:42:30 -0700 [thread overview]
Message-ID: <b5ac9dcf-60e9-465a-a864-58ff48dcae61@intel.com> (raw)
In-Reply-To: <20250609171130.2375901-1-alok.a.tiwari@oracle.com>
On 6/9/25 10:10 AM, Alok Tiwari wrote:
> This patch corrects several typographical issues and improves phrasing
> in memory-devices.rst:
>
> - Fixes duplicate word ("1 one") and adjusts phrasing for clarity.
> - Adds missing hyphen in "on-device".
> - Corrects "a give memory device" to "a given memory device".
> - fix singular/plural "decoder resource" -> "decoder resources".
> - Clarifies "spans to Host Bridges" -> "spans two Host Bridges".
> - change "at a" -> "a"
>
> These changes improve readability and accuracy of the documentation.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
> Reviewed-by: Gregory Price <gourry@gourry.net>
> Reviewed-by: Jonathan Cameron<jonathan.cameron@huawei.com>
Applied to cxl/next
> ---
> v2->v3
> rebase to v6.16-rc1
> added Reviewed-by: Jonathan Cameron
> v1->v2
> added Reviewed-by Randy Dunlap and Gregory Price
> change "at a" -> "a
> ---
> Documentation/driver-api/cxl/theory-of-operation.rst | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/driver-api/cxl/theory-of-operation.rst b/Documentation/driver-api/cxl/theory-of-operation.rst
> index 40793dad3630..257f513e320c 100644
> --- a/Documentation/driver-api/cxl/theory-of-operation.rst
> +++ b/Documentation/driver-api/cxl/theory-of-operation.rst
> @@ -29,8 +29,8 @@ Platform firmware enumerates a menu of interleave options at the "CXL root port"
> (Linux term for the top of the CXL decode topology). From there, PCIe topology
> dictates which endpoints can participate in which Host Bridge decode regimes.
> Each PCIe Switch in the path between the root and an endpoint introduces a point
> -at which the interleave can be split. For example platform firmware may say at a
> -given range only decodes to 1 one Host Bridge, but that Host Bridge may in turn
> +at which the interleave can be split. For example, platform firmware may say a
> +given range only decodes to one Host Bridge, but that Host Bridge may in turn
> interleave cycles across multiple Root Ports. An intervening Switch between a
> port and an endpoint may interleave cycles across multiple Downstream Switch
> Ports, etc.
> @@ -187,7 +187,7 @@ decodes them to "ports", "ports" decode to "endpoints", and "endpoints"
> represent the decode from SPA (System Physical Address) to DPA (Device Physical
> Address).
>
> -Continuing the RAID analogy, disks have both topology metadata and on device
> +Continuing the RAID analogy, disks have both topology metadata and on-device
> metadata that determine RAID set assembly. CXL Port topology and CXL Port link
> status is metadata for CXL.mem set assembly. The CXL Port topology is enumerated
> by the arrival of a CXL.mem device. I.e. unless and until the PCIe core attaches
> @@ -197,7 +197,7 @@ the Linux PCI core to tear down switch-level CXL resources because the endpoint
> ->remove() event cleans up the port data that was established to support that
> Memory Expander.
>
> -The port metadata and potential decode schemes that a give memory device may
> +The port metadata and potential decode schemes that a given memory device may
> participate can be determined via a command like::
>
> # cxl list -BDMu -d root -m mem3
> @@ -249,8 +249,8 @@ participate can be determined via a command like::
> ...which queries the CXL topology to ask "given CXL Memory Expander with a kernel
> device name of 'mem3' which platform level decode ranges may this device
> participate". A given expander can participate in multiple CXL.mem interleave
> -sets simultaneously depending on how many decoder resource it has. In this
> -example mem3 can participate in one or more of a PMEM interleave that spans to
> +sets simultaneously depending on how many decoder resources it has. In this
> +example mem3 can participate in one or more of a PMEM interleave that spans two
> Host Bridges, a PMEM interleave that targets a single Host Bridge, a Volatile
> memory interleave that spans 2 Host Bridges, and a Volatile memory interleave
> that only targets a single Host Bridge.
prev parent reply other threads:[~2025-06-09 20:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 17:10 [PATCH v3] Documentation: cxl: fix typos and improve clarity in memory-devices.rst Alok Tiwari
2025-06-09 20:42 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5ac9dcf-60e9-465a-a864-58ff48dcae61@intel.com \
--to=dave.jiang@intel.com \
--cc=alison.schofield@intel.com \
--cc=alok.a.tiwari@oracle.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=darren.kenny@oracle.com \
--cc=dave@stgolabs.net \
--cc=gourry@gourry.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox