From: Dave Jiang <dave.jiang@intel.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: djbw@kernel.org, jic23@kernel.org, alison.schofield@intel.com,
linux-cxl@vger.kernel.org
Subject: Re: [PATCH] cxl/test: Map mock device nodes to an online node
Date: Thu, 23 Jul 2026 13:44:02 -0700 [thread overview]
Message-ID: <bcbc5578-8f95-4c27-b07d-9b5fa1ad4baa@intel.com> (raw)
In-Reply-To: <20260723180630.1302871-1-dave@stgolabs.net>
On 7/23/26 11:06 AM, Davidlohr Bueso wrote:
> cxl_mem_init() assigns alternating NUMA nodes to the mock memdevs
> to model multi-node topologies. On a single-node host node 1 has
> no pgdat, and the first node-aware allocation in an odd device's
> probe faults on a NULL zonelist:
>
> Oops: general protection fault, probably for non-canonical address 0xdffffc00000006e3
> KASAN: probably user-memory-access in range [0x0000000000003718-0x000000000000371f]
> Workqueue: async async_run_entry_fn
> RIP: __alloc_frozen_pages_noprof+0x288
> new_slab
> ___slab_alloc
> __kmalloc_node_track_caller_noprof
> devm_kmalloc
> cxl_mock_mem_probe
>
> Map the requested node to an online one, as dax_hmem already does
> for its target node.
>
> Fixes: cf1f6877b088 ("cxl/memdev: Add numa_node attribute")
> Fixes: e41c8452b9b2 ("tools/testing/cxl: Add a single-port host-bridge regression config")
> Fixes: c9435dbee119 ("tools/testing/cxl: Add an RCH topology")
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> Found while regression testing unrelated work.
>
> tools/testing/cxl/test/cxl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
> index ef92dd35e030..5156516a82d2 100644
> --- a/tools/testing/cxl/test/cxl.c
> +++ b/tools/testing/cxl/test/cxl.c
> @@ -1748,7 +1748,7 @@ static int cxl_mem_init(void)
> if (!pdev)
> goto err_mem;
> pdev->dev.parent = &dport->dev;
> - set_dev_node(&pdev->dev, i % 2);
> + set_dev_node(&pdev->dev, numa_map_to_online_node(i % 2));
>
> rc = cxl_mock_platform_device_add(pdev, &cxl_mem[i]);
> if (rc)
> @@ -1763,7 +1763,7 @@ static int cxl_mem_init(void)
> if (!pdev)
> goto err_single;
> pdev->dev.parent = &dport->dev;
> - set_dev_node(&pdev->dev, i % 2);
> + set_dev_node(&pdev->dev, numa_map_to_online_node(i % 2));
>
> rc = cxl_mock_platform_device_add(pdev, &cxl_mem_single[i]);
> if (rc)
> @@ -1779,7 +1779,7 @@ static int cxl_mem_init(void)
> if (!pdev)
> goto err_rcd;
> pdev->dev.parent = &rch->dev;
> - set_dev_node(&pdev->dev, i % 2);
> + set_dev_node(&pdev->dev, numa_map_to_online_node(i % 2));
>
> rc = cxl_mock_platform_device_add(pdev, &cxl_rcd[i]);
> if (rc)
prev parent reply other threads:[~2026-07-23 20:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 18:06 [PATCH] cxl/test: Map mock device nodes to an online node Davidlohr Bueso
2026-07-23 20:44 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcbc5578-8f95-4c27-b07d-9b5fa1ad4baa@intel.com \
--to=dave.jiang@intel.com \
--cc=alison.schofield@intel.com \
--cc=dave@stgolabs.net \
--cc=djbw@kernel.org \
--cc=jic23@kernel.org \
--cc=linux-cxl@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).