From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C89D833556D for ; Thu, 14 May 2026 17:16:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778779007; cv=none; b=bRmrGYQytEM+c6Ii6S5Yh0UpJH94UBKpPsyL2ATyJU85vJmZzDvUSHtLrl/0qb04Hu7fxvI7qyrPwOrlLJChohfiWcMWbYFu3hXLnifxuDOjhWbbMTdGfijoiCgtuJwUGv3CvaaRxFkp/C46ATbjVIeMkQHMjGiOEonlPPh2YXI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778779007; c=relaxed/simple; bh=hnC/lfNqpctTim9a6fu/j27gRyLG1LO3+0tYOQi/H4c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZhteVpOi1Dmkxj70LOWZPONqKr9kqkqxIbAmoRGCwvUOkAU4rxfy6JStLxwOxay4LfCixx2WZu9zZ3TeJYcKc3Fzv++HyXrd93QUQFw+x3BLGjqGCdyhlTiztp0KQuqrmKaDRn3VEcrn5hNuz/UToQ8y8d5JQ/JJirisHIvSqfo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ang3TSqr; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ang3TSqr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778779007; x=1810315007; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=hnC/lfNqpctTim9a6fu/j27gRyLG1LO3+0tYOQi/H4c=; b=ang3TSqrfXOBMs00Y6dqdvSEdrcTR+X58hD2d3c1SlfD00m4IDIsdLsH Z3DR/9UrqCbvBM3u1m0H22a/Dx8frCTkxYe5ePTiZr2qmQUNvSXh+Ed3L fTEj8lz8csFjUOvJ4Gm4JMJx9fAMBUqTdyfk5g6JXq1LggGws542tDhi2 dxeaH6KpSxFio4u87E0hL9Oh1PXb62jajKqoFm6Vk1lKJk15TYYmW8aKU JA0QMsvUM2QkbloeI02pdg+h2xcl2pGCIIlOoTHUvzYxO25PdF9oO0ERo p3uSFLYz9wwRkTeN4/oNSapQqST08gzzq7beHmnl5DLl2gKZ7f9l7Ox7D g==; X-CSE-ConnectionGUID: o86jaYA7QByD1+m/XgtQ9Q== X-CSE-MsgGUID: YWMikpagQ7meBppMNaqZSA== X-IronPort-AV: E=McAfee;i="6800,10657,11786"; a="79585377" X-IronPort-AV: E=Sophos;i="6.23,235,1770624000"; d="scan'208";a="79585377" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2026 10:16:46 -0700 X-CSE-ConnectionGUID: ghn6Rx2dRDyBhEadq53Wug== X-CSE-MsgGUID: M62kff7vTaOIUPCrEYHkdg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,235,1770624000"; d="scan'208";a="238544279" Received: from rchatre-mobl4.amr.corp.intel.com (HELO [10.125.108.122]) ([10.125.108.122]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2026 10:16:46 -0700 Message-ID: Date: Thu, 14 May 2026 10:16:44 -0700 Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [ndctl PATCH 1/2] daxctl: fix kmod reference leak on probe-insert failure To: Chen Pei , alison.schofield@intel.com, nvdimm@lists.linux.dev Cc: linux-cxl@vger.kernel.org, guoren@kernel.org References: <20260514063234.86439-1-cp0613@linux.alibaba.com> <20260514063234.86439-2-cp0613@linux.alibaba.com> Content-Language: en-US From: Dave Jiang In-Reply-To: <20260514063234.86439-2-cp0613@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/13/26 11:32 PM, Chen Pei wrote: > daxctl_insert_kmod_for_mode() obtains a kmod reference via > kmod_module_new_from_name() and only stores it in dev->module after a > successful kmod_module_probe_insert_module() call. On the failure path > the local reference was returned without being released, leaking one > reference per failed enable attempt. > > Drop the reference before returning the error code. > > Signed-off-by: Chen Pei Reviewed-by: Dave Jiang > --- > daxctl/lib/libdaxctl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/daxctl/lib/libdaxctl.c b/daxctl/lib/libdaxctl.c > index 02ae7e5..ffc81eb 100644 > --- a/daxctl/lib/libdaxctl.c > +++ b/daxctl/lib/libdaxctl.c > @@ -927,6 +927,7 @@ static int daxctl_insert_kmod_for_mode(struct daxctl_dev *dev, > NULL, NULL, NULL, NULL); > if (rc < 0) { > err(ctx, "%s: insert failure: %d\n", devname, rc); > + kmod_module_unref(kmod); > return rc; > } > dev->module = kmod;