Re: [NDCTL PATCH v6 1/4] ndctl: cxl: Add QoS class retrieval for the root decoder

[Dave Jiang <dave.jiang@intel.com>]

On 2/7/24 1:13 PM, Alison Schofield wrote:
> On Wed, Feb 07, 2024 at 12:05:17PM -0800, Alison Schofield wrote:
>> On Wed, Feb 07, 2024 at 10:19:36AM -0700, Dave Jiang wrote:
>>> Add libcxl API to retrieve the QoS class for the root decoder. Also add
>>> support to display the QoS class for the root decoder through the 'cxl
>>> list' command. The qos_class is the QTG ID of the CFMWS window that
>>> represents the root decoder.
>>>
>>> Reviewed-by: Alison Schofield <alison.schofield@intel.com>
>>> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
>>> ---
>>
>> -snip-
>>
>>> @@ -136,6 +136,7 @@ int cmd_list(int argc, const char **argv, struct cxl_ctx *ctx)
>>>  		param.regions = true;
>>>  		/*fallthrough*/
>>>  	case 0:
>>> +		param.qos = true;
>>>  		break;
>>>  	}
>>
>> Add qos to the -vvv explainer in Documentation/cxl/cxl-list.txt 
> 
> My comment is wrong, since it is now an 'always displayed', not a -vvv.
> Why put it here at all then? I'm confused!

Just remove param.qos entirely?
> 
> 
>>
>>