Re: [RFC PATCH 5/6] cxl: Add extended linear cache address alias emission for cxl events

[Dave Jiang <dave.jiang@intel.com>]

On 10/17/24 9:38 AM, Jonathan Cameron wrote:
> On Fri, 27 Sep 2024 07:16:57 -0700
> Dave Jiang <dave.jiang@intel.com> wrote:
> 
>> Add the aliased address of exteneded linear cache when emitting event
> extended
> 
>> trace for DRAM and general media of CXL events.
>>
>> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> 
> Trivial comment inline. 
>> ---
>>  drivers/cxl/core/acpi.c   | 10 ++++++++++
>>  drivers/cxl/core/core.h   |  7 +++++++
>>  drivers/cxl/core/mbox.c   | 42 ++++++++++++++++++++++++++++++++++++---
>>  drivers/cxl/core/region.c |  2 +-
>>  drivers/cxl/core/trace.h  | 24 ++++++++++++++--------
>>  5 files changed, 73 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/cxl/core/acpi.c b/drivers/cxl/core/acpi.c
>> index f13b4dae6ac5..f74136320fc3 100644
>> --- a/drivers/cxl/core/acpi.c
>> +++ b/drivers/cxl/core/acpi.c
>> @@ -9,3 +9,13 @@ int cxl_acpi_get_extended_linear_cache_size(struct resource *backing_res,
>>  {
>>  	return hmat_get_extended_linear_cache_size(backing_res, nid, size);
>>  }
>> +
>> +int cxl_acpi_extended_linear_cache_address_xlat(u64 *address, u64 alias, int nid)
>> +{
>> +	return hmat_extended_linear_cache_address_xlat(address, alias, nid);
> 
> Can we just stub them out in acpi.h?  I'm not sure wrapping them gives us
> anything useful.

It's already stubbed out in acpi.h. Here it's wrapped so that core/mbox.c does not need pull in linux/acpi.h header.
> 
>> +}
>> +
>> +int cxl_acpi_extended_linear_cache_alias_xlat(u64 address, u64 *alias, int nid)
>> +{
>> +	return hmat_extended_linear_cache_alias_xlat(address, alias, nid);
>> +}
> 
>