Linux CXL
 help / color / mirror / Atom feed
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Jiang, Dave" <dave.jiang@intel.com>,
	"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>
Cc: "Williams, Dan J" <dan.j.williams@intel.com>,
	"Schofield, Alison" <alison.schofield@intel.com>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>,
	"Weiny, Ira" <ira.weiny@intel.com>
Subject: Re: [PATCH v4 04/10] cxl: add common function to disable event trace
Date: Tue, 8 Nov 2022 23:47:30 +0000	[thread overview]
Message-ID: <c85d3ee717b3fac27b08b6b1cb2aa8836f071cc5.camel@intel.com> (raw)
In-Reply-To: <166793221113.3768752.2422093575535918509.stgit@djiang5-desk3.ch.intel.com>

On Tue, 2022-11-08 at 11:30 -0700, Dave Jiang wrote:
> Add a common function for cxl command that disables the event trace for the
> instance created.
> 
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  cxl/event_trace.c |    5 +++++
>  cxl/event_trace.h |    1 +
>  2 files changed, 6 insertions(+)

This and the previous patch are very siomilar pre-requisite enabling -
I think they can be squashed into a single patch.

> 
> diff --git a/cxl/event_trace.c b/cxl/event_trace.c
> index 95b0ce071166..490c30e1dbfc 100644
> --- a/cxl/event_trace.c
> +++ b/cxl/event_trace.c
> @@ -251,3 +251,8 @@ int cxl_event_tracing_enable(struct tracefs_instance *inst, const char *system,
>         tracefs_trace_on(inst);
>         return 0;
>  }
> +
> +int cxl_event_tracing_disable(struct tracefs_instance *inst)
> +{
> +       return tracefs_trace_off(inst);
> +}
> diff --git a/cxl/event_trace.h b/cxl/event_trace.h
> index aecf9aa96187..89e98cafb320 100644
> --- a/cxl/event_trace.h
> +++ b/cxl/event_trace.h
> @@ -22,5 +22,6 @@ struct event_ctx {
>  int cxl_parse_events(struct tracefs_instance *inst, struct event_ctx *ectx);
>  int cxl_event_tracing_enable(struct tracefs_instance *inst, const char *system,
>                 const char *event);
> +int cxl_event_tracing_disable(struct tracefs_instance *inst);
>  
>  #endif
> 
> 


  reply	other threads:[~2022-11-08 23:47 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08 18:29 [PATCH v4 00/10] cxl: add monitor support for trace events Dave Jiang
2022-11-08 18:29 ` [PATCH v4 01/10] cxl: add helper function to parse trace event to json object Dave Jiang
2022-11-08 23:02   ` Verma, Vishal L
2022-11-09 21:27     ` Dave Jiang
2022-11-08 18:29 ` [PATCH v4 02/10] cxl: add helper to parse through all current events Dave Jiang
2022-11-08 23:45   ` Verma, Vishal L
2022-11-09 21:30     ` Dave Jiang
2022-11-08 18:30 ` [PATCH v4 03/10] cxl: add common function to enable event trace Dave Jiang
2022-11-08 18:30 ` [PATCH v4 04/10] cxl: add common function to disable " Dave Jiang
2022-11-08 23:47   ` Verma, Vishal L [this message]
2022-11-08 18:30 ` [PATCH v4 05/10] cxl: add monitor function for event trace events Dave Jiang
2022-11-17 18:37   ` Steven Rostedt
2022-11-17 20:29     ` Dave Jiang
2022-11-17 20:33       ` Steven Rostedt
2022-11-17 20:44         ` Dave Jiang
2022-11-08 18:30 ` [PATCH v4 06/10] cxl: add logging functions for monitor Dave Jiang
2022-11-09  0:31   ` Verma, Vishal L
2022-11-08 18:30 ` [PATCH v4 07/10] cxl: add monitor command to cxl Dave Jiang
2022-11-09  0:35   ` Verma, Vishal L
2022-11-08 18:30 ` [PATCH v4 08/10] cxl: add an optional pid check to event parsing Dave Jiang
2022-11-09  0:48   ` Verma, Vishal L
2022-11-09 22:44     ` Dave Jiang
2022-11-08 18:30 ` [PATCH v4 09/10] cxl: add systemd service for monitor Dave Jiang
2022-11-09  0:48   ` Verma, Vishal L
2022-11-08 18:30 ` [PATCH v4 10/10] cxl: add man page documentation " Dave Jiang
2022-11-09  0:58   ` Verma, Vishal L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c85d3ee717b3fac27b08b6b1cb2aa8836f071cc5.camel@intel.com \
    --to=vishal.l.verma@intel.com \
    --cc=alison.schofield@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox